From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD263C43381 for ; Mon, 18 Mar 2019 17:29:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9FD3D20989 for ; Mon, 18 Mar 2019 17:29:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dUkNyAqO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9FD3D20989 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JX1ncQiIodB/Ow/jibSXRu/Sdi0ycwzdpZT3frxjaGc=; b=dUkNyAqOJajuJx H73eyZKXb6/Ihw+TdQmD+nq+fFnBXBXRv+2Qod+NLGxqOXgUBLtpCxGgaDHgYWRU9EO+mNahvXnZe 4GCC9G2t5+RadMcFlZqaVacFcIdx9B21M42ZLK4qA8W21f/7BOfuTtj5/37p7LVAr4SwS2r3cdevf QImIuxPcGezEwz9blF9r5mHU2HveSUmsvRKyyEL3trYUeOSQYTnteKdjyPEFpHWth5S0tc9VIbkl2 5kxIHzGm00J6Li1MA4YsaF/qcEBTTZ9lwia03zqdCfrlwhpQ5AvguvJ5+npgWF7g4hz8VkrfYFmUE XLglpIYL5FiOzcI0YKuw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5w4e-0002Om-5P; Mon, 18 Mar 2019 17:29:20 +0000 Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5w4b-0002OR-Do for linux-arm-kernel@lists.infradead.org; Mon, 18 Mar 2019 17:29:18 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C7358308FBA9; Mon, 18 Mar 2019 17:29:15 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.43.17.34]) by smtp.corp.redhat.com (Postfix) with SMTP id 92F475D9C6; Mon, 18 Mar 2019 17:29:12 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 18 Mar 2019 18:29:15 +0100 (CET) Date: Mon, 18 Mar 2019 18:29:11 +0100 From: Oleg Nesterov To: Sudeep Holla Subject: Re: [PATCH v2 1/6] ptrace: move clearing of TIF_SYSCALL_EMU flag to core Message-ID: <20190318172911.GC23521@redhat.com> References: <20190318104925.16600-1-sudeep.holla@arm.com> <20190318104925.16600-2-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190318104925.16600-2-sudeep.holla@arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Mon, 18 Mar 2019 17:29:17 +0000 (UTC) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190318_102917_486288_187C276E X-CRM114-Status: GOOD ( 12.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Haibo Xu , Steve Capper , Catalin Marinas , jdike@addtoit.com, x86@kernel.org, Will Deacon , linux-kernel@vger.kernel.org, Bin Lu , Richard Weinberger , Ingo Molnar , Paul Mackerras , Andy Lutomirski , Michael Ellerman , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/18, Sudeep Holla wrote: > @@ -534,6 +534,10 @@ static int ptrace_detach(struct task_struct *child, unsigned int data) > /* Architecture-specific hardware disable .. */ > ptrace_disable(child); > > +#ifdef TIF_SYSCALL_EMU > + clear_tsk_thread_flag(child, TIF_SYSCALL_EMU); > +#endif perhaps it makes sense to factor out clear_tsk_thread_flag(TIF_SYSCALL_EMU), but then we should probably clear it along with TIF_SYSCALL_TRACE in __ptrace_unlink? Oleg. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel