From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC353C43381 for ; Tue, 19 Mar 2019 12:52:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C80320685 for ; Tue, 19 Mar 2019 12:52:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="c3Ydp7XW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="hZfD/Bb1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C80320685 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Su28dK2DgrzfT3iEq/iG2rOae7tkGQ9bzABrkisGAvU=; b=c3Ydp7XW+YtCkX jmZmgw747K0TvjosIEY8N3sJ63Z+cnlOxA3q5BzGS4pCzp6CrEaXzq2I43vbNxnhhDTrKDqpASVs+ Eh4fD1elCuFrbmTLNtr3y3NgMmly1rAUzbQb8SOsEOG8Cz896dT9Awnj0zb50G3dnFRxf6L5d5QTc byokRRbZKfLmKAQVETr/frEk2W6lmtbEiONjMnVs1+TwcYXiz+K1fvXGY0AVkQTqy5OSBeEQl4EFN La66zqBlXwUf4TXSKCI16gjU0cJpIkAjFB3y2FUvLDOJau84utbJAt0ajkDjdYMOAYVjfxQe3VsZ0 gb2tpvC7QrLHsBULkjbQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6EE0-0002ut-NF; Tue, 19 Mar 2019 12:52:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6EDy-0002uY-HK for linux-arm-kernel@lists.infradead.org; Tue, 19 Mar 2019 12:52:11 +0000 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 19EAE20685; Tue, 19 Mar 2019 12:52:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552999929; bh=awloTOTbgcjIA42cQqQSdAGkq1v8MM9GEcyrVgX2T4g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hZfD/Bb1o33qXgfQUZnXvRRJBMqAnWtKi5OPRHNTtCnCi9D7a9MQGkrovzTw/hjqo GxTSUTP4Ajqqc3cDnH2GESbQuVWGo8qc5hO4UhdltO3Ki4WHEvPzNZQ2X6qRhoy9OS uRyePR2s+m4eBA/nDCzRBADIG6Go+UcG4cTDzc28= Date: Tue, 19 Mar 2019 20:51:50 +0800 From: Shawn Guo To: Kohji Okuno Subject: Re: [PATCH] ARM: imx6: cpuidle: omit the unnecessary unmask of GINT Message-ID: <20190319125148.GB28063@dragon> References: <20190306032107.GI26041@dragon> <20190306043042.8926-1-okuno.kohji@jp.panasonic.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190306043042.8926-1-okuno.kohji@jp.panasonic.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190319_055210_595205_EF2709F9 X-CRM114-Status: GOOD ( 14.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peng Fan , Sascha Hauer , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 06, 2019 at 01:30:42PM +0900, Kohji Okuno wrote: > In imx6_set_lpm, we only need to unmask GINT when not WAIT_CLOCKED, > so add a check condition. Can you elaborate the problem we have without this code change? Shawn > > Signed-off-by: Peng Fan > Signed-off-by: Kohji Okuno > --- > arch/arm/mach-imx/pm-imx6.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-imx/pm-imx6.c b/arch/arm/mach-imx/pm-imx6.c > index 87f45b926c78..54add0178b96 100644 > --- a/arch/arm/mach-imx/pm-imx6.c > +++ b/arch/arm/mach-imx/pm-imx6.c > @@ -354,9 +354,11 @@ int imx6_set_lpm(enum mxc_cpu_pwr_mode mode) > * > * Note that IRQ #32 is GIC SPI #0. > */ > - imx_gpc_hwirq_unmask(0); > + if (mode != WAIT_CLOCKED) > + imx_gpc_hwirq_unmask(0); > writel_relaxed(val, ccm_base + CLPCR); > - imx_gpc_hwirq_mask(0); > + if (mode != WAIT_CLOCKED) > + imx_gpc_hwirq_mask(0); > > return 0; > } > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel