From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BE5CC43381 for ; Tue, 19 Mar 2019 14:32:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3DD8D2133D for ; Tue, 19 Mar 2019 14:32:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pacK87gr"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Qc4Zakma" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3DD8D2133D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cyzpR5ywErJ3XScrPkYaTG3kX+OjdiSBa5y1H8mVP3g=; b=pacK87grhm6jTr S8H1oi4uydzslIa1eDJ0u/vBGAn31lLGOntkUPnUgF6fuUaooIQM8uMIWmi/D7daLLt2lGMI+C8OB I0WAK+IML3+XS4XVRIf5E4ofc18mr1IY1DqTSk+k/UQTO+FjMZXfMiYkDX1rqVwGuxIcO+R/HhQeW tjemytyNR92OEfDlf79mnYOCE7UPfoA3UFxAJuxFP/O10MEND/RleGcL9vrcvZM1ji/734rp60qth 5ZyBSm4iT5K8j0ErjznC1n22dLIG7WbGdnSjXZE8krphMDx2tF2U3Vs2g7TCALew5pcvYT8HSSXS0 ZesTp6oPdNWLxFOf3O2g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6Fmv-00040V-9A; Tue, 19 Mar 2019 14:32:21 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6Fml-0003zi-Ov for linux-arm-kernel@lists.infradead.org; Tue, 19 Mar 2019 14:32:19 +0000 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 334492085A; Tue, 19 Mar 2019 14:31:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553005931; bh=z79PqI2Xm3jJUWYj8ie8fuE2Nwiyrm790VwkqP6oY28=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qc4ZakmafugOe5+ofvx/zIYJUqZvfFEUhb1bgJw5oFt2bdWe9RIyJvMmm9jVPvTMR she+Qx3y8CIZMxqiOkyPXYFR+xd9fRxa0E1jX9+bd4Q7EpmSlpcyqJWKreSArXlh+d uWK1dFjeAhE3m0gFJIUnmP9bzBdcaHgq5YKrVo6Y= Date: Tue, 19 Mar 2019 22:31:42 +0800 From: Shawn Guo To: Daniel Baluta Subject: Re: [PATCH v6 1/4] arm64: dts: imx8mq: Add SDMA nodes Message-ID: <20190319143139.GA24315@dragon> References: <20190308120141.3698-1-daniel.baluta@nxp.com> <20190308120141.3698-2-daniel.baluta@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190308120141.3698-2-daniel.baluta@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190319_073218_234822_7F7FF7CE X-CRM114-Status: GOOD ( 15.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "baruch@tkos.co.il" , "s.hauer@pengutronix.de" , Abel Vesa , Anson Huang , "ccaione@baylibre.com" , "festevam@gmail.com" , "S.j. Wang" , "angus@akkea.ca" , "linux-kernel@vger.kernel.org" , "kuninori.morimoto.gx@renesas.com" , "robh+dt@kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "agx@sigxcpu.org" , "spencercw@gmail.com" , Aisheng Dong , "linux-arm-kernel@lists.infradead.org" , "l.stach@pengutronix.de" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 08, 2019 at 12:02:22PM +0000, Daniel Baluta wrote: > SDMA1 is part of AIPS-3 region and SDMA2 is part > of AIPS-1 region. > > Reviewed-by: Fabio Estevam Reviewed-by tag should go after your SoB, since that's the sequence of how they come. > Signed-off-by: Anson Huang > [initial submit in i.MX internal tree] > Signed-off-by: Daniel Baluta > [adaptation for linux-next] I would see these notes in commit log or even just cover letter. Shawn > --- > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index 9155bd4784eb..9d48450453fb 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -234,6 +234,17 @@ > status = "disabled"; > }; > > + sdma2: sdma@302c0000 { > + compatible = "fsl,imx8mq-sdma","fsl,imx7d-sdma"; > + reg = <0x302c0000 0x10000>; > + interrupts = ; > + clocks = <&clk IMX8MQ_CLK_SDMA2_ROOT>, > + <&clk IMX8MQ_CLK_SDMA2_ROOT>; > + clock-names = "ipg", "ahb"; > + #dma-cells = <3>; > + fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin"; > + }; > + > iomuxc: iomuxc@30330000 { > compatible = "fsl,imx8mq-iomuxc"; > reg = <0x30330000 0x10000>; > @@ -575,6 +586,17 @@ > status = "disabled"; > }; > > + sdma1: sdma@30bd0000 { > + compatible = "fsl, imx8mq-sdma","fsl,imx7d-sdma"; > + reg = <0x30bd0000 0x10000>; > + interrupts = ; > + clocks = <&clk IMX8MQ_CLK_SDMA1_ROOT>, > + <&clk IMX8MQ_CLK_SDMA1_ROOT>; > + clock-names = "ipg", "ahb"; > + #dma-cells = <3>; > + fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin"; > + }; > + > fec1: ethernet@30be0000 { > compatible = "fsl,imx8mq-fec", "fsl,imx6sx-fec"; > reg = <0x30be0000 0x10000>; > -- > 2.17.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel