From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 181BFC43381 for ; Tue, 19 Mar 2019 15:01:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D64022083D for ; Tue, 19 Mar 2019 15:01:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="C3dq8Z+p"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eVz9qXQp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D64022083D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=21Fyzda9ZN9QwWEijJtx0+tGib7mbxaTG5HkKhadFKI=; b=C3dq8Z+pFC5xsF 2YKBnxT4thpWq1C2TVVN5skFkG3zxcANUd1yahEEm+CopjV/zHF4y/MaYbKkfttXzD9rL44gVVLjh X3s7ZJlL24S3v/JwEmv2MhWlWKuVH6EHcRl7Ub/CPrXukFV0ufRBbac5Jcu6ZcD2FxK6yqzNqAMJg Mw+ccCaDADh4uOrPnZkpkLGygaSpjflp5MW84rcfFr06sq5ZOL7hvLK3b4AveTplvC7lEWZMO1qMg d5XD5jfoBhQjkPSnTwiDSz01hMmgZK5/l91YFKvMFgogQnrhmRiP9+CLnItFIqY59wQ4pRLrRBCfx AXXGLPqzH2HMygGhvXWQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6GEq-0006zr-MH; Tue, 19 Mar 2019 15:01:12 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6GDx-0006kf-2z for linux-arm-kernel@lists.infradead.org; Tue, 19 Mar 2019 15:00:18 +0000 Received: by mail-pf1-x441.google.com with SMTP id i19so13898289pfd.0 for ; Tue, 19 Mar 2019 08:00:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=paoQ87OKVKscooAl/OU6fC6h9C8rqR5YgshYsLyPgrg=; b=eVz9qXQpicKxHkURZ7M2onxOrYVidJtiAU8hsVqJ2BWv1ogm74MYPKUymi1H9MXBPf gygPMj2Oj6xAp1/tYuGNyKxwFV+Eum4hhF7hnz6FYQEsWmGXsi0N5D/f2+39JBezq4Sp ipt5SUu9u1BJm8xlpfeVyK3i/7hJG3ri6FEZfxEpP5o9H9uQUFMfczpoH65OqLFVZqzx dv+zWaN1AVJRgYDKSmd33DyVSuVHGsuvTXSwo5u8mBp2oKOaE/OgVjkKL9ANMuqfMIZD x2myBde8aC99QIIpnjAu2r39XIljfaXDNVtfy6tEvnA9kiqq/iUu+wCFMNYCfkBnqxv9 ry4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=paoQ87OKVKscooAl/OU6fC6h9C8rqR5YgshYsLyPgrg=; b=ZdbMRjU55lZG8NvjWm+Zc883zND1jxVwKaW71X/35wK7Hs34bD7b3KzJ4j305YTqHw 7eHo8MnoorEBeVRfJyPsZBMSTVDpoDzNf70HQmrn8L8LrROhI64Ryxq5cF/pPentjwGr /lJjtOEV3BVJbNqwgcyuKk7ePHnSzujHh+34ZzUDIdYagsCz2CDrIY+lDi+vhIegTncY ij3FextBa9v2V6D/mOf0NNpsLwBTPrqBBI0X2liKn2NUOHoPS9AtsJbsFSDOoMI1AWEq nisJxGWFB/BxgQIaEMT6dPdXh/UsCydK5oPOyRs50vdyZtDOk3ImZJbUXENVGRpA5+pS +qAQ== X-Gm-Message-State: APjAAAXwiMy2Wq/V4vjCQbfDc2+JVOtv6bVxwfWW+Kw7hLL+KZFgfeYu S0u4FBH09P+BQC64uzP5OS0= X-Google-Smtp-Source: APXvYqyMyZMW6YsT/NPn/Aws2+yTQhCAZxgIxEKGtsk0LOdataEYfQg7wPflodvet5i5wg0vGEV8Kg== X-Received: by 2002:aa7:9088:: with SMTP id i8mr929915pfa.118.1553007616148; Tue, 19 Mar 2019 08:00:16 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id j14sm20989126pfe.12.2019.03.19.08.00.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Mar 2019 08:00:15 -0700 (PDT) Date: Tue, 19 Mar 2019 08:00:14 -0700 From: Guenter Roeck To: Robin Murphy Subject: Re: [PATCH] dt-bindings: hwmon (pwm-fan) Remove dead "cooling-*-state" properties Message-ID: <20190319150014.GA29158@roeck-us.net> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190319_080017_392139_AF5470AA X-CRM114-Status: GOOD ( 16.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, jdelvare@suse.com, heiko@sntech.de, linux-pm@vger.kernel.org, s.hauer@pengutronix.de, krzk@kernel.org, jonathanh@nvidia.com, thierry.reding@gmail.com, kgene@kernel.org, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 19, 2019 at 02:54:04PM +0000, Robin Murphy wrote: > The old "cooling-{min,max}-state" properties for thermal bindings were > ratified to "cooling-{min,max}-level" by commit eb168b70dea5 ("of: > thermal: Fix inconsitency between cooling-*-state and cooling-*-level"), > which were later removed entirely by commit e04907dbc259 ("dt-bindings: > thermal: Remove "cooling-{min|max}-level" properties"). > > The pwm-fan binding, however, was apparently in-flight in parallel with > that ratification, and so managed to introduce an example of the old > properties which escaped the scope of the later cleanup and has thus > continued to be dutifully copied for new boards despite being useless. > Clean up these remaining undocumented anachronisms to minimise any > further confusion. > > Signed-off-by: Robin Murphy For hwmon: Acked-by: Guenter Roeck > --- > > Presented as one big hwmon patch for simplicity, but the DT changes > can quite easily be broken out by platform if maintainers prefer. > > Robin. > > Documentation/devicetree/bindings/hwmon/pwm-fan.txt | 2 -- > arch/arm/boot/dts/exynos4412-odroidu3.dts | 2 -- > arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 -- > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 -- > arch/arm/boot/dts/imx6qdl-emcon.dtsi | 2 -- > arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts | 2 -- > arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi | 2 -- > arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 2 -- > 8 files changed, 16 deletions(-) > > diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt > index 49ca5d83ed13..716e84f3bbb2 100644 > --- a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt > +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt > @@ -12,8 +12,6 @@ Optional properties: > Example: > fan0: pwm-fan { > compatible = "pwm-fan"; > - cooling-min-state = <0>; > - cooling-max-state = <3>; > #cooling-cells = <2>; > pwms = <&pwm 0 10000 0>; > cooling-levels = <0 102 170 230>; > diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts > index 2bdf899df436..6d400b01d9c9 100644 > --- a/arch/arm/boot/dts/exynos4412-odroidu3.dts > +++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts > @@ -34,8 +34,6 @@ > fan0: pwm-fan { > compatible = "pwm-fan"; > pwms = <&pwm 0 10000 0>; > - cooling-min-state = <0>; > - cooling-max-state = <3>; > #cooling-cells = <2>; > cooling-levels = <0 102 170 230>; > }; > diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts > index 434a7591ff63..8f9e08f940ab 100644 > --- a/arch/arm/boot/dts/exynos5410-odroidxu.dts > +++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts > @@ -38,8 +38,6 @@ > fan0: pwm-fan { > compatible = "pwm-fan"; > pwms = <&pwm 0 20972 0>; > - cooling-min-state = <0>; > - cooling-max-state = <3>; > #cooling-cells = <2>; > cooling-levels = <0 130 170 230>; > }; > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > index 5f195ad7e467..93a48f2dda49 100644 > --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > @@ -44,8 +44,6 @@ > fan0: pwm-fan { > compatible = "pwm-fan"; > pwms = <&pwm 0 20972 0>; > - cooling-min-state = <0>; > - cooling-max-state = <3>; > #cooling-cells = <2>; > cooling-levels = <0 130 170 230>; > }; > diff --git a/arch/arm/boot/dts/imx6qdl-emcon.dtsi b/arch/arm/boot/dts/imx6qdl-emcon.dtsi > index 397e205551c4..70d26616d771 100644 > --- a/arch/arm/boot/dts/imx6qdl-emcon.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-emcon.dtsi > @@ -77,8 +77,6 @@ > > pwm_fan: pwm-fan { > compatible = "pwm-fan"; > - cooling-min-state = <0>; > - cooling-max-state = <4>; > #cooling-cells = <2>; > pwms = <&pwm4 0 50000>; > cooling-levels = <0 64 127 191 255>; > diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts > index b62e96945846..73801b48d1d8 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts > +++ b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts > @@ -57,8 +57,6 @@ > pwms = <&pwm4 0 45334>; > > cooling-levels = <0 64 128 255>; > - cooling-min-state = <0>; > - cooling-max-state = <3>; > #cooling-cells = <2>; > }; > > diff --git a/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi b/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi > index 1b35d612b660..cc35c88dafd9 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi > @@ -56,8 +56,6 @@ > fan: fan@18 { > compatible = "ti,amc6821"; > reg = <0x18>; > - cooling-min-state = <0>; > - cooling-max-state = <9>; > #cooling-cells = <2>; > }; > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi > index 0130b9f98c9d..490be7a6a851 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi > @@ -369,8 +369,6 @@ > fan: fan@18 { > compatible = "ti,amc6821"; > reg = <0x18>; > - cooling-min-state = <0>; > - cooling-max-state = <9>; > #cooling-cells = <2>; > }; > > -- > 2.20.1.dirty > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel