From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2715CC43381 for ; Tue, 19 Mar 2019 20:40:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E8B1B2075C for ; Tue, 19 Mar 2019 20:40:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="smUclKig" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E8B1B2075C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L2FK8wTgPiaZckHPkMVLHfdyWPv9fFAj8YyiCUwJQQY=; b=smUclKigMupdD8 TqqRNW4clhCP6XcE/nZISQoUrU7D4UkPs3tfkE7+reREbeT4aoQQQVDNkZ/7t3CMUg49LpvQot+eq ScePAXuLzUqos0/fPoNV7YB8o54eZqzOF3gPI7OOMUHEaOd3sIKDzLYuBWVhVcYZ0jIl6fLRIvVxt LDhi+VC4vZaFEutL7aGkqA9PI+ayS9if8x73j6PUccNMgTQMOIYJjkmPh4nMYQHMlFAVeOiwjkcck uFYDLKTukcpQRcCx6Rn/DWbnn029XMlgVq16m3FYaI6zzD8LSb1b/b6h+QqVbR79Q9TjkPM+E9Lhk L0DlcmgwENvWvDKYYe4w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6LWj-0007Ri-Hk; Tue, 19 Mar 2019 20:40:01 +0000 Received: from mail-wr1-f65.google.com ([209.85.221.65]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6LWg-0007Qz-Q9 for linux-arm-kernel@lists.infradead.org; Tue, 19 Mar 2019 20:40:00 +0000 Received: by mail-wr1-f65.google.com with SMTP id j9so340692wrn.6 for ; Tue, 19 Mar 2019 13:39:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3SQjUGvbtviPeRdXVgSnXLx9Qu2xWq+9wjer0xhPxQc=; b=C6BOJGbdV7pY19nK0zymqjc3S/eIe6BoY9KODemLC6m7wRxkJ2aSFgtWhYHoATQ1Xm FYjOpB89paZLYNgkhzP99e+7WY17m2JlCr7QpgEIZiPa2VoEthXSzeVFeBAFBPaATcxN ejzrwjZ+PS1ItHSfnFps85L3svy3WRyhpo/SO++4DxVkPh+DAiELeFtGwF4CdKqvJbbl rev9p/RsNnvhYNV6cHmd4ojNigl6hb6sHB+zjnSZ9+ODp8p84rV532dkCuaskdMkJH3B OK7r4HfT+AdbnzEBMNt9YJv1ktdi0+kJyIcyC2uaXKLBhSOS5pdAqRoHXuh5rIFGpp+9 Z/iQ== X-Gm-Message-State: APjAAAUN4qPXudvC+7YOiThFk3qFHYKDdLbAv5A4ksMcoR54FxN/htFP HG5gXX+9+nCNccB6BkpxGAYRlotI X-Google-Smtp-Source: APXvYqw5wO64i6x9SmvLfDMXwqKjKjcp36TduqPNhf084IleMKCwzt92Ub9Lmu/DHBYUgXtl3EhL+A== X-Received: by 2002:a05:6000:10c9:: with SMTP id b9mr18247393wrx.281.1553027996454; Tue, 19 Mar 2019 13:39:56 -0700 (PDT) Received: from kozik-lap ([194.230.155.153]) by smtp.googlemail.com with ESMTPSA id z1sm12539323wrw.28.2019.03.19.13.39.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Mar 2019 13:39:55 -0700 (PDT) Date: Tue, 19 Mar 2019 21:39:46 +0100 From: Krzysztof Kozlowski To: Wen Yang Subject: Re: [PATCH v2 03/15] ARM: exynos: fix a leaked reference by adding missing of_node_put Message-ID: <20190319203946.GB16150@kozik-lap> References: <1551785646-46173-1-git-send-email-wen.yang99@zte.com.cn> <1551785646-46173-3-git-send-email-wen.yang99@zte.com.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1551785646-46173-3-git-send-email-wen.yang99@zte.com.cn> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190319_133958_844413_79B8277F X-CRM114-Status: GOOD ( 13.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wang.yi59@zte.com.cn, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King , Kukjin Kim , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 05, 2019 at 07:33:54PM +0800, Wen Yang wrote: > The call to of_get_next_child returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > ./arch/arm/mach-exynos/firmware.c:201:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 193, but without a corresponding object release within this function. > ./arch/arm/mach-exynos/firmware.c:204:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 193, but without a corresponding object release within this function. > ./arch/arm/mach-exynos/suspend.c:642:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 634, but without a corresponding object release within this function. > > Signed-off-by: Wen Yang > Reviewed-by: Florian Fainelli > Cc: Russell King > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- Thanks, applied, with adjustments in commit msg and removal of Florian's reviewed-by tag (I cannot find his email with review). Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel