Re: [PATCH] ARM: mm: make use of new memblocks_present() helper

From: Mike Rapoport <rppt@linux.ibm.com>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Kees Cook <keescook@chromium.org>,
	linux-kernel@vger.kernel.org,
	"Steven Rostedt \(VMware\)" <rostedt@goodmis.org>,
	Russell King <linux@armlinux.org.uk>,
	Philip Derrin <philip@cog.systems>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: mm: make use of new memblocks_present() helper
Date: Tue, 19 Mar 2019 23:05:09 +0200	[thread overview]
Message-ID: <20190319210508.GD17966@rapoport-lnx> (raw)
In-Reply-To: <a9b528f1-0c4b-3894-18e1-a4999c18f4a4@deltatee.com>

On Tue, Mar 19, 2019 at 02:50:25PM -0600, Logan Gunthorpe wrote:
> 
> 
> On 2019-03-19 2:42 p.m., Mike Rapoport wrote:
> > On Tue, Mar 19, 2019 at 12:13:57PM -0600, Logan Gunthorpe wrote:
> >> Cleanup the arm_memory_present() function seeing it's very
> >> similar to other arches.
> >>
> >> The new memblocks_present() helper checks for node ids which the
> >> arm version did not. However, this is equivalent seeing
> >> HAVE_MEMBLOCK_NODE_MAP should be false in this arch and therefore
> >> memblock_get_region_node() should return 0.
> >>
> >> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
> >> Cc: Russell King <linux@armlinux.org.uk>
> >> Cc: Kees Cook <keescook@chromium.org>
> >> Cc: Philip Derrin <philip@cog.systems>
> >> Cc: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
> >> Cc: Nicolas Pitre <nicolas.pitre@linaro.org>
> > 
> > Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>
> > 
> > Strangely, I've got a feeling I've already reviewed such patch from a
> > different person...
> 
> You're probably referring to [1] which was for arm64 and was redundant
> as my patch for that architecture was already picked up by Catalin.

I've found the patch [1] I mentioned, and it was for ARM.

> I was the person who originally introduced memblocks_present() and I'm
> still hoping to get the cleanup patches for the arm and sh arches to be
> picked up.

AFAIK, For ARM you'd need to put it into Russel's patch tracking system [2].

> Thanks,
> 
> Logan
> 
> [1]
> https://lore.kernel.org/lkml/20190210093738.30923-1-peng.fan@nxp.com/T/#u
> 

[1] https://lore.kernel.org/lkml/20190211131602.3294-1-peng.fan@nxp.com
[2] https://www.arm.linux.org.uk/developer/patches/

-- 
Sincerely yours,
Mike.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel