From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70824C43381 for ; Wed, 20 Mar 2019 09:00:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E5CA2175B for ; Wed, 20 Mar 2019 09:00:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="j9srKeYI"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Wcyyvuih" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E5CA2175B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tLSmQZI5alEfBRKjUcoz6qfcSPbBjKvSNL4E2Qr0wXs=; b=j9srKeYI101KoI iHdKAacQ9KW3bGZ2NqdyL/bxvOtyXhv7hIgzMM1nN5hmzvcEd+W2FpVsrF+7fwrBa0Ji3DBtRckb/ ImDiaYsnApKkwMVrV9Ym+wvjyqtC92EXixIh6smLxanKv40WTXsNWbbYKr9TdPihxEPBTxcBb3g7Y 8SkiB/2Z8Pv28FLC+X+rYCdhzd9LNi12ptqZouSHnZ0PWcJ0h013ZjcLafssw/+g4DcjjGGYGyPqM gG6eZ91AcTGQVYKz/n5YBa3uE29wXYMZC1zr12Si7XoQQJzrjAj8n7lBFJX5aMxWTKM8TJ3eERhxb mpMwvqTbaypop5QT5htw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6X4s-0000lj-Rt; Wed, 20 Mar 2019 09:00:02 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6X4p-0000l2-5O for linux-arm-kernel@lists.infradead.org; Wed, 20 Mar 2019 09:00:00 +0000 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B313D2175B; Wed, 20 Mar 2019 08:59:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553072398; bh=SHVzWC/FAm81joOxvYvgti1wSjv4iDQofuWnKsHLwfk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Wcyyvuih5p+vIAK6xe8zrCA9zDtOd+ClInB7M6QNrdYpXiEbTlgV+tUEkdLqz16Sa bElwz9S0tvauTx+aiLGqolugVfeBleWjitLNwZmIH9/yRu6i4yzXK3pTbyYf6piZAx a49tdILUZPApab5jUy/F2yZGMzutSsG/PVv44e0k= Date: Wed, 20 Mar 2019 16:59:38 +0800 From: Shawn Guo To: Marco Felsch Subject: Re: [PATCH] ARM: dts: pfla02: increase phy reset duration Message-ID: <20190320085937.GG4980@dragon> References: <20190304104940.18138-1-m.felsch@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190304104940.18138-1-m.felsch@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190320_015959_234283_9E3DF52C X-CRM114-Status: GOOD ( 15.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, Christian Hemp , Stefan Christ , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 04, 2019 at 11:49:40AM +0100, Marco Felsch wrote: > Increase the reset duration to ensure correct phy functionality. The > reset duration is taken from barebox commit 52fdd510de ("ARM: dts: > pfla02: use long enough reset for ethernet phy"): > > Use a longer reset time for ethernet phy Micrel KSZ9031RNX. Otherwise a > small percentage of modules have 'transmission timeouts' errors like > > barebox@Phytec phyFLEX-i.MX6 Quad Carrier-Board:/ ifup eth0 > warning: No MAC address set. Using random address 7e:94:4d:02:f8:f3 > eth0: 1000Mbps full duplex link detected > eth0: transmission timeout > T eth0: transmission timeout > T eth0: transmission timeout > T eth0: transmission timeout > T eth0: transmission timeout > > Cc: Stefan Christ > Cc: Christian Hemp > Signed-off-by: Marco Felsch Do you want to get this in as a fix or just -next material? If it's a fix, please have a Fixes tag. Shawn > --- > arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi > index 673711f445b6..7e53ac6cfa8a 100644 > --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi > @@ -91,6 +91,7 @@ > pinctrl-0 = <&pinctrl_enet>; > phy-handle = <ðphy>; > phy-mode = "rgmii"; > + phy-reset-duration = <10>; /* in msecs */ > phy-reset-gpios = <&gpio3 23 GPIO_ACTIVE_LOW>; > phy-supply = <&vdd_eth_io_reg>; > status = "disabled"; > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel