Re: [PATCH v2 3/5] ARM: dts: tq imx7 common board support

Shawn Guo
2019-04-11T01:24:49Z

On Wed, Apr 03, 2019 at 08:44:25AM +0200, Bruno Thomsen wrote:
> diff --git a/arch/arm/boot/dts/imx7-mba7.dtsi b/arch/arm/boot/dts/imx7-mba7.dtsi
> new file mode 100644
> index 000000000000..a880a698bdaf
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx7-mba7.dtsi
> @@ -0,0 +1,563 @@
> +// SPDX-License-Identifier: GPL-2.0 OR X11
> +/*
> + * Device Tree Include file for TQ Systems MBa7 carrier board.
> + *
> + * Copyright (C) 2016 TQ Systems GmbH
> + * Author: Markus Niebel <Markus.Niebel@tq-group.com>
> + * Copyright (C) 2019 Bruno Thomsen <bruno.thomsen@gmail.com>
> + *
> + * Note: This file does not include nodes for all peripheral devices.
> + * As device driver coverage increases additional nodes can be added.
> + */
> +
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/net/ti-dp83867.h>
> +
> +/ {
> + beeper {
> + compatible = "gpio-beeper";
> + gpios = <&pca9555 0 GPIO_ACTIVE_HIGH>;
> + };
> +
> + chosen {
> + bootargs="ttymxc5,115200";

I do not think this is really needed.

> + linux,stdout-path = &uart6;

The property is deprecated and unnecessary since we have stdout-path
just below.

I dropped these two lines when applying.

Shawn

> + stdout-path = &uart6;
> + };