From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D93C4C43381 for ; Wed, 20 Mar 2019 12:42:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A83BF213F2 for ; Wed, 20 Mar 2019 12:42:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qpHvIV1Y"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0nSEC2/d" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A83BF213F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yOnP33hbCCoTNqHJTgF9Qj/iAC0Z9VAE3IRdfA1X8YQ=; b=qpHvIV1YMtvOT5 ZcCjPOy1WFL/bZAqquQdzYTjCyXxkpMRBRHqO4AfzEnCQgWLsrR6VB3oSggiCUuyTEg6gJrVnIPHV iBRqALslz15dx7KMFBVWKlF7JqtbVdXK1BIlkIuIbKBUNjHkzUsemGLY3aRnf9aY2ecG7ieQro2x7 bsEByV7RWClDkcBd+RpoHfsyJceVn+OokoLKu3w3kdjUjA5aeRZj0PGIxUtmsczy32++NxQAj8HZT rXdZ1uUHrxC4fcONPuzO35jzhnDrduI1/XoM64LMacJ7XSCR/eb6xQncq0CV2K14rMtUYqneDeXhG o7lnkRLiXMq/+f7Sjg8w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6aYR-0005mN-4G; Wed, 20 Mar 2019 12:42:47 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6aYO-0005m2-MS for linux-arm-kernel@lists.infradead.org; Wed, 20 Mar 2019 12:42:45 +0000 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 80856213F2; Wed, 20 Mar 2019 12:42:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553085764; bh=Mb8MDZe/dnoG/NeNKp2b9QF5AQ3pzP/m9Q2AQopQThc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0nSEC2/dK6Oo3uBAmv9YuuRV2vvTrRSgAXQqTRYSEOsOhfAy5gB/spxhiD28GBtYg 6pGaSnbgDhnqr+mlb48SU7bRQ+AhgpRCIxDM9c4L9YbZPuIby7oupkHayGCcnbO5xJ eMaUjY9KvAzdiONinQ3qObVJUfB9MIFhzD0dQeOQ= Date: Wed, 20 Mar 2019 20:42:22 +0800 From: Shawn Guo To: Adam Ford Subject: Re: [PATCH 1/3] ARM: dts: imx6q-logicpd: Shutdown LCD regulator during suspend Message-ID: <20190320124221.GN4980@dragon> References: <20190306140402.17122-1-aford173@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190306140402.17122-1-aford173@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190320_054244_747463_D80DFA37 X-CRM114-Status: GOOD ( 16.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Sascha Hauer , linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 06, 2019 at 08:03:59AM -0600, Adam Ford wrote: > The LCD power sequencer is very finicky. The backlight cannot > be driven until after the sequencer is done. Until now, the > regulators were marked with 'regulator-always-on' to make sure > it came up before the backlight. This patch allows the LCD > regulators to power down and prevent the backlight from being > used again until the sequencer is ready. This reduces > standby power consumption by ~100mW. > > Fixes: 1c207f911fe9 ("ARM: dts: imx: Add support for Logic > PD i.MX6QD EVM") Fixes tag is more for regressions or serious bugs. It looks the patch is more like an improvement though. Shawn > > Signed-off-by: Adam Ford > > diff --git a/arch/arm/boot/dts/imx6q-logicpd.dts b/arch/arm/boot/dts/imx6q-logicpd.dts > index 45eb0b7f75f8..d96ae54be338 100644 > --- a/arch/arm/boot/dts/imx6q-logicpd.dts > +++ b/arch/arm/boot/dts/imx6q-logicpd.dts > @@ -21,6 +21,8 @@ > > panel-lvds0 { > compatible = "okaya,rs800480t-7x0gp"; > + power-supply = <®_lcd_reset>; > + backlight = <&backlight>; > > port { > panel_in_lvds0: endpoint { > @@ -38,7 +40,6 @@ > regulator-max-microvolt = <3300000>; > gpio = <&gpio4 17 GPIO_ACTIVE_HIGH>; > enable-active-high; > - regulator-always-on; > vin-supply = <®_3v3>; > startup-delay-us = <500000>; > }; > @@ -52,7 +53,6 @@ > regulator-max-microvolt = <3300000>; > gpio = <&gpio5 2 GPIO_ACTIVE_HIGH>; > enable-active-high; > - regulator-always-on; > vin-supply = <®_lcd>; > }; > }; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel