From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C24CC43381 for ; Wed, 20 Mar 2019 14:00:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 486862175B for ; Wed, 20 Mar 2019 14:00:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="m2Lm3v0m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 486862175B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mWA7yBZcbujnEzXf13Ojn5gVWAGY4WFM+R40lk2hX/k=; b=m2Lm3v0momtajP 9fqSOCzpkW+jj+kAW+hjrJkSiLhTA8FHG8Eo1jU+U1+sJsRtDY/fAMAwqM+O7CU0egREPJepRWTC+ VZBUOoTD0o+4fJhLme62I01AwX/tdeKYRLj5+0FjLlm1KRQVlwBVcOGMmrwhOZC/khfuLLZOrq02t GtM1c8NeHf/mp28JAtZ2RNdk1lmIP7lca3txXU91V6KxWvQmjg/O++cv9cf4aBDAEJNIj4r1kATmB o15Bebk+7SVThHl5fPXwFS4aiOQtOCTzw2BwJrLOb1hyeRYIkwK9faBS+4FpQYbVFL81CyqHsK7kQ aR6vvlUhdfEQDljFwV4Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6blc-0004EO-9O; Wed, 20 Mar 2019 14:00:28 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6blY-0004Dl-OE for linux-arm-kernel@lists.infradead.org; Wed, 20 Mar 2019 14:00:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B3FE81650; Wed, 20 Mar 2019 07:00:22 -0700 (PDT) Received: from e107981-ln.cambridge.arm.com (e107981-ln.cambridge.arm.com [10.1.197.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5CF893F59C; Wed, 20 Mar 2019 07:00:21 -0700 (PDT) Date: Wed, 20 Mar 2019 14:00:16 +0000 From: Lorenzo Pieralisi To: Robin Murphy Subject: Re: [PATCH 1/2] ACPI/IORT: set online numa node for smmuv3 device Message-ID: <20190320140016.GA8694@e107981-ln.cambridge.arm.com> References: <20190315021940.86905-1-wangkefeng.wang@huawei.com> <20190315021940.86905-2-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190320_070024_805215_1655F568 X-CRM114-Status: GOOD ( 19.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kefeng Wang , rjw@rjwysocki.net, linux-acpi@vger.kernel.org, Hanjun Guo , Sudeep Holla , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 20, 2019 at 11:41:18AM +0000, Robin Murphy wrote: > On 15/03/2019 02:19, Kefeng Wang wrote: > >If there is only node 0 in system, but smmuv3 device is set to offline > >node 1, parsed from proximity domain in SMMUv3 IORT table, it will lead > >to following crash, > > Surely that's just a firmware bug? If node 1 doesn't exist in the system > then AFAICS if we're presented with a device claiming to be on that node we > can only assume the whole thing is bogus. Thus if we're going to work around > it at all, it seems to me like we should reject the entire device rather > than just bodging it to some other node. I suspect that's the same issue this thread addressed: https://lore.kernel.org/linux-pci/CAErSpo6S0qtR42tjGZrFu4aMFFyThx1hkHTSowTt6t3XerpHnA@mail.gmail.com/ Lorenzo > Robin. > > > > >[ 47.492451] Unable to handle kernel paging request at virtual address 0000000000001388 > >[ 47.500361] Mem abort info: > >[ 47.503143] ESR = 0x96000004 > >[ 47.506189] Exception class = DABT (current EL), IL = 32 bits > >[ 47.512099] SET = 0, FnV = 0 > >[ 47.515140] EA = 0, S1PTW = 0 > >[ 47.518272] Data abort info: > >[ 47.521144] ISV = 0, ISS = 0x00000004 > >[ 47.524970] CM = 0, WnR = 0 > >[ 47.527929] [0000000000001388] user address but active_mm is swapper > >[ 47.534285] Internal error: Oops: 96000004 [#1] SMP > >[ 47.539151] Modules linked in: > >[ 47.542194] CPU: 5 PID: 1 Comm: swapper/0 Not tainted 5.0.0 #15 > >[ 47.549490] pstate: 80c00009 (Nzcv daif +PAN +UAO) > >[ 47.554272] pc : __alloc_pages_nodemask+0x13c/0x1068 > >[ 47.559224] lr : __alloc_pages_nodemask+0xdc/0x1068 > >... > >[ 47.646873] Process swapper/0 (pid: 1, stack limit = 0x(____ptrval____)) > >[ 47.653560] Call trace: > >[ 47.655994] __alloc_pages_nodemask+0x13c/0x1068 > >[ 47.660600] new_slab+0xec/0x570 > >[ 47.663816] ___slab_alloc+0x3e0/0x4f8 > >[ 47.667553] __slab_alloc+0x60/0x80 > >[ 47.671029] __kmalloc_node_track_caller+0x10c/0x478 > >[ 47.675984] devm_kmalloc+0x44/0xb0 > >[ 47.679460] pinctrl_bind_pins+0x4c/0x188 > >[ 47.683457] really_probe+0x78/0x2b8 > >[ 47.687019] driver_probe_device+0x64/0x110 > >[ 47.691189] device_driver_attach+0x74/0x98 > >[ 47.695360] __driver_attach+0x9c/0xe8 > >[ 47.699095] bus_for_each_dev+0x84/0xd8 > >[ 47.702919] driver_attach+0x30/0x40 > >[ 47.706481] bus_add_driver+0x170/0x218 > >[ 47.710304] driver_register+0x64/0x118 > >[ 47.714128] __platform_driver_register+0x54/0x60 > >[ 47.718820] arm_smmu_driver_init+0x24/0x2c > >[ 47.722991] do_one_initcall+0xbc/0x328 > >[ 47.726816] kernel_init_freeable+0x304/0x3ac > >[ 47.731162] kernel_init+0x18/0x110 > >[ 47.734638] ret_from_fork+0x10/0x1c > >[ 47.738202] Code: f90013b5 b9410fa1 1a9f0694 b50014c2 (b9400804) > >[ 47.744307] ---[ end trace dfeaed4c373a32da ]-- > > > >Using acpi_map_pxm_to_online_node() to get online node to fix it. > > > >Signed-off-by: Kefeng Wang > >--- > > drivers/acpi/arm64/iort.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > >diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > >index e48894e002ba..a2ce836ec103 100644 > >--- a/drivers/acpi/arm64/iort.c > >+++ b/drivers/acpi/arm64/iort.c > >@@ -1239,10 +1239,10 @@ static void __init arm_smmu_v3_set_proximity(struct device *dev, > > smmu = (struct acpi_iort_smmu_v3 *)node->node_data; > > if (smmu->flags & ACPI_IORT_SMMU_V3_PXM_VALID) { > >- set_dev_node(dev, acpi_map_pxm_to_node(smmu->pxm)); > >- pr_info("SMMU-v3[%llx] Mapped to Proximity domain %d\n", > >- smmu->base_address, > >- smmu->pxm); > >+ int node = acpi_map_pxm_to_online_node(smmu->pxm); > >+ set_dev_node(dev, node); > >+ pr_info("SMMU-v3[%llx] -> PXM %d -> Node %d\n", > >+ smmu->base_address, smmu->pxm, node); > > } > > } > > #else > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel