From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B48ACC43381 for ; Wed, 20 Mar 2019 14:52:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84BE4206BA for ; Wed, 20 Mar 2019 14:52:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="efAYxEU7"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Qt0Wa6cB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84BE4206BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2KyyuTRA2PBNqZwUEhAFdiL1xMgZnwcb1Kn/5us2DA4=; b=efAYxEU79ADrgJ /MI1f/qADZN7xZP5DYGPeGuHk1O46mX+BkbfDn/OeDNzlPs7Kq4vIu4n3FE/XtPaPjm38NSG/6Hj6 YbIsKG5f7U/OaUJ3f3yEatMxDWM2ULlncWlv48TvBCFAIwXCpPyyRg/7tP1otgBxv5NIE+gqs/c7K bOzpjuMPsB4J99MXGDpGXsrt8bNw7bgMuusvxMCq2VQS/emjU2weIfYFxd3W45UDBq97ZmONYMgPJ PuNVobi4Gg8cG8AYGSLW6t/PN+DXmhYmZ5hsb03JIFXUh1F7P3pB29exM/dqL+BatEgCnovIZuV/S N9kNY1UMaAxp7iNvYoHg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6cZx-0008H9-IQ; Wed, 20 Mar 2019 14:52:29 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6cZu-0008FB-1t for linux-arm-kernel@lists.infradead.org; Wed, 20 Mar 2019 14:52:27 +0000 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F3CC12146E; Wed, 20 Mar 2019 14:52:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553093545; bh=5negDKO9TC8BarERi0ka/+MCOwOvfogvBFBGvm9KwQM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qt0Wa6cBNijClawX9Rp6DZq7ZZT3VAGtWmnaRZARItMPpwnVKFf3rr4+7+pU3ivqJ RIkgI4v9PcudIFnJ4HuY7wCmBIYn+Qt01kBweuNiLvu23mwvvOijYiDvFNWhVfkTIo AOIOB+nG4E/rn03p5qndrotJ/eD4drKWP6bqekFo= Date: Wed, 20 Mar 2019 22:51:58 +0800 From: Shawn Guo To: Fabio Estevam Subject: Re: [PATCH V3 2/2] ARM: dts: imx53: Add Menlosystems M53 board Message-ID: <20190320145149.GD8337@dragon> References: <20190304121140.31235-1-marex@denx.de> <20190304121140.31235-2-marex@denx.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190320_075226_117819_4B83385C X-CRM114-Status: GOOD ( 12.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , NXP Linux Team , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 20, 2019 at 09:32:38AM -0300, Fabio Estevam wrote: > Hi Marek, > > On Mon, Mar 4, 2019 at 9:12 AM Marek Vasut wrote: > > > + regulators { > > + compatible = "simple-bus"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + reg_usbh1_vbus: regulator@3 { > > Please move the regulator outside the 'simple-bus': > > reg_usbh1_vbus: regulator-usbh1-vbus { > > > + compatible = "regulator-fixed"; > > + reg = <3>; > > The 'reg' property can also be removed. > > > + regulator-name = "vbus"; > > + regulator-min-microvolt = <5000000>; > > + regulator-max-microvolt = <5000000>; > > + gpio = <&gpio1 2 0>; > > The GPIO flag 0 means active high, but since you are not passing > 'enable-active-high' this should be: > > gpio = <&gpio1 2 GPIO_ACTIVE_LOW>; > > > +&i2c2 { > > + stmpe610@41 { > > Node name should be generic, so: > > touchscreen@41 > > > +&ldb { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_lvds0>; > > + status = "okay"; > > + > > + lvds0: lvds-channel@0 { > > There is an @0 without a corresponding reg property. This triggers a > dtc warning when building with W=1. > > Please fix it. Okay, I dropped the patch and wait for new version. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel