From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8B0BC43381 for ; Thu, 21 Mar 2019 21:14:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D7ED218D4 for ; Thu, 21 Mar 2019 21:14:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jRpfzBKi"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="KxGr1hoO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D7ED218D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iDw4lt3uA9+rcrijJpbO929mo+NL5kqv2Ct5gqlJ1Yk=; b=jRpfzBKiEFB3ph adBXlJ8N0OhuQv9O8NUSjteqCepAWQIJv51/XTBnCiX4fi9xr0f9BLskrk2Z+9V0/MMsV3k+q0IaD gEwUPYaaOhfamO4qbz7GFxZtTIZJ4NNVAc598Puo/pmNCcqWbExxf+ki6BvE8hUvIREX3UI4H7E/+ oZ8FwIffdVLyLcBJduaPQN6TkOrF6RMB094DQ53OhuN5MasDCu2Xz3UCbTdDKlIFRdZ6a+P1pPsGZ 6vfi8T6qkaSe0EsQHLuzpE/X6UXQSxgCut6h48pyQfsMtv/18uZcOciG1wJ9fjWFVSFB+uEMgUdly WD+Ql4uU8MgAAm0xFRhQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h751D-0001DX-N6; Thu, 21 Mar 2019 21:14:31 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h7519-0001C2-Gh for linux-arm-kernel@lists.infradead.org; Thu, 21 Mar 2019 21:14:28 +0000 Received: by mail-pg1-x543.google.com with SMTP id g8so5068849pgf.2 for ; Thu, 21 Mar 2019 14:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JHaZSzBG+K+5icNtlx+uJjLDPuwvOKd7SsMj3Ny9WSU=; b=KxGr1hoOzPXwyS3bHprjr4+lQTVW/U13zB4XwjjBzy/9QUSTBXEP2XmKySuaKP0C2Q B35XeTHSK/BNpoli3+lCqecPOReuuzauLug/UItMXlWe90iaTV3JlV0vK9CTLiQSZjdq Bgqe5tJO4ZdhTLd4NqAvUqqBh5ogcOb2qD6+M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JHaZSzBG+K+5icNtlx+uJjLDPuwvOKd7SsMj3Ny9WSU=; b=tm+/+6sQUtPjS6/4TJwzs5p42vAfmcxR6X94y/cz+H2odQW+HMyuKG1msiF3AfCkZC sUGFSlkl0+mYEkG7ubCfWKNZnp0eKuyomsnnGe23+nluIGkWYtr25w3V/Wk25j5TzO7X vzxHtRjiaTbtVpQlbz44fLOktkueMHy+EnCUw+089HhkdR/Gd/GPYzk6IegSk0hJp6Wx ISTpvYeT8O5f/H45BUjv8eWftHm1PUSqm1xLDHZU5MQsAcjomUn4k40CLJoEhOl/TtWD 3Lege1AFGypMKevjtbJFfMPKHmkh3iZg8/Poile9p5Y2xOkrnwrkYHgnp7GULxWFC44v uLXw== X-Gm-Message-State: APjAAAVL5Z0Xs6nPhs6zDjN8FLlY3Q2GyeahQSrHnOBqm1rMI2g9+fql N1GDn1EFrEEEKXb95QbnCbovVw== X-Google-Smtp-Source: APXvYqxwmQmNpNyqvh11DspxIWHGtMyQJXafR4PBGig9+ThxdbtHD4Ikky74kKihOaU/CjssEP9pTg== X-Received: by 2002:a17:902:1121:: with SMTP id d30mr5810986pla.104.1553202866973; Thu, 21 Mar 2019 14:14:26 -0700 (PDT) Received: from localhost ([2620:15c:202:1:75a:3f6e:21d:9374]) by smtp.gmail.com with ESMTPSA id x23sm6575926pgf.10.2019.03.21.14.14.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Mar 2019 14:14:26 -0700 (PDT) Date: Thu, 21 Mar 2019 14:14:26 -0700 From: Matthias Kaehlcke To: Douglas Anderson Subject: Re: [PATCH 4/4] ARM: dts: rockchip: Remove #address/#size-cells from rk3288-veyron gpio-keys Message-ID: <20190321211426.GT112750@google.com> References: <20190320201402.114309-1-dianders@chromium.org> <20190320201402.114309-4-dianders@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190320201402.114309-4-dianders@chromium.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190321_141427_578831_AD623E7D X-CRM114-Status: GOOD ( 14.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Heiko Stuebner , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , ryandcase@chromium.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 20, 2019 at 01:14:02PM -0700, Douglas Anderson wrote: > They are pointless. As dtc points out: > Warning (avoid_unnecessary_addr_size): > /gpio-keys: > unnecessary #address-cells/#size-cells without "ranges" or child "reg" property > > Let's remove them. > > Signed-off-by: Douglas Anderson > --- > > arch/arm/boot/dts/rk3288-veyron.dtsi | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi > index 0bc2409f6903..192dbc089ade 100644 > --- a/arch/arm/boot/dts/rk3288-veyron.dtsi > +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi > @@ -25,8 +25,6 @@ > > gpio_keys: gpio-keys { > compatible = "gpio-keys"; > - #address-cells = <1>; > - #size-cells = <0>; > > pinctrl-names = "default"; > pinctrl-0 = <&pwr_key_l>; Reviewed-by: Matthias Kaehlcke _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel