From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82DCBC43381 for ; Fri, 22 Mar 2019 01:59:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C226218FE for ; Fri, 22 Mar 2019 01:59:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PIFNgp8a"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="feVNe5FF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C226218FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sOz13eXBroBilxUXXIAAtqfPT61+o9lW6Rq4YfEwisA=; b=PIFNgp8avII7+h p4jODvbFaY5b6UKxx9ULBIQBPr+fKb8K06GfL7fCmRHqyOYjIGeEJVR04LQ5PWDQQK4oHZquY0g4u ErL3WxlFhssc9tyH6TpyVMlGxDO041qpLkxcfVwvwcqbNmsdQBrXmCcYJmhLD+uFkwWpp8rnOBD3F GC2fyifQXMwGpJglJIctlkdn/dJiK9k/V+/IiViiopHfehaZ7JIxb2mczFIwmg/zo/owLid6JRsXN zEhhP7CXTNG+uF4UFFkl8VyZypGfI96fA8IfLBePxuCUaDOupp07fwWX6uAolWPE+n5Anq8wVWyQP CcJE5m+4Z8k1bvVfAM+w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h79TP-0004jo-03; Fri, 22 Mar 2019 01:59:55 +0000 Received: from mail-yw1-xc41.google.com ([2607:f8b0:4864:20::c41]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h79TL-0004ii-U8 for linux-arm-kernel@lists.infradead.org; Fri, 22 Mar 2019 01:59:53 +0000 Received: by mail-yw1-xc41.google.com with SMTP id v127so646027ywe.13 for ; Thu, 21 Mar 2019 18:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Rdnmn7yxssUzb3bXdY19gbuGdUiJlVYAXBvHN95zUAg=; b=feVNe5FF/ey/npbt5mQ8ivp5sqxJqeTu1XUhpyuF+ft3GC0CE/8sMqaGvueZ6natFU k9yII/xjHDiY/gmEJP72SRnmAoeoLkvs+VdJzG59kd9XG+tEl1E9pLTsP46XXg2IrJZx H1GSAo08NFMnjcJOxQfu4IOnD6XInOIn6XhhYJ3gJX5EZlgQpN3EBYrQZOQ8bDVMtc60 Oz0Q+TLfk7X4+xZP2QvYUInkqkqiG50PLsFxSklzsmZoK44B/wNIS4Ty0a0hUU79wyyb pOhIcZa5AVwWbxoSIoA0JRbVKwBU428M75Uj3oTIKSVYNY1+EE/nHJ6ZL7Il+TCpzRD6 Af1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Rdnmn7yxssUzb3bXdY19gbuGdUiJlVYAXBvHN95zUAg=; b=mbZsxtGJ9EE15RI28zwJz/wV4hb7ymKLURV8iV+kj8yGE4x5KsVx4QsFEKXLSmijjU ResE3U6z8Mb8uHjUm0aveLdmhDvA9Xv/k54inutvZzU40d11u7bZouEgJGkKj5Q0ZGeB zGsMHgJj5kMmhQZMdEMAR8dBsf/3+zh4viv+vyT98bxphKXfk2ACcar+BJNE+JZEJoOw 8Aa4hMS3FimxS4y1AfPe6extRIEznpgETzn4IWIUYYF+01n+fjpsnvSB8ikELqntVmtd m+EKlW+aAlu4wyd9IYozQLBRhfUkefklnP3nlF6VWJHVv0qT2Zg1BijeEQKF80PlOXSg ZMjQ== X-Gm-Message-State: APjAAAUnQMBUHfl2MME0AucHkTQ421dqTveNv1zzXFCUl+S9NAzla6yi 6tfzc8xPQ5aUdKxP24jr01MkSA== X-Google-Smtp-Source: APXvYqzgH+Bht1Mq9/fKEqrohpUs1HQAYVe5RcRxGMMdlMmE/zZ+NEgWy3Y/51s8ddW7YCFyIswqfg== X-Received: by 2002:a81:8354:: with SMTP id t81mr6231095ywf.488.1553219990045; Thu, 21 Mar 2019 18:59:50 -0700 (PDT) Received: from leoy-ThinkPad-X240s (li931-65.members.linode.com. [45.56.113.65]) by smtp.gmail.com with ESMTPSA id g82sm3018959ywg.60.2019.03.21.18.59.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Mar 2019 18:59:48 -0700 (PDT) Date: Fri, 22 Mar 2019 09:59:41 +0800 From: Leo Yan To: Solomon Tan Subject: Re: [PATCH v4] perf tools: Add missing case value Message-ID: <20190322015935.GA29608@leoy-ThinkPad-X240s> References: <20190321162702.GA24451@xps15> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190321_185951_974142_24AA8EC1 X-CRM114-Status: GOOD ( 13.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mathieu Poirier , "suzuki.poulose@arm.com" , "peterz@infradead.org" , "linux-kernel@vger.kernel.org" , "acme@kernel.org" , "acme@redhat.com" , "alexander.shishkin@linux.intel.com" , "mingo@redhat.com" , "namhyung@kernel.org" , "robert.walker@arm.com" , "jolsa@redhat.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Solomon, On Fri, Mar 22, 2019 at 12:47:11AM +0000, Solomon Tan wrote: [...] > > On my side this patch is no different from V3, i.e it doesn't pass checkpatch > > and it doesn't apply on my next tree. > > > > Mathieu > > > > > > > > > pub RSA 2048/C88289A6 2018-05-09solomonbstoner@protonmail.ch solomonbstoner@protonmail.ch > > > > > sub RSA 2048/7C5E8D6D 2018-05-09 > > I created a new branch from `next` for the patch mentioned above. Should I > have made the patch directly on the `next` branch instead? > > I ran the following 2 commands to test the files I edited: > ``` > perl scripts/checkpatch.pl -f tools/build/feature/test-libopencsd.c > perl scripts/checkpatch.pl -f tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > ``` > The commands reported that the files "has no obvious style problems and is ready > for submission." For your kind advice please. Thank you. Suggest you to use below flow for sending patch: - git format HEAD~1: generate patch - ./scripts/checkpatch.pl xxxx.patch: check patch format - git send-email xxxx.patch: use git to send patch so avoid any unexpected characters in the mail P.s. Marc has a good presentation [1] for upstreaming patches, you could check page 16 for how to use the git tool. [1] https://elinux.org/images/2/26/Getting-Your-Patches-in-Mainline-Linux-What-Not-To-Do-and-a-Few-Things-You-Could-Try-Instead-Marc-Zyngier-ARM.pdf Thanks, Leo Yan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel