From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26BFAC43381 for ; Fri, 22 Mar 2019 09:52:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2BAF21904 for ; Fri, 22 Mar 2019 09:52:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Zl6eMZMg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QyZX3f23" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2BAF21904 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0+ShQwCglm0DT+cb9OgbTQJ+O4yxPl9k5cKoAbD4FLY=; b=Zl6eMZMggIlsbx+p3/7ApQAr9 vjxxBiMv0eJp48MFtHETj6CvnAdXLEydU13fROt2AOrj+x9z8RcpszKQUu8QVf1WuST+iGNfpfwBO EQ6kzyZHj1gpCpiK/R4uN2dq3gJDkUwimv73DVeRfp5s5m3g5qOYMT3LT25m0IpCVRerwvE1EEm47 uPPI3Ft2/vGP/mRckMHkPGEzozhqcldxWcE1zGopfZ4f6v+rV8qcwuuvykdIEYI5AhyGXDimcaNxE 0JnN3LUDmapKmnlSfjlxepaEnqGPwR3Mndb+2ugwDgtDp0Vk18Ho41RQC2nV1XLfVoePd2qqnKI1A b2/HeAUxA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h7Gr6-0002m2-6n; Fri, 22 Mar 2019 09:52:52 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h7Gr2-0002lY-Km for linux-arm-kernel@lists.infradead.org; Fri, 22 Mar 2019 09:52:49 +0000 Received: by mail-wm1-x342.google.com with SMTP id o25so1472680wmf.5 for ; Fri, 22 Mar 2019 02:52:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jM+DSh5u5FsufyLhboxJkpl3XEPLDDJDM/BD7oFnE5c=; b=QyZX3f23sHNeOM3PJNgelsvlDKscVDj4UVeBb1ueC8Vn5ONTK8azY1waeum8spcSZY mfzXOQbPkZo9BUWyGHVSmGWuXyFwf6cXaJjzmN6UDeDaHNDM0HxgxSOssii0BT3JQukD CKp52ckF9WoyueQcyPwDfRiN7wTaOUej0ud6kztA71d3cdypJkBv4Mo/clgPC1Oj+ezU tDJyvU/gQXlUNaYnYOjVhlsuIKJZHcGs7ttNNtWYGvDbO7E7nGFM40zdUfjghgpflTMA AOkj/DwmaQAinJZvVSDgR/zQKEjjQDKrVZiGo6Lezchj+1Rvy2VzmKsIB8umCo9vWjM9 Jcxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jM+DSh5u5FsufyLhboxJkpl3XEPLDDJDM/BD7oFnE5c=; b=S6GXI+3FO9VS8tWH8rvePurx/nP9DBX43hX8hGyGvqQJsrzxr+9uVGsBEdLeDmZ7PN DClxgWn9xZNN2Ok6Iopm68s2GYj4qXJtom0OE2e/duv2Jf5e8xjVc/SkEqBOCcwL5AzV x/AVV3+U3CBYbJcAnLtWLiJnW9ix8qkRjoEZhNPUaaHEKkvZyk/LYPG9Mb+RSkEHHL2E qkKAdzFRr+K/oj9SXSqym4uVzMItmFjvt1QYfY5at4AnT4P0lxRISgHi/hPqyjFx0oC0 J2YF6QlbN/M8yDj8i8/rl04JVrKnvWDPAc1+kbPfWInsSA+n+DcgSJN7y99jKdU+CMND g8dQ== X-Gm-Message-State: APjAAAVcGlgxaU0YfWZvzUJb+S9wwwRaLDijUdHcIcD27k3RE3Ucfl8T fRVxdrdOcMA+a2mGFVtA+Vs= X-Google-Smtp-Source: APXvYqwj6gloUMPVjtk+ieQq7llC0RaHwRVh1Kup8QRaRy7moTXfVAvlGeQzJ9dFH7Bj73scBzKZ+A== X-Received: by 2002:a1c:f414:: with SMTP id z20mr2288598wma.100.1553248366588; Fri, 22 Mar 2019 02:52:46 -0700 (PDT) Received: from localhost (pD9E51B25.dip0.t-ipconnect.de. [217.229.27.37]) by smtp.gmail.com with ESMTPSA id a14sm8304294wrx.96.2019.03.22.02.52.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Mar 2019 02:52:45 -0700 (PDT) Date: Fri, 22 Mar 2019 10:52:44 +0100 From: Thierry Reding To: Joseph Lo Subject: Re: [PATCH 1/2] arm64: tegra: Add pinmux for PWM-based DFLL support on Shield platform Message-ID: <20190322095244.GF28640@ulmo> References: <20190322071111.32432-1-josephl@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20190322071111.32432-1-josephl@nvidia.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190322_025248_706756_95BEAB55 X-CRM114-Status: GOOD ( 16.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, Stephen Warren , linux-arm-kernel@lists.infradead.org, Jonathan Hunter Content-Type: multipart/mixed; boundary="===============3399374847910234051==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3399374847910234051== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Mjqg7Yu+0hL22rav" Content-Disposition: inline --Mjqg7Yu+0hL22rav Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 22, 2019 at 03:11:10PM +0800, Joseph Lo wrote: > Add pinmux for PWM-based DFLL support on Shield platform. >=20 > Signed-off-by: Joseph Lo > --- > arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) There's been some discussion recently about moving away from programming pinmux in the kernel because it isn't always safe to do that. The idea is that early boot firmware (typically cboot) will already have set up the pinmux, so there's no need to do it again in the kernel. These look like you're going to change this pin to/from tristate at runtime, so perhaps that's the kind of thing that we're okay with? Adding Stephen for visibility. Thierry > diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi b/arch/arm64/= boot/dts/nvidia/tegra210-p2894.dtsi > index 88a4b9333d84..c668f16c8574 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi > +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi > @@ -1318,6 +1318,20 @@ > nvidia,open-drain =3D ; > }; > }; > + > + dvfs_pwm_active_state: dvfs_pwm_active { > + dvfs_pwm_pbb1 { > + nvidia,pins =3D "dvfs_pwm_pbb1"; > + nvidia,tristate =3D ; > + }; > + }; > + > + dvfs_pwm_inactive_state: dvfs_pwm_inactive { > + dvfs_pwm_pbb1 { > + nvidia,pins =3D "dvfs_pwm_pbb1"; > + nvidia,tristate =3D ; > + }; > + }; > }; > =20 > serial@70006000 { > --=20 > 2.21.0 >=20 --Mjqg7Yu+0hL22rav Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlyUsGwACgkQ3SOs138+ s6HThw//VN74F6KqfhFhgnKwAkV2voCwap0OpJk7YNYCmL7iUi3y0D0ugZjLPT1w FRaPS/J/896CD3+fSCXNhxQJHRQk85icEKCWB1/HusJqZITamVu5Zbel1EKC3mjH 6gAxzwrRKwY9NyPouSrfZWjusa/juZ77E0pxdYLqo7mZ2PQshW/+Mnp+wTtoDE4e FkgCi2Ac+6JVrB/MxumMY5H0yBHE0PHZBj63/oFuCjzCgZbanWyyMiREdJKoaxDV j3zbM6qS5T6KTboWCVslr1iMCUdmXR6gfwV4sZ23SgLThS+ybIkshchvSai0WMxF 7nN6GNp8NonAoW4e72paNUc2MZSTuYs9RZUKWSJKAeMjOK9tMsuaEd18P2Imyj9T BS032q0iZOqpXoeVM49LVilN9363cS47EgKmRC1UFZO+IYD6G+vrOyHTQwI7TstA GgHio6naBZUYlPzkUiJL/NfHI+OF8AFYKbhpbwHaSATkGG7aIlbVaxqjqwdrF/bQ JX9w8NRUo9TqIiej+6BDBRLhFl2/rwJbJc4kPRirUn7dXN9Yx/COsX7ioX+0Y2xG sRLYHtvjYEd8YFrP61LYf9LWh0pn5i6S65nIvHfv5gc3jW1xLPfGvfVOVnwzUGz4 Zq1GDlGj/ni2a7U7y7rY5MZ1XsVOmVq77hqN9zOgaN2BKGRQT78= =DDyk -----END PGP SIGNATURE----- --Mjqg7Yu+0hL22rav-- --===============3399374847910234051== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3399374847910234051==--