From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37AE2C43381 for ; Sun, 24 Mar 2019 13:53:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F051E222D9 for ; Sun, 24 Mar 2019 13:53:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="u6cuxpej" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F051E222D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+jhx7jDvI/gyrkbNlew1pUWjtLES81vew85/f3poS1s=; b=u6cuxpej1x4wS4 Tr6OlSwnll6hLjwyXByR/8qzMP/ACKfFCpBbn7RwEXxjfPvNTfEBl3qATSGBiwrdE1YvBmne8xD2K AC/Kw6WVuRj7eSKCI49/Ax/9C41yJw4KrFvMR+NKiUDnmq0gvtq1uJFCUQboa27kOu2dyh1CaaBC+ sDS4GfvHRKsJJ5+GIBv12cx9QlEP8c/9XFRh+4qkjzMekK8nHWe9540VM/o9LwM3PgwfRRfehlSJT 7bL/0SJU75fB6NYrG0TxA3uSekiomwp52Y2PbiFoPDLfE9LhmikJLYo1yP39jq/MWQF3M9YJZ3YAq hz9g2nT2BFbEavdAEzdA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h83YZ-0005DS-BL; Sun, 24 Mar 2019 13:52:59 +0000 Received: from mga06.intel.com ([134.134.136.31]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h83YV-0005BS-8r for linux-arm-kernel@lists.infradead.org; Sun, 24 Mar 2019 13:52:57 +0000 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Mar 2019 06:52:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,256,1549958400"; d="scan'208";a="128204874" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by orsmga008.jf.intel.com with ESMTP; 24 Mar 2019 06:52:48 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1h83YN-00029j-JU; Sun, 24 Mar 2019 15:52:47 +0200 Date: Sun, 24 Mar 2019 15:52:47 +0200 From: Andy Shevchenko To: William Breathitt Gray Subject: Re: [PATCH v10 10/10] thermal: intel: intel_soc_dts_iosf: Utilize for_each_set_clump8 macro Message-ID: <20190324135247.GG9224@smile.fi.intel.com> References: <20190322190243.GA9224@smile.fi.intel.com> <20190324033747.GA7697@icarus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190324033747.GA7697@icarus> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190324_065255_369251_384D5A48 X-CRM114-Status: GOOD ( 15.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, yamada.masahiro@socionext.com, linus.walleij@linaro.org, linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, bgolaszewski@baylibre.com, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Mar 24, 2019 at 12:38:29PM +0900, William Breathitt Gray wrote: > On Fri, Mar 22, 2019 at 09:02:43PM +0200, Andy Shevchenko wrote: > > On Thu, Mar 14, 2019 at 09:32:57PM +0900, William Breathitt Gray wrote: > > > Utilize for_each_set_clump8 macro, and the bitmap_set_value8 and > > > bitmap_get_value8 functions, where appropriate. In addition, remove the > > > now unnecessary temp_mask and temp_shift members of the > > > intel_soc_dts_sensor_entry structure. > > > > One comment below, otherwise > > Tested-by: Andy Shevchenko > > Thanks! > > Thank you for testing out the patch. I'll fix the bug your pointed out > and add the Tested-by line. > > I have a couple minor comments below. > > > u32 store_ptps; > > > - out = (store_ptps & ~(0xFF << (thres_index * 8))); > > > - out |= (temp_out & 0xFF) << (thres_index * 8); > > > + update_ptps = store_ptps; > > > + bitmap_set_value8(&update_ptps, 32, temp_out & 0xFF, thres_index * 8); > > I chose to hardcode a bitmap width of 32 here because that is the width > of the store_ptps variables, but I don't think we necessarily use all 32 > bits here. Would the actual width of store_ptps be the number of > writable trip count bits (writable_trip_count * 8)? I think 32 is okay, but sizeof(store_ptps) would be better. It's easy to read since no need to check what is the actual size inside this variable is used. Same for below. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel