From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 884B7C43381 for ; Sun, 24 Mar 2019 17:12:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57A1F2147C for ; Sun, 24 Mar 2019 17:12:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PONx2k/C"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ryai+PKx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57A1F2147C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3u6iWXki3QXrdGiE6Prj5PrXdHrK+x3bqFttzDPHFR4=; b=PONx2k/C8f/Uxf OZ3Ji6AWLHkR3mDb2rgHC4qONjAZeo0OIrDrpY9agnEKmuHNvJNTkk0SeIiG04av31EWlZnnnwZoU ZFSITknWRhki9j5+rvLrzkcu2Rg98UA89T4kRtNMT9AJcyHA9qcUrn7V9SERSJ5T6Nsi4iOGyvy8x zPe4Gc5KxJ7D++9MJaxrss+LeqUzServPZ1EH0M2Q/9MPHhuXW8H1Z2zntEOx8MVpIejyG19xstWp jSwVKDKOyH9URUhmt/jGYm24hdGcM9ivDXIfJ4Dx3wQ1xTbtDhspCCfO6L4KhZKqi+ureKSnUU39w Po0gqqgAgM2RCk3Bwh3A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h86fz-0001OI-V5; Sun, 24 Mar 2019 17:12:51 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h86fw-0001Nz-JT for linux-arm-kernel@lists.infradead.org; Sun, 24 Mar 2019 17:12:50 +0000 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D8A502087F; Sun, 24 Mar 2019 17:12:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553447568; bh=wxEVUIOVR28lMtF1wwMqBmSMZBwZ6mSS/LE474j3grU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ryai+PKxZG2ImA5XPZ54Y/sgGYy3WimplJ+XhO+MfZJT4yEsTSlSrKODPHU2mlj9k pMTOwJB14V7Sgn/7uJlAoQkaWUcRD0gbdb1YZghRtIzSPR/E1NoTAq9GKuNmo6BR5d V4QffoFAFEjaL9gkU+2/amojP8wOTvdDjm26F28c= Date: Sun, 24 Mar 2019 17:12:42 +0000 From: Jonathan Cameron To: Fabrice Gasnier Subject: Re: [PATCH v2 8/8] iio: adc: stm32-dfsdm: claim direct mode for raw read and settings Message-ID: <20190324171242.67d7a486@archlinux> In-Reply-To: <1553186849-6261-9-git-send-email-fabrice.gasnier@st.com> References: <1553186849-6261-1-git-send-email-fabrice.gasnier@st.com> <1553186849-6261-9-git-send-email-fabrice.gasnier@st.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190324_101249_065050_60279E49 X-CRM114-Status: GOOD ( 14.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lars@metafoo.de, olivier.moysan@st.com, alexandre.torgue@st.com, linux-iio@vger.kernel.org, pmeerw@pmeerw.net, arnaud.pouliquen@st.com, linux-kernel@vger.kernel.org, mcoquelin.stm32@gmail.com, knaack.h@gmx.de, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 21 Mar 2019 17:47:29 +0100 Fabrice Gasnier wrote: > Claim direct mode to ensure no buffer mode is in use for: > - single conversion > - sample rate setting (must be set when filter isn't enabled). > - oversampling ratio (must be set when filter isn't enabled). > > Signed-off-by: Fabrice Gasnier Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/adc/stm32-dfsdm-adc.c | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c > index 51688eb..ca42946 100644 > --- a/drivers/iio/adc/stm32-dfsdm-adc.c > +++ b/drivers/iio/adc/stm32-dfsdm-adc.c > @@ -1039,16 +1039,23 @@ static int stm32_dfsdm_write_raw(struct iio_dev *indio_dev, > > switch (mask) { > case IIO_CHAN_INFO_OVERSAMPLING_RATIO: > + ret = iio_device_claim_direct_mode(indio_dev); > + if (ret) > + return ret; > ret = stm32_dfsdm_set_osrs(fl, 0, val); > if (!ret) > adc->oversamp = val; > - > + iio_device_release_direct_mode(indio_dev); > return ret; > > case IIO_CHAN_INFO_SAMP_FREQ: > if (!val) > return -EINVAL; > > + ret = iio_device_claim_direct_mode(indio_dev); > + if (ret) > + return ret; > + > switch (ch->src) { > case DFSDM_CHANNEL_SPI_CLOCK_INTERNAL: > spi_freq = adc->dfsdm->spi_master_freq; > @@ -1070,9 +1077,11 @@ static int stm32_dfsdm_write_raw(struct iio_dev *indio_dev, > if (ret < 0) { > dev_err(&indio_dev->dev, > "Not able to find parameter that match!\n"); > + iio_device_release_direct_mode(indio_dev); > return ret; > } > adc->sample_freq = val; > + iio_device_release_direct_mode(indio_dev); > > return 0; > } > @@ -1089,11 +1098,15 @@ static int stm32_dfsdm_read_raw(struct iio_dev *indio_dev, > > switch (mask) { > case IIO_CHAN_INFO_RAW: > + ret = iio_device_claim_direct_mode(indio_dev); > + if (ret) > + return ret; > ret = iio_hw_consumer_enable(adc->hwc); > if (ret < 0) { > dev_err(&indio_dev->dev, > "%s: IIO enable failed (channel %d)\n", > __func__, chan->channel); > + iio_device_release_direct_mode(indio_dev); > return ret; > } > ret = stm32_dfsdm_single_conv(indio_dev, chan, val); > @@ -1102,8 +1115,10 @@ static int stm32_dfsdm_read_raw(struct iio_dev *indio_dev, > dev_err(&indio_dev->dev, > "%s: Conversion failed (channel %d)\n", > __func__, chan->channel); > + iio_device_release_direct_mode(indio_dev); > return ret; > } > + iio_device_release_direct_mode(indio_dev); > return IIO_VAL_INT; > > case IIO_CHAN_INFO_OVERSAMPLING_RATIO: _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel