From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6BCDC43381 for ; Sun, 24 Mar 2019 21:19:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A90F20811 for ; Sun, 24 Mar 2019 21:19:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QBOlJsAb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A90F20811 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F52Utg5CyYR7p/pX4Ild4Hkx0GLZStUE742smcb0lwQ=; b=QBOlJsAbYiKX6s LV7/mceijdhYvQF0DnFQyByPAsXcGvph2TSY1lcanSuf17fMSf3VtEUOVyWpHQly/RiVLBPQLkuMs SWMiBst/ZUOjilYlLWz61glHHJ1qo1uwg0BRCmnmJBv176GnnrxC92zIog2dEnkV1nyFjSPyi3fJI IlKAl48hdC7z2vpQ/RpM+d7rGQiClGRAIMl0cMeLKmKUAopqjZLPEut78/arqxIeGfknRKhgvlyRx aHK94XynYpqfKAL//A3raPxhRhKNSdY/M2Ql4/n472+HsD9nsF00lqgic1H+T5R7xV8d+Ovw+qwM9 PHP6Oy+d9VlsDeZ3OUEg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8AWt-0000mR-Le; Sun, 24 Mar 2019 21:19:43 +0000 Received: from mga11.intel.com ([192.55.52.93]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8AWq-0000lx-NX; Sun, 24 Mar 2019 21:19:42 +0000 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Mar 2019 14:19:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,256,1549958400"; d="scan'208";a="129807518" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by orsmga006.jf.intel.com with ESMTP; 24 Mar 2019 14:19:34 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1h8AWi-0006Gz-Fh; Sun, 24 Mar 2019 23:19:32 +0200 Date: Sun, 24 Mar 2019 23:19:32 +0200 From: Andy Shevchenko To: Sakari Ailus Subject: Re: [PATCH 0/2] Remove support for deprecated %pf and %pF in vsprintf Message-ID: <20190324211932.GK9224@smile.fi.intel.com> References: <20190322132108.25501-1-sakari.ailus@linux.intel.com> <20190322135350.2btpno7vspvewxvk@paasikivi.fi.intel.com> <20190322170550.GX9224@smile.fi.intel.com> <20190324211008.lypghym3gqcp62th@mara.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190324211008.lypghym3gqcp62th@mara.localdomain> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190324_141940_773888_F663C99E X-CRM114-Status: GOOD ( 16.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Petr Mladek , scsi , Linux PM list , linux-pci , linux-um@lists.infradead.org, "linux-nvdimm@lists.01.org" , Linux MMC List , Linux Kernel Mailing List , linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, ACPI Devel Maling List , Geert Uytterhoeven , Linux ARM , netdev , sparclinux , xen-devel@lists.xenproject.org, ceph-devel , Linux MM , linux-btrfs , Lars Ellenberg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Mar 24, 2019 at 11:10:08PM +0200, Sakari Ailus wrote: > On Fri, Mar 22, 2019 at 07:05:50PM +0200, Andy Shevchenko wrote: > > On Fri, Mar 22, 2019 at 03:53:50PM +0200, Sakari Ailus wrote: > > > > > Porting a patch > > > forward should have no issues either as checkpatch.pl has been complaining > > > of the use of %pf and %pF for a while now. > > > > And that's exactly the reason why I think instead of removing warning on > > checkpatch, it makes sense to convert to an error for a while. People are > > tending read documentation on internet and thus might have outdated one. And > > yes, the compiler doesn't tell a thing about it. > > > > P.S. Though, if majority of people will tell that I'm wrong, then it's okay to > > remove. > > I wonder if you wrote this before seeing my other patchset. Yes, I wrote it before seeing another series. > What I think could be done is to warn of plain %pf (without following "w") > in checkpatch.pl, and %pf that is not followed by "w" in the kernel. > Although we didn't have such checks to begin with. The case is still a > little bit different as %pf used to be a valid conversion specifier whereas > %pO likely has never existed. > > So, how about adding such checks in the other set? I can retain %p[fF] check > here, too, if you like. Consistency tells me that the warning->error transformation in checkpatch.pl belongs this series. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel