From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E66CC43381 for ; Sun, 24 Mar 2019 22:09:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 090E320896 for ; Sun, 24 Mar 2019 22:09:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hGqpBGUZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 090E320896 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=the-dreams.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=42pjIMrx9i4lFkoo3yspLmMyzLq57ez5FAAGmhH839Y=; b=hGqpBGUZa6jG3h4FtBSVtFbV8 JJYXXQ2LNjrJUTpsYNY5AoJ2HcaoOsDiL0KdrGFiAgJxPpMLdkUtLspoQil1fbQp6naHvbCSJppkh ppReiBNKlKxjjnBh1yD4NVk0Yn5t/PydRcJs0r+LwFuQqM59zPBD8/07kiSfK8lLosbl1Xm3+LGhU npZUXuomxhy9v5A6iJoFcrx1MeZZLqPMYEb4rGb469N1yXsHpIP6OJq6puprBYm79ldNocp5ffx60 b0QZ6nkK28U0wN69qm21pRP7Fau3WmgfKv8eml+Eet2sT3DCCWxbJJC+yBga59XExSC9EMFppjUz5 WuYivj3tw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8BIs-00009M-F8; Sun, 24 Mar 2019 22:09:18 +0000 Received: from sauhun.de ([88.99.104.3] helo=pokefinder.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8BIp-000090-Gc for linux-arm-kernel@lists.infradead.org; Sun, 24 Mar 2019 22:09:16 +0000 Received: from localhost (p54B33218.dip0.t-ipconnect.de [84.179.50.24]) by pokefinder.org (Postfix) with ESMTPSA id 51B2C2C0114; Sun, 24 Mar 2019 23:09:14 +0100 (CET) Date: Sun, 24 Mar 2019 23:09:13 +0100 From: Wolfram Sang To: Tudor.Ambarus@microchip.com Subject: Re: [PATCH v2 1/2] i2c: enable buses to save their clock frequency in adapter Message-ID: <20190324220913.GB6934@kunai> References: <20181210084111.6938-1-tudor.ambarus@microchip.com> <20181210084111.6938-2-tudor.ambarus@microchip.com> MIME-Version: 1.0 In-Reply-To: <20181210084111.6938-2-tudor.ambarus@microchip.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190324_150915_713366_A2895C7B X-CRM114-Status: UNSURE ( 9.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, Ludovic.Desroches@microchip.com, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============0748313467624848221==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0748313467624848221== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="A6N2fC+uXW/VQSAv" Content-Disposition: inline --A6N2fC+uXW/VQSAv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Tudor, thanks for your patience! Now that the at91 refactoring for the I2C slave support is merged, we can keep going forward with your patches. As I told you personally, I am positive in general about this change. > + u32 bus_freq_hz; Why not unsigned int? I also think we should have accessor functions for this new member. They will be very simple currently because we don't really support changing the bus frequency at runtime. However, I can see that it could be added somewhen on top of this change, and then we need to extend the accessor functions with some locking. For now, I think this can be solved with simple policy: The value has to be set before calling i2c_add_adapter(). Also, we should define that '0' means 'value not set'. So far about my thoughts. Any more comments from the list are welcome! Thanks, Wolfram --A6N2fC+uXW/VQSAv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlyYAAkACgkQFA3kzBSg KbYFdQ/8D0r9Q2iDBaKL+JQ7rhQYIU5+/eyYfJq3PbUdnUhA4IyPZonMtzUvUnib HfkKZdmB/DCE0mUlS5dB2T5NGMObGqfaMEGydzVI9h+h0pCrrQ7LQVj8DOA2lKEV g5WVuo/mT/P8bwYMei5Oo/bUe3pLUcl4/rOhySVl5Ns8+QKsPjNWMi+asmP5AdHY w2FsfuWzxnb7Pp59BVUk8Fv4nIHSu6s+xTxMm832MEPhO0l/gybXl/RbGnm5fyLo 4jr0FtDm5vpH90CcW0TzV5zBgMWxSMHn1VQx8t7lEGDe9noUZvOr8ttGZ1XaSf/4 BzcGRKQsaN+EfjQOQ8hFfTxVYaIgdCv64OlEyAxi4Wk5P/KywMEUtihAPznjfaWz IAGw2GorsaH/izQq+WLHqmJBkUmiKduevUTo4SkCcz/RFH+EHqZDkRXAW7DxOF2W z7y1+YEPLr1D1R5B95mI2xeZ545u2lpW1PImjTJcSwiKNq4maTTNOMOk1hB/nMfJ Mu2WOrRmQosouuryU3Ma/1sNh5kJMAdd3nvKj2szVRAQM8kokXXswbih7q/LvWnv /u9nwFiHUDibsB9mJeew42iHGqRRqV+sP/cQEOtWLqW2gM5k/0kiqbLobYmyX/2N 6o6DWMitZM5FYZjKYor+86fDEzRhrJ0VBBKNWORVeq1omSNS6go= =MkdM -----END PGP SIGNATURE----- --A6N2fC+uXW/VQSAv-- --===============0748313467624848221== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0748313467624848221==--