From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7FDEC43381 for ; Mon, 25 Mar 2019 01:36:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A786420863 for ; Mon, 25 Mar 2019 01:36:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rxs6NG7P"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="P71m8OOk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A786420863 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T9Cza8Ul0k4JPCpttaxL+3QgSEE+3HAR/cgM4E1QRGw=; b=rxs6NG7PAkbnbl iARPvhFetmHvKKfI1L2VIqcgtBtp0Yi9OWzwMZ9jsuE7pqhD4cXz0QBj5oPr+jAHhgEkuybDWoH6R S1gFwFjqBp+x0r650g4qc3AAPz1Qv/l7/nl3lZ4jA5Kh/VkFLmlE9xur2JOSpoZWAeWDHxaV1ICA3 TR7DyuVKz5b40j63SJqBxg52U+wSv4duwsV3xxS0rcW4TcPhb2unLGGjP8YzFhZbUXfESTR03fC6e R2uOwcdMg91c43Oe2wnYQCChwjOCrCWNRlCSnMu1FA1kihisTVLnu0OOEZq5A9SjkEuhhfKwQPRK9 kg48wjfB2ZJunNN37SzA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8EWq-0000lL-6S; Mon, 25 Mar 2019 01:35:56 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8EWn-0000l1-79 for linux-arm-kernel@lists.infradead.org; Mon, 25 Mar 2019 01:35:54 +0000 Received: from pendragon.ideasonboard.com (30.net042126252.t-com.ne.jp [42.126.252.30]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 93B0CE2; Mon, 25 Mar 2019 02:35:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1553477742; bh=uVv2BnxOvPEtDyxqJzQuBCekV7R/hZ+h6ZqFjdp8zf8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P71m8OOkFmaqXPjrgI69CN0Zfy8U4NrN8cmCXI/G2cwplcoEGeQA3UqvF7BOj4/zt spokaCPHUM1Dy3ytodbtlPYGa5sTrtfRxuJ+2peXKysRAOhgQ6t2EhJvjnqDHuHmVR 7LcanhwPz98SL373g8c/BOllmB5rex5ogVHWnPu0= Date: Mon, 25 Mar 2019 03:35:31 +0200 From: Laurent Pinchart To: Jernej Skrabec Subject: Re: [PATCH 1/2] drm/bridge/synopsys: dw-hdmi: Add an option to suppress loading CEC driver Message-ID: <20190325013531.GB4540@pendragon.ideasonboard.com> References: <20190324212144.3652-1-jernej.skrabec@siol.net> <20190324212144.3652-2-jernej.skrabec@siol.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190324212144.3652-2-jernej.skrabec@siol.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190324_183553_423416_583A9CFF X-CRM114-Status: GOOD ( 21.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: maxime.ripard@bootlin.com, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, a.hajda@samsung.com, wens@csie.org, daniel@ffwll.ch, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jernej, Thank you for the patch. On Sun, Mar 24, 2019 at 10:21:42PM +0100, Jernej Skrabec wrote: > DW HDMI controller on some Allwinner SoCs has support for CEC, but due > to additional logic put between CEC controller and pins, it doesn't work > correctly, at least not with a lot of instrusive changes. Fortunately, > it's still possible to bitbang protocol. > > For such cases, add a platform option to suppress loading CEC driver. If > DW HDMI CEC driver would be loaded, it wouldn't work anyway and only > cause a confusion with multiple /dev entries. > > Signed-off-by: Jernej Skrabec > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 +- > include/drm/bridge/dw_hdmi.h | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index a63e5f0dae56..fdda26f8b056 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -2634,7 +2634,7 @@ __dw_hdmi_probe(struct platform_device *pdev, > hdmi->audio = platform_device_register_full(&pdevinfo); > } > > - if (config0 & HDMI_CONFIG0_CEC) { > + if (!plat_data->is_cec_unusable && (config0 & HDMI_CONFIG0_CEC)) { > cec.hdmi = hdmi; > cec.ops = &dw_hdmi_cec_ops; > cec.irq = irq; > diff --git a/include/drm/bridge/dw_hdmi.h b/include/drm/bridge/dw_hdmi.h > index 66e70770cce5..764b8bcfa62c 100644 > --- a/include/drm/bridge/dw_hdmi.h > +++ b/include/drm/bridge/dw_hdmi.h > @@ -144,6 +144,8 @@ struct dw_hdmi_plat_data { > int (*configure_phy)(struct dw_hdmi *hdmi, > const struct dw_hdmi_plat_data *pdata, > unsigned long mpixelclock); > + > + unsigned int is_cec_unusable : 1; Strictly speaking your CEC controller isn't unusable, it's just a bit difficult to use it according to your commit message. Would disable_cec be a more appropriate field name ? And how difficult would it be to support the hardware CEC controller, would that result in changes that could be useful to other vendors too ? > }; > > struct dw_hdmi *dw_hdmi_probe(struct platform_device *pdev, -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel