Re: [PATCH 25/28] ARM: dts: sun8i: h3: Fix the SPDIF binding

Chen-Yu Tsai
2019-03-26T02:54:09Z

On Mon, Mar 25, 2019 at 9:53 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> The SPDIF binding mandates that we have two DMA channels, one for reception
> and one in transmission. However, the device tree only specifies one.
>
> This has gone un-noticed since the driver only has support for transmission
> currently.

The H3 does not have the RX DRQ listed, nor does it have an SPDIF IN pin
to test if it works, even though the OWA section does list RX capability
and registers.

I suggest leaving it out (since there's no way to verify it), and updating
the bindings to cover this case.

On the side, the A83T does not have an SPDIF IN pin either. And it doesn't
have documentation for the SPDIF block. But it does list the RX DRQ.

ChenYu

>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> ---
> arch/arm/boot/dts/sunxi-h3-h5.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> index 3b18fd71efc1..c0cbf386331a 100644
> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> @@ -590,8 +590,8 @@
> clocks = <&ccu CLK_BUS_SPDIF>, <&ccu CLK_SPDIF>;
> resets = <&ccu RST_BUS_SPDIF>;
> clock-names = "apb", "spdif";
> - dmas = <&dma 2>;
> - dma-names = "tx";
> + dmas = <&dma 2>, <&dma 2>;
> + dma-names = "rx", "tx";
> status = "disabled";
> };
>
> --
> 2.20.1