Re: [PATCH 28/28] ARM: dts: sun8i: a83t: Fix the I2S binding

Chen-Yu Tsai
2019-03-26T02:59:01Z

On Mon, Mar 25, 2019 at 9:53 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> The I2S binding mandates that we have two DMA channels, one for reception
> and one in transmission. However, the device tree only specifies one.
>
> This has probably gone un-noticed since no boards are using that
> controller.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> ---
> arch/arm/boot/dts/sun8i-a83t.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
> index 09e7f74ab5f5..d0f342ced754 100644
> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi
> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
> @@ -836,9 +836,9 @@
> interrupts = <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&ccu CLK_BUS_I2S2>, <&ccu CLK_I2S2>;
> clock-names = "apb", "mod";
> - dmas = <&dma 27>;
> + dmas = <&dma 27>, <&dma 27>;
> resets = <&ccu RST_BUS_I2S2>;
> - dma-names = "tx";
> + dma-names = "rx", "tx";

Similar to SPDIF on H3, the RX DRQ is not listed. This controller being
responsible for HDMI audio out, there's no way to verify if the DRQ is
there or not.

ChenYu