Re: [PATCH 09/28] ARM: dts: sunxi: Fix the TCON output clock

Maxime Ripard
2019-03-25T19:49:45Z

[-- Attachment #1.1: Type: text/plain, Size: 1746 bytes --]

On Tue, Mar 26, 2019 at 12:58:25AM +0800, Chen-Yu Tsai wrote:
> On Mon, Mar 25, 2019 at 9:53 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> >
> > Even though we shouldn't really have any external user of the clock
> > provided by the TCON, if clock-output-names is set, then #clock-cells must
> > be there as well.
> >
> > Fix this.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> > ---
> > arch/arm/boot/dts/sun4i-a10.dtsi | 2 ++
> > arch/arm/boot/dts/sun5i.dtsi | 1 +
> > arch/arm/boot/dts/sun6i-a31.dtsi | 2 ++
> > arch/arm/boot/dts/sun7i-a20.dtsi | 2 ++
> > arch/arm/boot/dts/sun8i-a23-a33.dtsi | 1 +
> > arch/arm/boot/dts/sun8i-a83t.dtsi | 1 +
> > arch/arm/boot/dts/sun8i-v3s.dtsi | 1 +
> > arch/arm/boot/dts/sun9i-a80.dtsi | 1 +
> > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 1 +
> > 9 files changed, 12 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
> > index 73c3ac42095f..93bc260a80af 100644
> > --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> > +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> > @@ -343,6 +343,7 @@
> > "tcon-ch1";
> > clock-output-names = "tcon0-pixel-clock";
> > dmas = <&dma SUN4I_DMA_DEDICATED 14>;
> > + #clock-cells = <0>;
>
> Nit: could we group #clock-cells with clock-output-names?
>
> Either way,
>
> Acked-by: Chen-Yu Tsai <wens@csie.org>

I fixed it (and split the A64 change in a separate patch) while
applying, thanks!

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]