From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41DC0C43381 for ; Mon, 25 Mar 2019 13:54:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0EC0420830 for ; Mon, 25 Mar 2019 13:54:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ps0vQAMd"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="aRQhb7nk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0EC0420830 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IyHghhCgnJ8AOE3oL3hvgelQ1MUnkO0LRmWOo1H115c=; b=ps0vQAMdrGQFbO 8/YF0z+iSvmw/6cGjBA5a/yIiMBpGtNdSu5mUCGAkrVOiG4InFJcX0y1IGAU9IiPMwDF0anwipInB aSaQySlgHJK8TfxxbzaNzlebjj5MFJjqAmsploQFdHgS+vEY/k4WBEu7XF4xFwrXeB4Lgz1w4M81v u6qR20DhDvM8vlToMA/lk+8xsEsO/K1u4h5NvKX+viyQ0VnlmDbZ7Y9kdVPxmESUV7rGJT7iU5vWn QvrmdMO08zRRefizrXpEkZlWR/D6LWT4/o4O4SU25vwoiK/BxbM6hfKrhY1slNI/eQB6IcmpGPMR/ tGQVT8LZDyMZoPwVjP2Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8Q3j-0007v8-ES; Mon, 25 Mar 2019 13:54:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8Q2Q-0006Bq-43 for linux-arm-kernel@lists.infradead.org; Mon, 25 Mar 2019 13:53:24 +0000 Received: from localhost (173-25-63-173.client.mchsi.com [173.25.63.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C6FCD20830; Mon, 25 Mar 2019 13:53:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553521994; bh=5QU3yfdxQrj/MGdX1DxJPj2H+XWm57iCrYYHzjDcmGk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aRQhb7nkMv149CIv5fGgnvY2EZQD23FCX2Bfbx7Xj8rJckGQ+KmQ41kg+ImNSqGNr k8uy77uRBeOuu80Au40pYRzNd5gAevksDcxciGwg1+qidmHQ/+PKV7gDQtbKqZ+/TN /tDRQX7GTJgVF1gG/XEC3vVBPhyWXdGZTEQGXBeU= Date: Mon, 25 Mar 2019 08:53:12 -0500 From: Bjorn Helgaas To: Jean-Philippe Brucker Subject: Re: [PATCH 1/2] dt-bindings: Add external-facing PCIe port property Message-ID: <20190325135312.GQ251185@google.com> References: <20190318182124.53859-1-jean-philippe.brucker@arm.com> <20190318182124.53859-2-jean-philippe.brucker@arm.com> <20190320220338.GH251185@google.com> <598b0675-38b2-9e52-d903-016dc548756c@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <598b0675-38b2-9e52-d903-016dc548756c@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190325_065319_048876_113EEF09 X-CRM114-Status: GOOD ( 13.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "devicetree@vger.kernel.org" , Grant Likely , "linux-pci@vger.kernel.org" , Jeremy Linton , "robh+dt@kernel.org" , Robin Murphy , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 25, 2019 at 12:59:48PM +0000, Jean-Philippe Brucker wrote: > On 20/03/2019 22:03, Bjorn Helgaas wrote: > > On Mon, Mar 18, 2019 at 06:21:23PM +0000, Jean-Philippe Brucker wrote: > >> +- external-facing: > >> + When present, the port is external facing. All bridges and endpoints > >> + downstream of this port are external to the machine. > > > > Maybe include a note about why this is important, ie, we care because > > malicious devices may be attached to an external port? I know you > > have that in the commit log but it would be more visible here. > > > > Elsewhere you use "external-facing", here too for consistency? > > Makes sense, I'll add a note. I currently have: > > - external-facing: > When present, the port is external-facing. All bridges and endpoints > downstream of this port are external to the machine. The OS can, for > example, use this information to identify devices that cannot be > trusted with relaxed DMA protection, as users could easily attach > malicious devices to this port. Looks good to me! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel