From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B551CC43381 for ; Mon, 25 Mar 2019 15:26:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 851EB2087E for ; Mon, 25 Mar 2019 15:26:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lj0vfVRb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="RA/zEFdS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 851EB2087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r7THSj/FbNKgDGonIYbmm4/rLRZt6hJ/p8SO07sUp1s=; b=lj0vfVRbPKZQ3h sW+bBM+IGUyMOvz/IdYgoELWg+UDIERyWz4reNADAS4w7TPXmemLnNzONg7ERGHmEZoc7r3T/nQlz oJlqhxthZXwB3IsfXJKAY0dwo57FvQTzz6B/uY0oLL7jP1ZuQFRasLmjx/NbTy2xU9NHzXZyZs87K r7cBPULdN1dsa5pSz7/1aNENp2dw+v+iCWQX3/8MZeGdDQAs7gf66xdYZndT1ucPCX3f/FuJJuFul R10Zyc22SNpBGvlokJNH1WhdZH35tgNVzmOz5QGIDeF/xo76H0LREezhJ5/+l3LyAHkLrkt4jlYlr kQ28bQaLAoX6sjK1zZng==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8RUC-0003Gq-0e; Mon, 25 Mar 2019 15:26:04 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8RU7-0003FJ-7d for linux-arm-kernel@lists.infradead.org; Mon, 25 Mar 2019 15:26:02 +0000 Received: from localhost (unknown [171.61.95.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 08E8F2087E; Mon, 25 Mar 2019 15:25:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553527558; bh=exN7xmui7kI37OvWlbdnOW3Atokiit5D+Hid93/mJfg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RA/zEFdSw6OPeRF+lxQXPKvk7zYiQfBldpFke/OJWd71dqxYiRSVQp0BtuZ/nTZE3 YN5gETOkr5TPP7iwHEX0/C9a25tNfHfTIzOy4yPnVBeHjhlw5hQSG3CqNTTpl7ezcU nwGfJkZDiVUIVG0V0rfUBbILzbFV4Q8cyNebDsgs= Date: Mon, 25 Mar 2019 20:55:52 +0530 From: Vinod Koul To: Pierre-Yves MORDRET Subject: Re: [PATCH v1] Revert "dmaengine: stm32-mdma: Add a check on read_u32_array" Message-ID: <20190325152552.GQ5348@vkoul-mobl> References: <1553525187-13533-1-git-send-email-pierre-yves.mordret@st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1553525187-13533-1-git-send-email-pierre-yves.mordret@st.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190325_082559_309500_9F4171DB X-CRM114-Status: GOOD ( 16.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Torgue , linux-kernel@vger.kernel.org, Maxime Coquelin , dmaengine@vger.kernel.org, Dan Williams , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25-03-19, 15:46, Pierre-Yves MORDRET wrote: Please use the right subsystem name dmaengine, revert is not a subsystem name! > This reverts commit 906b40b246b0acb54c4dc97e815cf734761c9820. This should use the cannonical form for commits commit-sha1: ("title....") > > As stated by bindings "st,ahb-addr-masks" is optional. > The statement inserted by this commit makes this property > mandatory and prevents MDMA to be probed in case property not present. > > Signed-off-by: Pierre-Yves MORDRET > --- > drivers/dma/stm32-mdma.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/dma/stm32-mdma.c b/drivers/dma/stm32-mdma.c > index 4e0eede..ac0301b 100644 > --- a/drivers/dma/stm32-mdma.c > +++ b/drivers/dma/stm32-mdma.c > @@ -1578,11 +1578,9 @@ static int stm32_mdma_probe(struct platform_device *pdev) > > dmadev->nr_channels = nr_channels; > dmadev->nr_requests = nr_requests; > - ret = device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks", > + device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks", > dmadev->ahb_addr_masks, > count); > - if (ret) > - return ret; > dmadev->nr_ahb_addr_masks = count; so if st,ahb-addr-masks is not present what value does count contain? > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > -- > 2.7.4 -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel