From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: chris@zankel.net, linux-xtensa@linux-xtensa.org,
dwmw2@infradead.org, joro@8bytes.org, will.deacon@arm.com,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
jonathanh@nvidia.com, jcmvbkbc@gmail.com, robin.murphy@arm.com,
hch@lst.de, linux-arm-kernel@lists.infradead.org,
m.szyprowski@samsung.com
Subject: Re: [PATCH v2 RFC/RFT] dma-contiguous: Get normal pages for single-page allocations
Date: Mon, 25 Mar 2019 11:50:23 -0700 [thread overview]
Message-ID: <20190325185022.GA24188@Asurada-Nvidia> (raw)
In-Reply-To: <20190325121436.hwmzgqkaggxvnfqx@mbp>
On Mon, Mar 25, 2019 at 12:14:37PM +0000, Catalin Marinas wrote:
> diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c
> index fcdb23e8d2fc..8955ba6f52fc 100644
> --- a/kernel/dma/direct.c
> +++ b/kernel/dma/direct.c
> @@ -111,8 +111,7 @@ struct page *__dma_direct_alloc_pages(struct device *dev, size_t size,
> again:
> /* CMA can be used only in the context which permits sleeping */
> if (gfpflags_allow_blocking(gfp)) {
> - page = dma_alloc_from_contiguous(dev, count, page_order,
> - gfp & __GFP_NOWARN);
> + page = dma_alloc_from_contiguous(dev, count, page_order, gfp);
Oh...yea...It should have this part. I messed up with some
thing else so couldn't get it. Thanks for the reply.
I will go for the previous change by returning NULL in the
dma_alloc_from_contiguous() so the no_warm parameter would
not be touched.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-03-25 18:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 18:32 [PATCH v2 RFC/RFT] dma-contiguous: Get normal pages for single-page allocations Nicolin Chen
2019-03-19 14:43 ` Catalin Marinas
2019-03-21 23:32 ` Nicolin Chen
2019-03-22 10:57 ` Catalin Marinas
2019-03-22 20:09 ` Nicolin Chen
2019-03-25 12:14 ` Catalin Marinas
2019-03-25 18:50 ` Nicolin Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325185022.GA24188@Asurada-Nvidia \
--to=nicoleotsuka@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=chris@zankel.net \
--cc=dwmw2@infradead.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jcmvbkbc@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).