From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CCE8C43381 for ; Mon, 25 Mar 2019 19:49:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6DC2D20848 for ; Mon, 25 Mar 2019 19:49:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XOXf0tdp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="CLCeJyq1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DC2D20848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EJSJvSYHET79Xsap1oUV4GImkdqczi+JPh0vJHmULU0=; b=XOXf0tdp7XVRN7ZX5wEq+59OX gg7UAN7vYPKjBVqryHXwf5K1NaZl3UyKJlkKJXcD+t7NYcGiPamMkNa38WxT3Dn9WJxMq9jZU5vtD csy4lk2Ep2nbDHrEN5RSOE1uN1EQG88NkQUaDcgtKBsALQ69ACDzi/ZnOdctTYwKUhppTFUQ57X1h yyXcbvv+h/nmabcpe6M78b+FpkYNv/vW+qMXc7Ii0y5eZuyspctVytrJVPIlHQk1DgnctXQr0eYSZ xKfg/lvsrSJzsuosxxUU3Q6CFuwDAkhX2shGxamu7l1SWZmCmdxgdJ8iVkJW1PsPQDxecdcIAlERH nRpIG4TbA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8VbD-00060B-U6; Mon, 25 Mar 2019 19:49:35 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8VbC-000602-OI for linux-arm-kernel@bombadil.infradead.org; Mon, 25 Mar 2019 19:49:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=G/sEB/Jqvitz+nlVwUKYDxV9hX0k7eC8z9nujelF1RA=; b=CLCeJyq1Jbk86TQZtevrePcBl 42CLccW1/L1rInzLTrXte7Qb8tuoIxl2DQhBhRCR6WdB1OHf+uiTFSbUL9XlTSpQFQe1Ng8Q7Zwn+ BJx/AbvWzBo0TGJ8SXcms8nh1WkexRfHrhG7Mkus4HURRD4ZgSszzflZHAOFCxKiRAcCYPRPM7KiV eB2hO2T3Ri0u7Y+yQOaZBasSarv0J6+7zGVQJ2korVOEuqQaVs1NkAAiwwGo5nLOtaxlQ/VMKOT8e jIAPYq5yF1CeZIGEYhpIvCeti64QlVEgj4AcY+iUc8Qv/KS0MKDa6cz0yigepO3M1rtJJ7ka7Z5uG 998t4V9Jg==; Received: from relay12.mail.gandi.net ([217.70.178.232]) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8Vb6-0007qz-5L for linux-arm-kernel@lists.infradead.org; Mon, 25 Mar 2019 19:49:30 +0000 Received: from localhost (lfbn-1-10718-76.w90-89.abo.wanadoo.fr [90.89.68.76]) (Authenticated sender: maxime.ripard@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id AF045200008; Mon, 25 Mar 2019 19:48:55 +0000 (UTC) Date: Mon, 25 Mar 2019 20:48:55 +0100 From: Maxime Ripard To: Chen-Yu Tsai Subject: Re: [PATCH 09/28] ARM: dts: sunxi: Fix the TCON output clock Message-ID: <20190325194855.ly4g5nttfvnxo6tu@flea> References: <20190325135300.6440-1-maxime.ripard@bootlin.com> <20190325135300.6440-9-maxime.ripard@bootlin.com> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190325_154928_355963_AA4D381D X-CRM114-Status: GOOD ( 18.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel Content-Type: multipart/mixed; boundary="===============2409992020987194602==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2409992020987194602== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uzc2xawxjov5fole" Content-Disposition: inline --uzc2xawxjov5fole Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 26, 2019 at 12:58:25AM +0800, Chen-Yu Tsai wrote: > On Mon, Mar 25, 2019 at 9:53 PM Maxime Ripard wrote: > > > > Even though we shouldn't really have any external user of the clock > > provided by the TCON, if clock-output-names is set, then #clock-cells must > > be there as well. > > > > Fix this. > > > > Signed-off-by: Maxime Ripard > > --- > > arch/arm/boot/dts/sun4i-a10.dtsi | 2 ++ > > arch/arm/boot/dts/sun5i.dtsi | 1 + > > arch/arm/boot/dts/sun6i-a31.dtsi | 2 ++ > > arch/arm/boot/dts/sun7i-a20.dtsi | 2 ++ > > arch/arm/boot/dts/sun8i-a23-a33.dtsi | 1 + > > arch/arm/boot/dts/sun8i-a83t.dtsi | 1 + > > arch/arm/boot/dts/sun8i-v3s.dtsi | 1 + > > arch/arm/boot/dts/sun9i-a80.dtsi | 1 + > > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 1 + > > 9 files changed, 12 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi > > index 73c3ac42095f..93bc260a80af 100644 > > --- a/arch/arm/boot/dts/sun4i-a10.dtsi > > +++ b/arch/arm/boot/dts/sun4i-a10.dtsi > > @@ -343,6 +343,7 @@ > > "tcon-ch1"; > > clock-output-names = "tcon0-pixel-clock"; > > dmas = <&dma SUN4I_DMA_DEDICATED 14>; > > + #clock-cells = <0>; > > Nit: could we group #clock-cells with clock-output-names? > > Either way, > > Acked-by: Chen-Yu Tsai I fixed it (and split the A64 change in a separate patch) while applying, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --uzc2xawxjov5fole Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXJkwpwAKCRDj7w1vZxhR xVKIAQDsKSisosOw+3XcqbUJ1xQxuv9Ah8Zw5f9ts1brmx/5igD/eI+NW4QuilD4 7XzVtGkskKM/Ij9YHBogPqyjRs+kJAg= =CBXE -----END PGP SIGNATURE----- --uzc2xawxjov5fole-- --===============2409992020987194602== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2409992020987194602==--