From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2504CC43381 for ; Tue, 26 Mar 2019 10:19:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E80C220856 for ; Tue, 26 Mar 2019 10:19:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rtExOsMN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E80C220856 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y0TgtmoKCDFlQNmusNtQY+pJM8vPWXZinccZelAL/Co=; b=rtExOsMNTxWc/S 5LQLInnqgf7RX90gbcmlkMjNasljIHNctKlEw785ED9jxIGCy3y/pwwQGTY1S1sczAVFgDAu0Mz20 gzqZxWZC0LCv2Pdfv7wQMoGAm1EFCQzwW26N//gxglWqNWMprU87O80KpMdh1JONfZX833f8xEk+7 p3CZQzmQBYWX1XwfD32A8/nL2sEchsTLN6fMPTIf2ecXRTwyTvIAPJ7U2mXT3h33JMyKuO1bkZHIu 6xTJEEvI9v4ngctwnD4jl5s9Vohg3/ElSAaZdzYfSi+EPe7PnkExfMcObzxumMrESRTTSKOHt6qHe czPPqXkS3srO3/tR3Slw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8jBI-0007Ds-R4; Tue, 26 Mar 2019 10:19:44 +0000 Received: from mga17.intel.com ([192.55.52.151]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8jBF-0007Cz-AU for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2019 10:19:42 +0000 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2019 03:19:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,271,1549958400"; d="scan'208";a="145311682" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by orsmga002.jf.intel.com with ESMTP; 26 Mar 2019 03:19:35 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1h8jB7-0001ER-Ln; Tue, 26 Mar 2019 12:19:33 +0200 Date: Tue, 26 Mar 2019 12:19:33 +0200 From: Andy Shevchenko To: William Breathitt Gray Subject: Re: [PATCH v12 01/11] bitops: Introduce the for_each_set_clump8 macro Message-ID: <20190326101933.GW9224@smile.fi.intel.com> References: <9afc30a574ce3e6a86b51dd522146a1d2156dedd.1553494625.git.vilhelm.gray@gmail.com> <20190325093854.jzkkwaksxi7zvtrg@wunner.de> <20190326031422.GB3356@icarus> <20190326094345.v7l7xjvfs2scbvbv@wunner.de> <20190326100743.GA10005@icarus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190326100743.GA10005@icarus> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_031941_375957_178B7BB1 X-CRM114-Status: GOOD ( 13.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Arnd Bergmann , linux-gpio@vger.kernel.org, yamada.masahiro@socionext.com, linus.walleij@linaro.org, linux-pm@vger.kernel.org, linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org, bgolaszewski@baylibre.com, Lukas Wunner , geert@linux-m68k.org, akpm@linux-foundation.org, preid@electromag.com.au, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 26, 2019 at 07:08:18PM +0900, William Breathitt Gray wrote: > On Tue, Mar 26, 2019 at 10:43:45AM +0100, Lukas Wunner wrote: > > On Tue, Mar 26, 2019 at 12:14:22PM +0900, William Breathitt Gray wrote: > > Why is it so complicated, does it allow passing in a start value > > that's not a multiple of 8? Do you really need that? I imagine > > a simplification is possible if that assumption can be made (and > > is spelled out in the kerneldoc). > > That's a good point. Originally, I had envisioned the possibility of > calling bitmap_get_value8/bitmap_set_value8 at odd start offsets; this > would open up the possibility of a clump landing as a split between 2 > words, thus requiring this complicated case handling code. However, I'm > not sure how often users would need this case; none of the drivers right > now require clumps at odd offsets. > > Andy, would you have any objection to restricting the start offset > values for bitmap_get_value8/bitmap_set_value8 to multiples of 8? That > would prevent the split word case, and thus allow the implementation for > those functions to be a lot simpler. No, I have no objection. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel