From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3D80C43381 for ; Tue, 26 Mar 2019 15:36:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A2DF20811 for ; Tue, 26 Mar 2019 15:36:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Em2icKMi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A2DF20811 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rYyTHd9Kf0Xa0c1mnP2VDaeH8lqkAVX6302gnCDISMY=; b=Em2icKMi1i0Cj/ TLB82hs206lI8qec54CtCABXLJzjOuzi5s3MW2wbwiC7h77dVkLjrYDGzL3LdWmmsdEBFIMt4em3V jXxUmXJOq+ToLnkGNCL7uJPkgv2JTGZpTj7bQyCGxy+MQdpELDT8ca9uauCjrc0JU8Dt3z9cvbZIF MZjVL/Df29QwEsuUdpCjqRUTAssnA+iFmfut7Y1HTKQMpqyvSUMlZozFalanicnkgeNYnpwSO+xI+ 2xwhpNK0pI6VMjhJWtTd++tgXIcEbTMYgbWsGxeWwdCnskPziWB8t2qElp1dLtXwNXbHLRefjkSa9 P1KganHdcvIVJfRRqI4Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8o7W-0001cK-Od; Tue, 26 Mar 2019 15:36:10 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8o7S-0001bd-Um for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2019 15:36:09 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 53E838030; Tue, 26 Mar 2019 15:36:18 +0000 (UTC) Date: Tue, 26 Mar 2019 08:36:01 -0700 From: Tony Lindgren To: linux-omap@vger.kernel.org Subject: Re: [PATCH 7/7] ARM: OMAP2+: Handle reset quirks for dynamically allocated modules Message-ID: <20190326153601.GB49658@atomide.com> References: <20190325183819.15400-1-tony@atomide.com> <20190325183819.15400-8-tony@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190325183819.15400-8-tony@atomide.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_083607_029794_34FD769E X-CRM114-Status: UNSURE ( 8.73 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tero Kristo , Paul Walmsley , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Tony Lindgren [190325 18:38]: > For dynamically allocated struct omap_hwmod data, we need to populate > the device IP specific reset quirks. ... > +static const struct omap_hwmod_reset omap24xx_reset_quirks[] = { > + { .match = "msdi", .len = 3, .reset = omap_msdi_reset, }, > +}; This patch needs the following fix for omap_msdi_reset() if 24xx is not selected. Regards, Tony 8< --------------- diff --git a/arch/arm/mach-omap2/mmc.h b/arch/arm/mach-omap2/mmc.h --- a/arch/arm/mach-omap2/mmc.h +++ b/arch/arm/mach-omap2/mmc.h @@ -7,7 +7,15 @@ #define OMAP4_MMC_REG_OFFSET 0x100 struct omap_hwmod; + +#ifdef CONFIG_SOC_OMAP2420 int omap_msdi_reset(struct omap_hwmod *oh); +#else +static inline int omap_msdi_reset(struct omap_hwmod *oh) +{ + return 0; +} +#endif /* called from board-specific card detection service routine */ extern void omap_mmc_notify_cover_event(struct device *dev, int slot, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel