* Re: [PATCH net 1/2] thunderx: enable page recycling for non-XDP case
[not found] ` <155360908585.12643.12967701630346715912.email-sent-by-dnelson@cyan>
@ 2019-03-26 14:39 ` Jesper Dangaard Brouer
2019-03-26 14:44 ` Dean Nelson
0 siblings, 1 reply; 5+ messages in thread
From: Jesper Dangaard Brouer @ 2019-03-26 14:39 UTC (permalink / raw)
To: Dean Nelson
Cc: Vadim Lomovtsev, Robert Richter, netdev, brouer, Sunil Goutham,
David Miller, linux-arm-kernel
On Tue, 26 Mar 2019 10:04:47 -0400
Dean Nelson <dnelson@redhat.com> wrote:
> Commit 773225388dae15e72790 added code to nicvf_alloc_page() that inadvertently
> disables receive buffer page recycling for the non-XDP case by always NULL'ng
> the page pointer.
>
> This patch corrects two if-conditionals to allow for the recycling of non-XDP
> mode pages by only setting the page pointer to NULL when the page is not ready
> for recycling.
>
> Signed-off-by: Dean Nelson <dnelson@redhat.com>
You need to add a "fixes" line like this:
Fixes: 773225388dae ("net: thunderx: Optimize page recycling for XDP")
And in-general reference a commit in the same way in the description.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net 1/2] thunderx: enable page recycling for non-XDP case
2019-03-26 14:39 ` [PATCH net 1/2] thunderx: enable page recycling for non-XDP case Jesper Dangaard Brouer
@ 2019-03-26 14:44 ` Dean Nelson
2019-03-26 14:59 ` Jesper Dangaard Brouer
0 siblings, 1 reply; 5+ messages in thread
From: Dean Nelson @ 2019-03-26 14:44 UTC (permalink / raw)
To: Jesper Dangaard Brouer
Cc: Sunil Goutham, Robert Richter, netdev, Vadim Lomovtsev,
David Miller, linux-arm-kernel
On 3/26/19 9:39 AM, Jesper Dangaard Brouer wrote:
> On Tue, 26 Mar 2019 10:04:47 -0400
> Dean Nelson <dnelson@redhat.com> wrote:
>
>> Commit 773225388dae15e72790 added code to nicvf_alloc_page() that inadvertently
>> disables receive buffer page recycling for the non-XDP case by always NULL'ng
>> the page pointer.
>>
>> This patch corrects two if-conditionals to allow for the recycling of non-XDP
>> mode pages by only setting the page pointer to NULL when the page is not ready
>> for recycling.
>>
>> Signed-off-by: Dean Nelson <dnelson@redhat.com>
>
> You need to add a "fixes" line like this:
>
> Fixes: 773225388dae ("net: thunderx: Optimize page recycling for XDP")
>
> And in-general reference a commit in the same way in the description.
Sorry, for some reason I thought the 'Fixes' line was optional.
Thank you for setting me straight. Should I repost the patchset?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net 1/2] thunderx: enable page recycling for non-XDP case
2019-03-26 14:44 ` Dean Nelson
@ 2019-03-26 14:59 ` Jesper Dangaard Brouer
2019-03-26 15:39 ` Dean Nelson
0 siblings, 1 reply; 5+ messages in thread
From: Jesper Dangaard Brouer @ 2019-03-26 14:59 UTC (permalink / raw)
To: Dean Nelson
Cc: Sunil Goutham, Robert Richter, netdev, brouer, Vadim Lomovtsev,
David Miller, linux-arm-kernel
On Tue, 26 Mar 2019 09:44:19 -0500
Dean Nelson <dnelson@redhat.com> wrote:
> On 3/26/19 9:39 AM, Jesper Dangaard Brouer wrote:
> > On Tue, 26 Mar 2019 10:04:47 -0400
> > Dean Nelson <dnelson@redhat.com> wrote:
> >
> >> Commit 773225388dae15e72790 added code to nicvf_alloc_page() that inadvertently
> >> disables receive buffer page recycling for the non-XDP case by always NULL'ng
> >> the page pointer.
> >>
> >> This patch corrects two if-conditionals to allow for the recycling of non-XDP
> >> mode pages by only setting the page pointer to NULL when the page is not ready
> >> for recycling.
> >>
> >> Signed-off-by: Dean Nelson <dnelson@redhat.com>
> >
> > You need to add a "fixes" line like this:
> >
> > Fixes: 773225388dae ("net: thunderx: Optimize page recycling for XDP")
> >
> > And in-general reference a commit in the same way in the description.
>
> Sorry, for some reason I thought the 'Fixes' line was optional.
>
> Thank you for setting me straight. Should I repost the patchset?
I would say, yes please. (Given the amount of patches DaveM have to
process, lets make it easy for him).
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net 1/2] thunderx: enable page recycling for non-XDP case
2019-03-26 14:59 ` Jesper Dangaard Brouer
@ 2019-03-26 15:39 ` Dean Nelson
0 siblings, 0 replies; 5+ messages in thread
From: Dean Nelson @ 2019-03-26 15:39 UTC (permalink / raw)
To: Jesper Dangaard Brouer
Cc: Sunil Goutham, Robert Richter, netdev, Vadim Lomovtsev,
David Miller, linux-arm-kernel
On 3/26/19 9:59 AM, Jesper Dangaard Brouer wrote:
> On Tue, 26 Mar 2019 09:44:19 -0500
> Dean Nelson <dnelson@redhat.com> wrote:
>
>> On 3/26/19 9:39 AM, Jesper Dangaard Brouer wrote:
>>> On Tue, 26 Mar 2019 10:04:47 -0400
>>> Dean Nelson <dnelson@redhat.com> wrote:
>>>
>>>> Commit 773225388dae15e72790 added code to nicvf_alloc_page() that inadvertently
>>>> disables receive buffer page recycling for the non-XDP case by always NULL'ng
>>>> the page pointer.
>>>>
>>>> This patch corrects two if-conditionals to allow for the recycling of non-XDP
>>>> mode pages by only setting the page pointer to NULL when the page is not ready
>>>> for recycling.
>>>>
>>>> Signed-off-by: Dean Nelson <dnelson@redhat.com>
>>>
>>> You need to add a "fixes" line like this:
>>>
>>> Fixes: 773225388dae ("net: thunderx: Optimize page recycling for XDP")
>>>
>>> And in-general reference a commit in the same way in the description.
>>
>> Sorry, for some reason I thought the 'Fixes' line was optional.
>>
>> Thank you for setting me straight. Should I repost the patchset?
>
> I would say, yes please. (Given the amount of patches DaveM have to
> process, lets make it easy for him).
Would be glad to, as I definitely agree.
Thanks for responding to my question.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net 0/2] thunderx: fix receive buffer page recycling
[not found] <155360907744.12643.15472521931039184559.email-sent-by-dnelson@cyan>
[not found] ` <155360908585.12643.12967701630346715912.email-sent-by-dnelson@cyan>
@ 2019-03-26 15:39 ` Dean Nelson
1 sibling, 0 replies; 5+ messages in thread
From: Dean Nelson @ 2019-03-26 15:39 UTC (permalink / raw)
To: Robert Richter, Sunil Goutham, David Miller
Cc: netdev, Vadim Lomovtsev, linux-arm-kernel
On 3/26/19 9:04 AM, Dean Nelson wrote:
> In attempting to optimize receive buffer page recycling for XDP, commit
> 773225388dae15e72790 inadvertently introduced two problems for the non-XDP
> case, that will be addressed by this patch series.
>
> Dean Nelson (2):
> thunderx: enable page recycling for non-XDP case
> thunderx: eliminate extra calls to put_page() for pages held for recycling
>
> drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 30 ++++++++++++++----------------
> 1 file changed, 14 insertions(+), 16 deletions(-)
>
I'm self-NACK'ng this patchset in order to add the omitted 'Fixes' lines.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-26 15:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <155360907744.12643.15472521931039184559.email-sent-by-dnelson@cyan>
[not found] ` <155360908585.12643.12967701630346715912.email-sent-by-dnelson@cyan>
2019-03-26 14:39 ` [PATCH net 1/2] thunderx: enable page recycling for non-XDP case Jesper Dangaard Brouer
2019-03-26 14:44 ` Dean Nelson
2019-03-26 14:59 ` Jesper Dangaard Brouer
2019-03-26 15:39 ` Dean Nelson
2019-03-26 15:39 ` [PATCH net 0/2] thunderx: fix receive buffer page recycling Dean Nelson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox