From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEE7FC43381 for ; Tue, 26 Mar 2019 16:19:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9DE612054F for ; Tue, 26 Mar 2019 16:19:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="P1QSwXMK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DE612054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jCkAz5DFa2qdCOwx+oTbnZHbDLSiDA0XCRhVqj89/qE=; b=P1QSwXMKRPUzN9 Q9A8MQPzWqVfjHQUpj2C7KQlZ9+/3hnqI/Kity0gvVA51njL8Mmj9L9etgtgXpIgBvd0MJ5HDrCSV LbgFPiaR34gSh7vM8tjH7g+Gp6Qt+XgrgfMA7RZ6RFa2meaJiJXgDaOmq5BP5Xw6DfxVA7lolRaqb m52RLftF+1Wzbx137IZxUjFoM2FFHANhp27TCaDCu61bU9HCCQDsXUTYWtC73t+8zmIO3eZLdNuAR 8OgnzG/MhFRQwuPOFjR280Z2rYC7pMIBMuSJ4dTPDKR/i0wXttSvlwunrojR5pZZHzeKc+bsQw1cp OFdI6PmTsbD20bfg1Y+A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8omu-0000dL-B4; Tue, 26 Mar 2019 16:18:56 +0000 Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8omr-0000cm-Cb for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2019 16:18:54 +0000 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6326430BC65D; Tue, 26 Mar 2019 16:18:51 +0000 (UTC) Received: from carbon (ovpn-200-46.brq.redhat.com [10.40.200.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8D9456B80E; Tue, 26 Mar 2019 16:18:45 +0000 (UTC) Date: Tue, 26 Mar 2019 17:18:44 +0100 From: Jesper Dangaard Brouer To: Dean Nelson Subject: Re: [PATCH net v2 0/2] thunderx: fix receive buffer page recycling Message-ID: <20190326171844.014b1918@carbon> In-Reply-To: <08849eac-c185-ee0d-3907-85beb392899b@redhat.com> References: <155361559092.14454.4615730926574762068.email-sent-by-dnelson@cyan> <08849eac-c185-ee0d-3907-85beb392899b@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 26 Mar 2019 16:18:51 +0000 (UTC) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_091853_450096_63A0DC1F X-CRM114-Status: GOOD ( 15.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vadim Lomovtsev , Robert Richter , netdev@vger.kernel.org, brouer@redhat.com, Sunil Goutham , David Miller , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 26 Mar 2019 11:09:10 -0500 Dean Nelson wrote: > On 3/26/19 10:53 AM, Dean Nelson wrote: > > In attempting to optimize receive buffer page recycling for XDP, commit > > 773225388dae15e72790 ("net: thunderx: Optimize page recycling for XDP") > > inadvertently introduced two problems for the non-XDP case, that will be > > addressed by this patch series. > > > > Dean Nelson (2): > > thunderx: enable page recycling for non-XDP case > > thunderx: eliminate extra calls to put_page() for pages held for recycling > > > > drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 30 ++++++++++++++---------------- > > 1 file changed, 14 insertions(+), 16 deletions(-) > > > > > I'm really sorry, I completely forgot to add a description > of what the changes were made by v2 (which was just to add > the 'Fixes:' lines to the changelogs). That should be okay, for such a small change. > And I forgot to add you to the CC-list. I'm assuming I > should repost? Right? (And do you want to be added?) > > It's just one of those days. I can live with not getting Cc'ed (but I would prefer it), but some other adjustments. There should not be a newline between "Fixes:" and "Signed-off-by:". And nitpicking, I believe that we usually only show the first 12 chars of the commit id. I have setup git to use: 'git show --pretty=fixes' >From my ~/.gitconfig: --------------------- [core] abbrev = 12 [pretty] fixes = Fixes: %h (\"%s\") -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel