From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C17DC43381 for ; Tue, 26 Mar 2019 21:36:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5144820811 for ; Tue, 26 Mar 2019 21:36:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Q6aa5yiJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="EYdBn5w1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5144820811 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CGvESSDEhLAwJKvCCmnhETEOV7mFOa87eRuo/3sgYBA=; b=Q6aa5yiJluD6ulp7FzoMByJYU WWhhgXuGKdStcGOrdpgHT2UTXOLiAri8vbI4/Yky3lFUk/0L8AYGsDKiKunLF96e6ToknTc6fe2nF dWskaguUObGWXESqDkdTYHQDCTX52PY4Y4uN0k7y0EKoe5QiptLGsFybaEOCUjwPS4qrMlXC4hUnq lMsbLoTcFA8RiELrPSHhN/TVku73kd4hxB1b6TnJDd3hbI4D8KL/8fyNijAdpF26P/OiFqq/g3bYl lg8+2KHIzvgyyXaMUDzMK+UzEnbEzwH+3MMTCaxwpF3cM3KljlvwZVlFq0px25VLHNbl524qm7ab+ den9EAXrw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8tjq-0005rk-PX; Tue, 26 Mar 2019 21:36:06 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8tjp-0005rZ-3Q for linux-arm-kernel@bombadil.infradead.org; Tue, 26 Mar 2019 21:36:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fU6HjoHERw4FwPjE88GM1Bb9W0vfRZ0TVZ8Rc5Bdpp4=; b=EYdBn5w1+xj4N/uRJ3UWk7V57 bYZ07YI55zm1dkk8zK/xrGO6hWA9ymjiMt3uTARQCJMhZc4JYk5lAylv705LSAsnZ07XDrqTH0v8Y YBJMI8vNa6qA15edSGqv6t1XMdkZzWTb0+9yqCklqkQju5QNsIz26W7wCUVthqW96Xw+l22yrzBbQ 4ay/sLOPB/8ttXNGYpnTbPZXBl1ERF+FsoHBpWMmzOQT58U342RYDA4oyOr70xZtwWZRyIQdj+qAa IBz76PtM18Ge4PqpDrR02nHWgOr8sfcGust3/BOIEzGvlMmk4gJHZRnB+XgSEPqNcxHBUHPvRav0v 1L5ecs0oA==; Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by casper.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8tjk-000654-8D for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2019 21:36:02 +0000 X-Originating-IP: 90.89.68.76 Received: from localhost (lfbn-1-10718-76.w90-89.abo.wanadoo.fr [90.89.68.76]) (Authenticated sender: maxime.ripard@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 59B93C0007; Tue, 26 Mar 2019 21:35:27 +0000 (UTC) Date: Tue, 26 Mar 2019 22:35:26 +0100 From: Maxime Ripard To: Rob Herring Subject: Re: [PATCH] dt-bindings: Add schemas for simple-framebuffer Message-ID: <20190326213526.w3t7fga7uzkkliq7@flea> References: <20190325135414.9728-1-maxime.ripard@bootlin.com> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_213600_400100_0348FF9B X-CRM114-Status: GOOD ( 29.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Maxime Jourdan , Bartlomiej Zolnierkiewicz , Hans de Goede , Chen-Yu Tsai , Frank Rowand , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: multipart/mixed; boundary="===============6419337784756979708==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6419337784756979708== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mizbkw563ycmwfqp" Content-Disposition: inline --mizbkw563ycmwfqp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, On Mon, Mar 25, 2019 at 11:27:36AM -0500, Rob Herring wrote: > On Mon, Mar 25, 2019 at 8:54 AM Maxime Ripard wrote: > > > > The simple framebuffer is a binding that allows the bootloader to setup a > > framebuffer, describe it in the Device Tree for the OS to pick it up and > > use it as is. > > > > Replace the current binding by a schema to allow the validation tools to > > check those nodes. > > > > Cc: Bartlomiej Zolnierkiewicz > > Cc: Chen-Yu Tsai > > Cc: Hans de Goede > > Cc: Maxime Jourdan > > Signed-off-by: Maxime Ripard > > > > --- > > > > Rob, > > > > Even though the node itself is properly described, I still end up with some > > validation warnings when the chosen node is validated (basically > > complaining that ranges, and the framebuffer nodes shouldn't be here, since > > we haven't described them in the chosen schemas). > > Having 'ranges' is a bit strange because 'chosen' doesn't have an > address. We can add #address-cells, #size-cells and framebuffer child > node to the base chosen schema. Maybe that's just cargo cult, but both the amlogic and the sunxi DT have ranges in chosen. Shouldn't we need it so that the address is decoded properly? > > I've tried to expand it, but I failed, using that patch: > > http://code.bulix.org/mimu5z-634661?raw > > That should work, but you will still get warnings from the core > schema. Also, I guess you really want to match on the child compatible > which isn't possible with the current tools. I think for now at least, > we don't need to validate that simple-fb is a child of chosen. Ok, so the current patch would be good enough for now I guess. > Maybe we could add a '$parent' property which the tools add like > $nodename. I'd rather wait and see how frequently we need something > like this. ACK. I'll address the rest of your comments, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --mizbkw563ycmwfqp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXJqbHgAKCRDj7w1vZxhR xdtHAP9BjNYudQekRuOXzOK/yYb2NLPkJLbzftWO+0dhJV+wsAEAnSmxLsszA/ag YhS3941NvOU6l1rLXyzFyAInmmG6oAQ= =evz6 -----END PGP SIGNATURE----- --mizbkw563ycmwfqp-- --===============6419337784756979708== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6419337784756979708==--