From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88CB8C43381 for ; Tue, 26 Mar 2019 21:54:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DCD92087C for ; Tue, 26 Mar 2019 21:54:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Em1W9DfW"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PQeFg1Sc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DCD92087C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k7FdzPz+ZNzYWIOexCvbbN/aJS/miPvMR7MNZrXByvs=; b=Em1W9DfWxpC2Qq P8SvJxM7eTPAoDg7Yx4KyEJC3ap7Y0ox+iS9TNC2Cdm7qChAzcXv5bYO383OYMwEuRhW++h161QXb l53wDr1I3HAxIYy+L8fI58Njsf/79Cr3rEOx4b9cMOyfTHz5xHSCBpOtGfh5sVxKRe3RqTlm1wg+o j3oyMoQfIu5x2uG8v3BMDCmI/bHLONAx/W6wgSaAHpyrOWtIi2RpGnZqrX6s25clLNRKFF6tIJKot Vlvw8j88UI9zUl3ru2QjI+xtamqf230H7cJCNO86NbucOg0sJO/OH6s5ot38FikvmFOv5RHNxzGO8 E24BWM6CTX7rM53J+sJQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8u1x-0002OG-St; Tue, 26 Mar 2019 21:54:49 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8u1s-0002Nr-Mf for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2019 21:54:48 +0000 Received: by mail-pl1-x641.google.com with SMTP id b65so2260822plb.6 for ; Tue, 26 Mar 2019 14:54:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=CsfBGUZliIGBa11yqhYNq5TYER9Z49YakjKjtE6rJXQ=; b=PQeFg1ScNblxB6LLHwJ3dXTRL+iF1JHLldSxvU3M/q2yQYRsUoM2rvi4jrYJ/cuVWd QlVtItYaMxPAhaa5MipB7TqX9NPXVJafYqmG3nXt17ZbxCMAlalfktH+k/z/O1+9OOog 6yFMkFLw7gxnRPCb4ItSMbAzcPYh4IgFyaHa8TBBsrnv6YTH5ykFijZovpWWvjs9eUX8 nZBOAC836oO8tcNNptUCLBQhFVfM4GeSK7pNbV2/glzCg2Ln1QryjVyRFmo08mJYqG87 sCUyVH7kZsBa/mNdKY/F8Pr+wISDQCUMuSkmFfGCQMeLRBMwqjI2MthAuCh4hVErx5hE ehcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CsfBGUZliIGBa11yqhYNq5TYER9Z49YakjKjtE6rJXQ=; b=EdCXe71PqkwPGd5uAo2zUBLAmA3O+HVtVppkntwVEY4k8rkRY6/PrXQove3iYeBljB QYo6DeSCrWuyZZbiA6Jqvy4hrF2Y2brpSuEKYO/J3KdTahP6GUZgrvsXDrRVswHg7yoO oQ8bSw0lSmCP1Ue03q/fPAP5otIoOWhnhw2RvHQ8C6dRC4f4O2qu0MDhD7cJLlw/Z5jb G2SjzKKg8bFT7WzjvEb/dAusmnMfeAMxqc2O1Y7kf7mI8kVyNToIoFyOy7H3DIsGqTYM jlLCvEJfYT2DBe65+k+npMyFSs1qFPDS3ww67/0iaKi9EJ992J/AyRO9foBH6ASqjOcG DXYA== X-Gm-Message-State: APjAAAV5rfIHed5rD8xU6V0VQg11QIWJndUkfavS9SbgMP3HkC+UUra3 B2GCDZc2YOGiv6NaTGFXlGyw6Rmt6sQ= X-Google-Smtp-Source: APXvYqw8Vu64PhrCy0WmzRPkkHhZoPmwz5+0r1fWB5aJ+Dn0koiAMqyNVJ+i7SbQ17HIy8jSL7VFng== X-Received: by 2002:a17:902:b40a:: with SMTP id x10mr25278857plr.231.1553637282826; Tue, 26 Mar 2019 14:54:42 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id v20sm9843155pfn.116.2019.03.26.14.54.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Mar 2019 14:54:42 -0700 (PDT) Date: Tue, 26 Mar 2019 15:54:40 -0600 From: Mathieu Poirier To: Suzuki K Poulose Subject: Re: [PATCH 10/25] coresight: tpiu: Clean up device specific data Message-ID: <20190326215440.GB1658@xps15> References: <1553107783-3340-1-git-send-email-suzuki.poulose@arm.com> <1553107783-3340-11-git-send-email-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1553107783-3340-11-git-send-email-suzuki.poulose@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_145445_988800_674A3857 X-CRM114-Status: GOOD ( 18.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, robert.walker@arm.com, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 20, 2019 at 06:49:27PM +0000, Suzuki K Poulose wrote: > Switch to using the coresight device instead of the parent > amba device. > > Cc: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-tpiu.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-tpiu.c b/drivers/hwtracing/coresight/coresight-tpiu.c > index b2f72a1..9763721 100644 > --- a/drivers/hwtracing/coresight/coresight-tpiu.c > +++ b/drivers/hwtracing/coresight/coresight-tpiu.c > @@ -48,15 +48,13 @@ > > /** > * @base: memory mapped base address for this component. > - * @dev: the device entity associated to this component. > + * @dev: the coresight device entity associated to this component. > * @atclk: optional clock for the core parts of the TPIU. > - * @csdev: component vitals needed by the framework. > */ > struct tpiu_drvdata { > void __iomem *base; > struct device *dev; > struct clk *atclk; > - struct coresight_device *csdev; Here again I would get rid of @dev rather than @csdev to be consistent with what was done previously. Mathieu > }; > > static void tpiu_enable_hw(struct tpiu_drvdata *drvdata) > @@ -121,6 +119,7 @@ static int tpiu_probe(struct amba_device *adev, const struct amba_id *id) > struct tpiu_drvdata *drvdata; > struct resource *res = &adev->res; > struct coresight_desc desc = { 0 }; > + struct coresight_device *csdev; > struct device_node *np = adev->dev.of_node; > > if (np) { > @@ -134,7 +133,6 @@ static int tpiu_probe(struct amba_device *adev, const struct amba_id *id) > if (!drvdata) > return -ENOMEM; > > - drvdata->dev = &adev->dev; > drvdata->atclk = devm_clk_get(&adev->dev, "atclk"); /* optional */ > if (!IS_ERR(drvdata->atclk)) { > ret = clk_prepare_enable(drvdata->atclk); > @@ -160,9 +158,11 @@ static int tpiu_probe(struct amba_device *adev, const struct amba_id *id) > desc.ops = &tpiu_cs_ops; > desc.pdata = pdata; > desc.dev = dev; > - drvdata->csdev = coresight_register(&desc); > + csdev = coresight_register(&desc); > + if (!IS_ERR(csdev)) > + drvdata->dev = &csdev->dev; > > - return PTR_ERR_OR_ZERO(drvdata->csdev); > + return PTR_ERR_OR_ZERO(csdev); > } > > #ifdef CONFIG_PM > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel