From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE906C43381 for ; Wed, 27 Mar 2019 04:53:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8E83206DF for ; Wed, 27 Mar 2019 04:53:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HpU2/KNb"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vdxXwJNK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8E83206DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dpBcbXjHeqSZz+aVJ0yAdQIQpjJ6BCS8A+VNRFROY34=; b=HpU2/KNb8FRfLE 4LpJFhRffTlttpkXl+rWA2iwsF0pLgBi/mCl/iAOSw3e5balocmyhZdUfT9I5O7SKMKSJrfYpJWjl POpCCCe2/nTIEF60gJ9oc8Yg5pITKGFqEC1c7QsPEESsOPwO/zmgNMsULfmbUSyIqEZjm+LHsawrK MdzymOhjTzbifP4MJ+3lnTETlsZBDeDIxHurQFawjL7GI3Su0J/ss5SadsKx3BpJezBrfXj93rc1i EYIVsbv7BEajNHAd1IHQEFBu6ATZNzyj4jg9zteHf717No6HrIkiAep3BLYkPJKFIOzTLi31c5ruV odQ65djfEi+TEHpTDCdw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h90Z3-0001gT-Oo; Wed, 27 Mar 2019 04:53:25 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h90Yz-0001g5-LJ for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2019 04:53:23 +0000 Received: by mail-pg1-x543.google.com with SMTP id i2so9331127pgj.11 for ; Tue, 26 Mar 2019 21:53:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to:user-agent; bh=r2oOO5LKX4FmQSTDphQJaH5y8Sw0LgEuefSLa0qQVNE=; b=vdxXwJNKnbcg+7267U3kA9dw02yZ5tUEMlA6meP5SgSxswr4b9gEcjJLDp5oGma1IR FpJ7Arj6KjnqJfXUCuBCFLjT3JfXlj0BlXxIHE3yL0KM4g6OiMd3/dIJSGVqVuzx8muC uSvkkSXeFHqbHQuim7qNyfbtN0qiLJAeiRmRr4YuLAckeEPrKEqwvoQuNy4mwIhJIhTr rg2eSbzwq9Wg63C7EkN/PR0KQlTeO+BAf6gyp6Mh/YxK+M9NR8G+3Weii/TEPyxWbnZP OKw0kjhqMUAPivif43EqHCQDzWbx6sW1N4Tc8/ms28DabV3dYyeJttdXJZ0p43kL7sub ZBuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=r2oOO5LKX4FmQSTDphQJaH5y8Sw0LgEuefSLa0qQVNE=; b=Q2Pg93/6zMIEjqx/I4YutZhI4LtrPWdC0UDKrTBnCWm2PIyZC38ZMbHIfIb2NghNlh BAteG/g/97DQhK0j0vgTayz7/ANE179x0cTRHXG34ggmSLmPZkSjbP8YDq5jTJoU5zVJ Y272z0v+XVXpbSy7ycIge8nIJelDwOoqzJL2RzFqtTJ+uQ+yYMvIRqkc8fzvC1YRBHo6 471gLXXzuPPGBBG0UE3Hvb2PrKUXwS/xcHSF2CRLnRmWShebRRjkBEYJUIvBwKWccuHN T+MHIH2Wdf9ZliL77YWZEuS2glfcIxg4bYGWxIo+9UE33EX1iWZjlwWl3pntqL4LS+fD vr/Q== X-Gm-Message-State: APjAAAUTYvy8N0cnBGihn6UHF6hQ3xyWu+j0TxfCLZ2SsQcwh6eCHbCV CBMTNUEbY3vYvsvcdxtBB8TW3g== X-Google-Smtp-Source: APXvYqzey4TQQsMG8ifRi1Yn3/Rzq9nj4gtn4OmGn1gpIvf2jAdop7rvvnuQgOnE6mZgyLvBLJl0lg== X-Received: by 2002:a65:6203:: with SMTP id d3mr32627674pgv.109.1553662397816; Tue, 26 Mar 2019 21:53:17 -0700 (PDT) Received: from linaro.org ([121.95.100.191]) by smtp.googlemail.com with ESMTPSA id 16sm33407185pfz.106.2019.03.26.21.53.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Mar 2019 21:53:17 -0700 (PDT) Date: Wed, 27 Mar 2019 13:55:16 +0900 From: AKASHI Takahiro To: Catalin Marinas Subject: Re: [BUG] arm64: kdump: capture kernel boot failed when crashkernel above 4G Message-ID: <20190327045514.GQ9937@linaro.org> Mail-Followup-To: AKASHI Takahiro , Catalin Marinas , Chen Zhou , will.deacon@arm.com, robin.murphy@arm.com, steve.capper@arm.com, wangyufen@huawei.com, linux-arm-kernel@lists.infradead.org References: <4ad85f69-6942-2f3b-bdf1-b7693e1e3fcf@huawei.com> <20190325143505.lrgrxwkxxltpggf7@mbp> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190325143505.lrgrxwkxxltpggf7@mbp> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_215321_734871_C0A577EA X-CRM114-Status: GOOD ( 15.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wangyufen@huawei.com, steve.capper@arm.com, Chen Zhou , will.deacon@arm.com, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 25, 2019 at 02:35:05PM +0000, Catalin Marinas wrote: > Hi Chen, > > On Sat, Mar 23, 2019 at 06:34:31PM +0800, Chen Zhou wrote: > > When i tested kdump on arm64 with crashkernel=Y@X, the capture kernel boot failed if the start > > address is above 4G. > > > > My test steps: > > 1. set crashkernel=1024M@0x2040000000 and boot with ACPI > > 2. echo c > /proc/sysrq-trigger > > 3. boot capture kernel, failed > [...] > > [2019/3/23 15:58:47] [ 0.000000] Call trace: > > [2019/3/23 15:58:47] [ 0.000000] dump_backtrace+0x0/0x188 > > [2019/3/23 15:58:47] [ 0.000000] show_stack+0x24/0x30 > > [2019/3/23 15:58:47] [ 0.000000] dump_stack+0xa8/0xcc > > [2019/3/23 15:58:47] [ 0.000000] panic+0x14c/0x31c > > [2019/3/23 15:58:47] [ 0.000000] setup_arch+0x2b0/0x5e0 > > [2019/3/23 15:58:47] [ 0.000000] start_kernel+0x90/0x52c > > [2019/3/23 15:58:47] [ 0.000000] ---[ end Kernel panic - not syncing: request_standard_resources: Failed to allocate 384 bytes ]--- > > > > The root cause is: > > In capture kernel, memblock_alloc_low alloced memory in range [MEMBLOCK_LOW_LIMIT, ARCH_LOW_ADDRESS_LIMIT]. > > CONFIG_ZONE_DMA32 is enabled, and ARCH_LOW_ADDRESS_LIMIT equals to max_zone_dma_phys() - 1. > > The return value of function max_zone_dma_phys is 4G due to the existing "no-map" memory below 4G. > > So memblock_alloc_low alloced memory in range [0, 4G) and failed. > > Does it work better if, in request_standard_resources(), we call > memblock_alloc() instead of the _low variant? I doubt we need the > *_low() call here. I've been aware of this issue in my testing, but I supposed that there must be a reason for *_low() here to prevent the kernel booting from higher address space. -Takahiro Akashi > -- > Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel