From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0528C10F00 for ; Wed, 27 Mar 2019 13:48:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 61AD72146F for ; Wed, 27 Mar 2019 13:48:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kteWiGLm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61AD72146F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=the-dreams.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YgbWJeIJReqAiWuphrYBDaOWos6ay1mr/jKKQuosR0s=; b=kteWiGLmjeG5BK1ZsrYKP8QAM dPSU+UZxSr+MGBKsqP+Sfr3869PEfew+zAWnEMTMcXrQfvJFSiiDbNfvycAaawmxZJuEvj9qAttSA h3LR3Uf5GYlH7+oqj40OH/bhjG3DG0ALNFqioHnM4geck3RtbLzQmlYuPTAkEhWE6NiEP2hHRr0Ql eTgAngjAGnXyEM6S+q/vZThKhV0ZCNRfzq5Az3BNM/PFcLdGzM2drgTzyBAnQblVJQIc0lBZpJT29 DuDZKs1NDMioWJXGVfmIJCCmb94/dcJ2KyBnIne/VSVRPq5zXXFBt5dORbrubaj+kUB9u+tLwnGY8 jPM+O6FIw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h98uK-0000NN-CB; Wed, 27 Mar 2019 13:47:56 +0000 Received: from sauhun.de ([88.99.104.3] helo=pokefinder.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h98uH-0000M5-8b for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2019 13:47:54 +0000 Received: from localhost (p5486CE6B.dip0.t-ipconnect.de [84.134.206.107]) by pokefinder.org (Postfix) with ESMTPSA id DBEDC2E35A2; Wed, 27 Mar 2019 14:47:51 +0100 (CET) Date: Wed, 27 Mar 2019 14:47:51 +0100 From: Wolfram Sang To: Simon Horman Subject: Re: [RFC PATCH v2 3/7] i2c: core: introduce callbacks for atomic transfers Message-ID: <20190327134751.GD5345@kunai> References: <20190302134735.4393-1-wsa+renesas@sang-engineering.com> <20190302134735.4393-4-wsa+renesas@sang-engineering.com> <20190315122320.34yibpfhv2b6ptwl@verge.net.au> MIME-Version: 1.0 In-Reply-To: <20190315122320.34yibpfhv2b6ptwl@verge.net.au> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190327_064753_453516_FEC394CD X-CRM114-Status: UNSURE ( 9.49 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-renesas-soc@vger.kernel.org, linux-omap@vger.kernel.org, Tony Lindgren , Keerthy , linux-kernel@vger.kernel.org, Andy Shevchenko , Russell King , Tero Kristo , Wolfram Sang , linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org, Stefan Lengfeld , Phil Reid , Peter Rosin , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============4319093235551726749==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4319093235551726749== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="eheScQNz3K90DVRs" Content-Disposition: inline --eheScQNz3K90DVRs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Simon, please delete unrelated text. I nearly missed the typo fix later. > > - if (in_atomic() || irqs_disabled()) > > + if (in_atomic() || irqs_disabled()) { > > + WARN(!adap->algo->master_xfer_atomic && !adap->algo->smbus_xfer_atom= ic, > > + "No atomic I2C transfer handler for '%s'\n", dev_name(&adap->de= v)); >=20 > Is WARN_ONCE more appropriate here? Why? It could be multiple adapters or clients causing this? > > + * The return codes from the @master_xfer{_atomic} field should indica= te the >=20 > I think "field" should be "fields" in the new text. Fixed, thanks! Regards, Wolfram --eheScQNz3K90DVRs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIyBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlybfwMACgkQFA3kzBSg Kbbsbg/4y3tgFpT1GwWWe4sp9B/CF2VqdLI5kdtk1IvoIFLvlbaEZQ2xJBiLRVxN yYoNi490tWqKZWKWxzGPNpqbDc4NKozLFCayPFYrHQJRweT8V0TV0ucuUsT09Xd+ QldzPU3QGmBSzTJnnkC8frDW74DqL5ohx7zXMpDhaJvh/ZdWf9Pn3bVfSuZ6mXGG aK7ayUnbeaIZU9sVoyzn19+UvORDgJtS4lyqGaQiQ0kVDHE8B7MsrlOYs9xoSktJ mz65br2NbKwX24EKC+K7Zq2fQtRUOrPIADHs4Z5nonK7K1XE+us2hYg/v4RdG5jv 7qnhZ3ExyBjE3kDLqQX1/iWSI/oXyGmSm31tG6TOSjCMI1f6Su17T8+9cXRc6b6+ T7WMnmQA7pQCUHHhBdZiyxwoJHiYLTPC8sf5HTiWYSo0s5x5FxMxmBHC+E2KnUUW CU/Dq7WNpNzyCbpqxQqG8lbkCQ9swpunpgmCcVpYheOGqKCId5wIwPsLdQQsQrHx 7NlrhBvobACx2AR2D2JCjkv/yVLKznPCsgcN0+oSjbdX9PIvL/l6c9Ms9y7x1YOl 0nDc1fv4M0w5XytcMPLQwHkNawVPXJ8O/uOtpe/2lMCHgUHK1bffuACNzwU0/k9r ztbvtZ5HQ40UBXvOuuexJNLnNivuCGKFhUTYvohyoNcwAD56mQ== =gB5/ -----END PGP SIGNATURE----- --eheScQNz3K90DVRs-- --===============4319093235551726749== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4319093235551726749==--