linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Patrick Venture <venture@google.com>
Cc: arnd@arndb.de, linux-aspeed@lists.ozlabs.org, andrew@aj.id.au,
	linux-kernel@vger.kernel.org, joel@jms.id.au,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 2/2] drivers/misc: Add Aspeed P2A control driver
Date: Thu, 28 Mar 2019 01:45:42 +0900	[thread overview]
Message-ID: <20190327164542.GC11712@kroah.com> (raw)
In-Reply-To: <20190312163101.155910-1-venture@google.com>

On Tue, Mar 12, 2019 at 09:31:01AM -0700, Patrick Venture wrote:
> +	phys_addr_t mem_base;

Is this really a 32bit value?

Your ioctl thinks it is:

> +struct aspeed_p2a_ctrl_mapping {
> +	__u32 addr;

Does this driver not work on a 64bit kernel?

> +	__u32 length;
> +	__u32 flags;
> +};

addr really should be __u32 here so you don't have to mess with 32/64
bit user/kernel issues, right?

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-03-27 18:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12 16:31 [PATCH v7 2/2] drivers/misc: Add Aspeed P2A control driver Patrick Venture
2019-03-27 16:45 ` Greg KH [this message]
2019-03-27 18:44   ` Patrick Venture
2019-03-27 18:54     ` Greg KH
2019-03-27 19:01       ` Patrick Venture
2019-03-27 19:50         ` Patrick Venture
2019-03-28  6:52         ` Greg KH
2019-03-28 14:13           ` Patrick Venture

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190327164542.GC11712@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andrew@aj.id.au \
    --cc=arnd@arndb.de \
    --cc=joel@jms.id.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=venture@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).