From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6216C43381 for ; Wed, 27 Mar 2019 18:28:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEA0F20651 for ; Wed, 27 Mar 2019 18:28:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CQFGzeNs"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="OyBr1le/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEA0F20651 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HYgAsdBUshRF6U2LxjRYydtXs/Fx97biyioNj2iG+UI=; b=CQFGzeNsBNtKYM h8oeZs/EbM1DblhT2UL9kHoaUC3JgCjhEgJShZcHN4tAeRCnYsQRbWM5coDjZaeXx3spoap29/0RL ZUNZ1x/f2D3iWpjYFYNZRtikUChGdEin6nAwOEUmJIUBeyHsM71872m/4hd+fzx2V25Aww1ue65Mn Am6VjZVmxxWrCZoxSikyO51tPfldhXDpAuBJbMJR35WyU/V7mAt6RC4hYa5uBuN9t9Chmx8qrLjjk LPaKIUSvYToKF9sw0hQc+kc6xJPQ7ty4zDY7Ig9ovJLeb2Gu6eUutFk+uLJfc+Ymt5cokWIwOePcy 2Uzb1WzrIZKyQEWlk4RA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9DI3-0007Bm-MU; Wed, 27 Mar 2019 18:28:43 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9DHy-0007Am-B0 for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2019 18:28:41 +0000 Received: from localhost (unknown [88.128.80.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BD34620651; Wed, 27 Mar 2019 18:28:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553711316; bh=jf5FBSIfuopYRz4BJUbyXjwdIVrEyxaUf4nAFx7faUY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OyBr1le/GpjmQFlDE3wHm9TP2Aci6ODydOuK101Zwkq5R5ztdLo161lLL5bO9zlzH EIXgslKl0upwfqosSmofRGI4hqAUbObIZDNqy1WQkvMntPXLQCHx/EYe0EdWpMUmco Q+23BBwEyhLemfeZYHVrtx2NfwRszG5rYfJuPV1A= Date: Thu, 28 Mar 2019 01:45:42 +0900 From: Greg KH To: Patrick Venture Subject: Re: [PATCH v7 2/2] drivers/misc: Add Aspeed P2A control driver Message-ID: <20190327164542.GC11712@kroah.com> References: <20190312163101.155910-1-venture@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190312163101.155910-1-venture@google.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190327_112838_395126_5AC1D972 X-CRM114-Status: UNSURE ( 8.51 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: arnd@arndb.de, linux-aspeed@lists.ozlabs.org, andrew@aj.id.au, linux-kernel@vger.kernel.org, joel@jms.id.au, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 12, 2019 at 09:31:01AM -0700, Patrick Venture wrote: > + phys_addr_t mem_base; Is this really a 32bit value? Your ioctl thinks it is: > +struct aspeed_p2a_ctrl_mapping { > + __u32 addr; Does this driver not work on a 64bit kernel? > + __u32 length; > + __u32 flags; > +}; addr really should be __u32 here so you don't have to mess with 32/64 bit user/kernel issues, right? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel