From: Greg KH <gregkh@linuxfoundation.org>
To: Patrick Venture <venture@google.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-aspeed@lists.ozlabs.org, Andrew Jeffery <andrew@aj.id.au>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Joel Stanley <joel@jms.id.au>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v7 2/2] drivers/misc: Add Aspeed P2A control driver
Date: Wed, 27 Mar 2019 19:54:10 +0100 [thread overview]
Message-ID: <20190327185410.GA14828@kroah.com> (raw)
In-Reply-To: <CAO=notxFvvOmpjMyXvt5PyuWsB92eraN+=8mWk8_aY2w3sK-eQ@mail.gmail.com>
On Wed, Mar 27, 2019 at 11:44:36AM -0700, Patrick Venture wrote:
> On Wed, Mar 27, 2019 at 11:28 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Tue, Mar 12, 2019 at 09:31:01AM -0700, Patrick Venture wrote:
> > > + phys_addr_t mem_base;
> >
> > Is this really a 32bit value?
>
> It's going to be a 32-bit value if this is in the dts for one of the
> correspondingly supported aspeed models.
>
> >
> > Your ioctl thinks it is:
> >
> > > +struct aspeed_p2a_ctrl_mapping {
> > > + __u32 addr;
> >
> > Does this driver not work on a 64bit kernel?
>
> This driver is aimed at only 32-bit hardware (ast2400/2500). I
> modeled the approach after the aspeed-lpc-ctrl driver as it's
> providing similar functionality.
>
> >
> > > + __u32 length;
> > > + __u32 flags;
> > > +};
> >
> > addr really should be __u32 here so you don't have to mess with 32/64
> > bit user/kernel issues, right?
>
> Add is __u32 there. Are you suggesting it shouldn't be?
Ugh, yes, sorry, I meant to say "__u64".
If you all insist that this is all that is ever going to be needed, ok,
but I reserve the right to complain in 4 years when this needs to be
changed :)
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-27 18:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 16:31 [PATCH v7 2/2] drivers/misc: Add Aspeed P2A control driver Patrick Venture
2019-03-27 16:45 ` Greg KH
2019-03-27 18:44 ` Patrick Venture
2019-03-27 18:54 ` Greg KH [this message]
2019-03-27 19:01 ` Patrick Venture
2019-03-27 19:50 ` Patrick Venture
2019-03-28 6:52 ` Greg KH
2019-03-28 14:13 ` Patrick Venture
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327185410.GA14828@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).