From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FB85C4360F for ; Wed, 27 Mar 2019 18:54:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 229FB205C9 for ; Wed, 27 Mar 2019 18:54:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FpGKRsAX"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="p5UleUFW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 229FB205C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+d+SV5JD1Y2gOvVx4fFn7qFQKwdWm5LfqXSX9ZCf0OU=; b=FpGKRsAX0OlE8G ZGToO82KiSTWEa61BiCBuNcnWu/0Loti5RWVb4aWzcuGZdP1Jrr3pFYdLGGa5DgE1PSSlMUNzYLaF UOghL6M/98iG1Ct/W/f2y7mWl3QVE3Usx8pKAHfTVkVCvU+JaPeVjAkmxehQJtv11pIL3qDotXuiN B9wTscJT/fvpyI8Fc5zJieZ8hq+NGfpWaIxJTavfgDG1y3q66nIHZN2Gy4m/2Vrro1oXwQfX9+7PR FjR7gPMam9RNjfmcgSwWR71ATqVC5/DzjXfnlQ2n5sMvoGmzpDpDHunRc2FYdQaOBBkk/35lTokba oIvDmz82Ty/1bdeAqJ0A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9Dgo-000227-8Y; Wed, 27 Mar 2019 18:54:18 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9Dgl-00021K-8y for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2019 18:54:16 +0000 Received: from localhost (unknown [88.128.80.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C906C205C9; Wed, 27 Mar 2019 18:54:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553712854; bh=49j3u6W+B+wmtfk3MiDgPAHpTSsRmaAxd7k+TkSo0dE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p5UleUFWmRJDTiksUP0ReTaUoTlG6a39uTLix+u2fuMmKl6C1/wETGHAEHSZb1CIY fPvRNMD8n7nt3qNdehDNRtcSUMoSnEeMkpsJr++PGYWICyhvEyU4fPAJwpgT84PxZy jr+GudYdtg/b71oW3SMJsOlS3IcF6PkLhd7CRvfw= Date: Wed, 27 Mar 2019 19:54:10 +0100 From: Greg KH To: Patrick Venture Subject: Re: [PATCH v7 2/2] drivers/misc: Add Aspeed P2A control driver Message-ID: <20190327185410.GA14828@kroah.com> References: <20190312163101.155910-1-venture@google.com> <20190327164542.GC11712@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190327_115415_478823_07A6F948 X-CRM114-Status: GOOD ( 15.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , linux-aspeed@lists.ozlabs.org, Andrew Jeffery , Linux Kernel Mailing List , Joel Stanley , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 27, 2019 at 11:44:36AM -0700, Patrick Venture wrote: > On Wed, Mar 27, 2019 at 11:28 AM Greg KH wrote: > > > > On Tue, Mar 12, 2019 at 09:31:01AM -0700, Patrick Venture wrote: > > > + phys_addr_t mem_base; > > > > Is this really a 32bit value? > > It's going to be a 32-bit value if this is in the dts for one of the > correspondingly supported aspeed models. > > > > > Your ioctl thinks it is: > > > > > +struct aspeed_p2a_ctrl_mapping { > > > + __u32 addr; > > > > Does this driver not work on a 64bit kernel? > > This driver is aimed at only 32-bit hardware (ast2400/2500). I > modeled the approach after the aspeed-lpc-ctrl driver as it's > providing similar functionality. > > > > > > + __u32 length; > > > + __u32 flags; > > > +}; > > > > addr really should be __u32 here so you don't have to mess with 32/64 > > bit user/kernel issues, right? > > Add is __u32 there. Are you suggesting it shouldn't be? Ugh, yes, sorry, I meant to say "__u64". If you all insist that this is all that is ever going to be needed, ok, but I reserve the right to complain in 4 years when this needs to be changed :) thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel