From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73F18C43381 for ; Wed, 27 Mar 2019 21:39:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38C7B2075E for ; Wed, 27 Mar 2019 21:39:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IXqBVHoD"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="U0Y8HAOx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38C7B2075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/pcVoNJTz6AAd9w+VHAyfkWp8rOFDI+R3WUle12sDYw=; b=IXqBVHoDr32PeX 0kTCyoeWvZp/5023umNsCVLcsatZSl5JoT7f+YCOfwLMcgXfJyXAAtLtbxsuIcXsfgnuLGXX2lzhm kJJQyp1XkMw+XD0B2wjEP6Qmz4kLeJUj5BXHejandYeglIi+sefjtXOlgX9U/iLefrvPao7gsQRYt Z3umY3rL+66elIxK+uxbFycSE8owxjv58TCduXkgiOJkwk5vgO/2JfxT4yge0BcRxpTLtW+BtvJ2o 4+xfPbLCHMX3NbNs6KfXFn+7+7FzUOOlAW4+PeSpYgkOnQ9iBsl8n00ziRKtbV7joMLtess/36mka xVtwUyBfF2O1noFEZtMg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9GGQ-0001iz-N8; Wed, 27 Mar 2019 21:39:14 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9GGN-0001hi-40 for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2019 21:39:13 +0000 Received: by mail-pg1-x542.google.com with SMTP id v12so10586484pgq.1 for ; Wed, 27 Mar 2019 14:39:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tBV2iWRa128NukJOca+ZJOE7a9nsnhgZrO3OcTK2QDQ=; b=U0Y8HAOxfokWlttEecHSPsLlhrxdx11ala0IGrN/CocsPjoo62RZHfoDBVhQ/5L6YS FWm19MxGeutCWxvup18/nJdRj/8zyUEsrnUqm9an2PMg+rXEIf145SOgVXTiTJimNz8e ZUKHiZPqNT70iIYIg6oKBTw18wz26EKsdgfT7I5hW2F4ie/Q98uuTFS0s7nuC0zQwgLW PuFMR6yHWxNw6RGiyFM3952t2ih+q3ZLKAM66m8qND+7L1BsNARJUxyotBmrxoh967J2 NmCfuJkQS9+hxLPz861t0oT0YjjvSnScg+oNV2hAQ6TKUph4aT9EFt6d5ZvOoylI/tkw EiqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tBV2iWRa128NukJOca+ZJOE7a9nsnhgZrO3OcTK2QDQ=; b=Ynnv8gw6nFpBjdIu+WUXJsNUpdk3T226YDl1mx+PJinKiklaoulzdVUtN03nqdJacc W4yR4nFCeOMW5YL3OpHlC07cb4goBnr7tmwU8DRTmuaKKFnZYdK4PNwVj3uX9ULp8LgA +lKcD/IvQ4Fyil9v6XA3co9J4WfPYhTW4BcOPo9y5TQBC7j+mFHO5/7xhrXDjkZYclDS dFqxKitNRn4EDnk6qflraT3HEQipQ1rUkm1qSssF/FFFqiAan0WVq8ZUvYN6NtqpsI87 iX6mIxLw6k385cioUD4u2W1dgmdm1hAQOq7aLvlxwdk/DRJyVnsnEuoyn+dAw23SNZi+ M0Ew== X-Gm-Message-State: APjAAAXkF+9iKcAKqjV06iUp4k/951cBbSIHeDQuekPX9qUp08A2Glwj J3G1cpTt50yGtbS/m7QmIW6I+w== X-Google-Smtp-Source: APXvYqwThrNPLjybOVBMjw2KMgR3vvAYThS+zOpELeEMhDbRUQytn/3xZlbyFy8/U9kgFS8RYhW4KA== X-Received: by 2002:aa7:8589:: with SMTP id w9mr37468920pfn.97.1553722746354; Wed, 27 Mar 2019 14:39:06 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id v6sm13134721pgv.92.2019.03.27.14.39.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Mar 2019 14:39:05 -0700 (PDT) Date: Wed, 27 Mar 2019 15:39:03 -0600 From: Mathieu Poirier To: Suzuki K Poulose Subject: Re: [PATCH 13/25] coresight: etb10: Clean up device specific data Message-ID: <20190327213903.GA778@xps15> References: <1553107783-3340-1-git-send-email-suzuki.poulose@arm.com> <1553107783-3340-14-git-send-email-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1553107783-3340-14-git-send-email-suzuki.poulose@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190327_143911_157463_54FAA7E7 X-CRM114-Status: GOOD ( 16.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, robert.walker@arm.com, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 20, 2019 at 06:49:30PM +0000, Suzuki K Poulose wrote: > Track the coresight device instead of the real device. > > Cc: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-etb10.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c > index 105782e..a471cbd 100644 > --- a/drivers/hwtracing/coresight/coresight-etb10.c > +++ b/drivers/hwtracing/coresight/coresight-etb10.c > @@ -97,12 +97,12 @@ static unsigned int etb_get_buffer_depth(struct etb_drvdata *drvdata) > { > u32 depth = 0; > > - pm_runtime_get_sync(drvdata->dev); > + pm_runtime_get_sync(drvdata->dev->parent); > > /* RO registers don't need locking */ > depth = readl_relaxed(drvdata->base + ETB_RAM_DEPTH_REG); > > - pm_runtime_put(drvdata->dev); > + pm_runtime_put(drvdata->dev->parent); > return depth; > } > > @@ -701,7 +701,6 @@ static int etb_probe(struct amba_device *adev, const struct amba_id *id) > if (!drvdata) > return -ENOMEM; > > - drvdata->dev = &adev->dev; > drvdata->atclk = devm_clk_get(&adev->dev, "atclk"); /* optional */ > if (!IS_ERR(drvdata->atclk)) { > ret = clk_prepare_enable(drvdata->atclk); > @@ -740,6 +739,7 @@ static int etb_probe(struct amba_device *adev, const struct amba_id *id) > if (IS_ERR(drvdata->csdev)) > return PTR_ERR(drvdata->csdev); > > + drvdata->dev = &drvdata->csdev->dev; For patch 11, 12, 13 - same comment as earlier. Let's use drvdata::csdev and get rid of drvdata::dev. > drvdata->miscdev.name = pdata->name; > drvdata->miscdev.minor = MISC_DYNAMIC_MINOR; > drvdata->miscdev.fops = &etb_fops; > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel