From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A31CC43381 for ; Wed, 27 Mar 2019 22:17:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 48A1E2070B for ; Wed, 27 Mar 2019 22:17:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OTsjdggB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48A1E2070B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=the-dreams.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ca9gHllqymU0wsoYgu16LMudwKqOuWSwpQishYno2Ko=; b=OTsjdggBtM+i1dOoEyTovcMzu 3x/xZVYgqp3mDvNf92kBtBFBkYiGZR7FVPn77AnraCy+w9RAM4EMrs9E9MmMXKuZFO6ZUUq69QQbS 3Azd4GVhNuu/ULeZEUBH1M8a1uW99NJmmYnAvQxxaG0R76dXMkBtSjFVj5/BlzzM558uLv6AIrCEa 0D8RQeQl0x7SXshCAaJPaHEyNcRYF6l2X0ARBm9U190n80bXI+0cDBjg/VZG2nUrDgk1tZkLqq+Rp XVoZPAIg5bak+SAVlv+QPOz2HZbEO9UiilGEX6wjNDNJkSH1ahYNZ5tOmLVu2ju3nhc8bYWY9Gw7m maJBkWnSw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9GrY-00069o-RM; Wed, 27 Mar 2019 22:17:36 +0000 Received: from sauhun.de ([88.99.104.3] helo=pokefinder.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9GrV-00069S-UR for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2019 22:17:35 +0000 Received: from localhost (p5486CE6B.dip0.t-ipconnect.de [84.134.206.107]) by pokefinder.org (Postfix) with ESMTPSA id 132EB2E35A2; Wed, 27 Mar 2019 23:17:33 +0100 (CET) Date: Wed, 27 Mar 2019 23:17:32 +0100 From: Wolfram Sang To: Ray Jui Subject: Re: [PATCH v5 1/8] i2c: iproc: Extend I2C read up to 255 bytes Message-ID: <20190327221732.GB15396@kunai> References: <20190214175725.60462-1-ray.jui@broadcom.com> <20190214175725.60462-2-ray.jui@broadcom.com> MIME-Version: 1.0 In-Reply-To: <20190214175725.60462-2-ray.jui@broadcom.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190327_151734_131894_CE56345E X-CRM114-Status: UNSURE ( 8.16 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Shreesha Rajashekar , Rayagonda Kokatanur , linux-kernel@vger.kernel.org, Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============3500115603655016471==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3500115603655016471== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="v9Ux+11Zm5mwPlX6" Content-Disposition: inline --v9Ux+11Zm5mwPlX6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > + if (!((readl(iproc_i2c->base + > + M_FIFO_CTRL_OFFSET) >> > + M_FIFO_RX_CNT_SHIFT) & > + M_FIFO_RX_CNT_MASK)) Don't be too strict with the 80 char limit. I think the above is hardly readable... > + break; > + > + msg->buf[iproc_i2c->rx_bytes] = > + (readl(iproc_i2c->base + M_RX_OFFSET) >> > + M_RX_DATA_SHIFT) & M_RX_DATA_MASK; ... this here is MUCH better. Rest looks good. --v9Ux+11Zm5mwPlX6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlyb9nwACgkQFA3kzBSg KbYzdg//TqhPqqJ8jsf33y2YrdjFG4eYNsHy58/R6LsqUp47WsYfxCSK+pIqGFds w7Tr35HB0oOQCqxAMnsV0hJV1bdITMR3N5KpW2LPL4YHBOIfsdtwJShPjo/n7vJE XLCEWto8fyIxjFYu/VfIPpeFyMK0djtvnAr1aT0Hu7iJbNuqPtgK0Htu5YqJUAHF +KqsZtyIue8+16veAvEJ7jzQl7XcXkejpak1oOBrm69i3tvi5P0HK0wRTAninCZn v1GgOWnoP0iltCJpSDiZIRtEWcstGvx9vuHCu1DI9b/f7bk9F1Qh4V6Vwuot2JiF oG+J6UptJjoK90ZSBY4Z2yiDRU+qVYAwjskY2PLeG2AgMYP47LhZ7RDzfcNtJmiE fA+cwS3GhqIiFZbo0FPP1nKMvaJHr4xm0RDgPoTvmqxAUt5BwIMM2V8/ZnI8rlvW GVPoX9W2V4z5W8BF6/QXaaYk1QY6WLnTEgi31fofCbnYyxSre0MwvvtUzfiVdCr9 IKQKV4N1s4MDYk6nOQ6x+rGa0tmJrw2wP8UJBGD4vl/TtSrCHmd8IJAE9xF/A85v 7L0NpRIomYRXpeJRtm7mYsr8Nl/HY5nXGgK+eKScXanv7kV81P88dF+KrFDh2Ymg +tB0iOV1QGcCKxNEx0h73cs1nhTfQLL2lCZpz3d0XntkA1q2Ysg= =5U3k -----END PGP SIGNATURE----- --v9Ux+11Zm5mwPlX6-- --===============3500115603655016471== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3500115603655016471==--