From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC29DC43381 for ; Wed, 27 Mar 2019 22:57:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C7782082F for ; Wed, 27 Mar 2019 22:57:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nzb2hGHt"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sdW6LT2k" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C7782082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4zwGL5fYxJ7QHIihRojWSfQ41OcUL4ci7xivh3yLIi0=; b=nzb2hGHtV8SyVj Zz/wGQ03tvIy1Qbz4jo38lJwUrQNCjbX76mS674iOSx/oJn0Qfo/lM5icbY/+kQpb77HTJAHQqJQh QwxGAf3U2j4JkSepA5AYFAU14pNtm9TSXc15aSx4ItKW45DrOK95OpXJx+tRoMCB53GZHlCNedxJA WII6+04BfoYz30CNpntE0KfbPkOGJo+ErOeY7GreRBIKvDauvSI9woON2dA+0HJw5/EfQJihCJ5w5 hiHxuggyeLdi72JveqT4Ex3FiJtojGR7EBGxrgGwXD+KHHaXNZw8gGe/SkY2dKS+hE5KjGc+jMugh WoqYcmdgEjbezs9SXs7w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9HUB-0002vq-2B; Wed, 27 Mar 2019 22:57:31 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9HU4-0002v6-Vj for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2019 22:57:29 +0000 Received: by mail-pl1-x642.google.com with SMTP id bf11so4004394plb.12 for ; Wed, 27 Mar 2019 15:57:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1voiXgHHVynwQDWGIxwTNJOz7UlzSl9MsY0QasMD/RQ=; b=sdW6LT2ktGaSfHx83wQfq7mYZvV7SUH69pQx49rT18CwEcPEfKNj29oBXsued4AGyT C4sAgHP1cwAa3wb4gY+JqApJD5PeLeoe/VNi9cpvulgHDZJESqP3wWTuIortLuAzF+G8 RhyMgFQ/wbn1EbHypZAdrQjf0EU1sBLPt+azmUa5QDstJMOefPLfhMZxxtEPGHkY7W1U DpUmoME72jby0d3sCZ6e5RvF+jHHBehuRryPGoxikZRAr7s6Blpq45cuxHXUV6mWIW+G DbQV+HEDQbTPjuLvbYRuRX7PzZp88WgCUBV5SBz1074X+pbhA6FoS+xbGFl1oi4XwDfa EhEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1voiXgHHVynwQDWGIxwTNJOz7UlzSl9MsY0QasMD/RQ=; b=Hb83w+MAiRRO+oYjI0e6FmwHO0naAiMwZp6ZtyOoAtWPWMENpnCp5UINPGYhQp4ynX 4DBe19u7ESOg8UlWQoXHydOO2g2RrTb7wB9hiEapEiyRC22CF8Ofr3cy4kU3dONuhdwj /EO35luTC1uKyupPtMYO+9jXdHK9wvpS7Klxq7lUgylMkpKGSoNGrFxii174CC7VlHNc KHS/E2mZtQ/IWowAe7oAfwNc6Sj2C0bdrjZM+o0+EGzfTwvG4b0X9EgJchg1K0ASkFCk AXXiE8RyERGMqfdvBnLj1WA9cj5U9hnq/FKINuJl2phlUgpONEdb9dAZou8vdSF79qdP 6nuA== X-Gm-Message-State: APjAAAXYYA8L16zaIJX79ahYK8DHFydJDGJcRLEJKqwpotsHAVyG7w1k t6G6AcQW81Ghv3SKmKOrX57b6A== X-Google-Smtp-Source: APXvYqwFOUaiByNeTxMZj6dy64uEz/qaLwh+H+MLGwAb5YeIq34OYH+G1QSCbWr6TFXa+68bBzCfzA== X-Received: by 2002:a17:902:9a43:: with SMTP id x3mr38997076plv.173.1553727443861; Wed, 27 Mar 2019 15:57:23 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id g2sm3252345pfd.134.2019.03.27.15.57.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Mar 2019 15:57:23 -0700 (PDT) Date: Wed, 27 Mar 2019 16:57:21 -0600 From: Mathieu Poirier To: Suzuki K Poulose Subject: Re: [PATCH 18/25] coresight: Introduce generic platform data helper Message-ID: <20190327225721.GC778@xps15> References: <1553107783-3340-1-git-send-email-suzuki.poulose@arm.com> <1553107783-3340-19-git-send-email-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1553107783-3340-19-git-send-email-suzuki.poulose@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190327_155725_035171_95CD882A X-CRM114-Status: GOOD ( 22.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, robert.walker@arm.com, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 20, 2019 at 06:49:35PM +0000, Suzuki K Poulose wrote: > So far we have hard coded the DT platform parsing code in > every driver. Introduce generic helper to parse the information > provided by the firmware in a platform agnostic manner, in preparation > for the ACPI support. > > Cc: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-catu.c | 13 ++--- > drivers/hwtracing/coresight/coresight-etb10.c | 11 ++-- > drivers/hwtracing/coresight/coresight-etm3x.c | 12 ++-- > drivers/hwtracing/coresight/coresight-etm4x.c | 11 ++-- > drivers/hwtracing/coresight/coresight-funnel.c | 11 ++-- > drivers/hwtracing/coresight/coresight-platform.c | 65 +++++++++++++--------- > drivers/hwtracing/coresight/coresight-replicator.c | 12 ++-- > drivers/hwtracing/coresight/coresight-stm.c | 11 ++-- > drivers/hwtracing/coresight/coresight-tmc.c | 13 ++--- > drivers/hwtracing/coresight/coresight-tpiu.c | 11 ++-- > include/linux/coresight.h | 7 +-- > 11 files changed, 80 insertions(+), 97 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-catu.c b/drivers/hwtracing/coresight/coresight-catu.c > index 671a05a..4595c67 100644 > --- a/drivers/hwtracing/coresight/coresight-catu.c > +++ b/drivers/hwtracing/coresight/coresight-catu.c > @@ -503,17 +503,14 @@ static int catu_probe(struct amba_device *adev, const struct amba_id *id) > struct coresight_desc catu_desc; > struct coresight_platform_data *pdata = NULL; > struct device *dev = &adev->dev; > - struct device_node *np = dev->of_node; > void __iomem *base; > > - if (np) { > - pdata = of_get_coresight_platform_data(dev, np); > - if (IS_ERR(pdata)) { > - ret = PTR_ERR(pdata); > - goto out; > - } > - dev->platform_data = pdata; > + pdata = coresight_get_platform_data(dev); > + if (IS_ERR(pdata)) { > + ret = PTR_ERR(pdata); > + goto out; > } > + dev->platform_data = pdata; > > drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); > if (!drvdata) { > diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c > index a471cbd..e4175849 100644 > --- a/drivers/hwtracing/coresight/coresight-etb10.c > +++ b/drivers/hwtracing/coresight/coresight-etb10.c > @@ -688,14 +688,11 @@ static int etb_probe(struct amba_device *adev, const struct amba_id *id) > struct etb_drvdata *drvdata; > struct resource *res = &adev->res; > struct coresight_desc desc = { 0 }; > - struct device_node *np = adev->dev.of_node; > > - if (np) { > - pdata = of_get_coresight_platform_data(dev, np); > - if (IS_ERR(pdata)) > - return PTR_ERR(pdata); > - adev->dev.platform_data = pdata; > - } > + pdata = coresight_get_platform_data(dev); > + if (IS_ERR(pdata)) > + return PTR_ERR(pdata); > + adev->dev.platform_data = pdata; > > drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); > if (!drvdata) > diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c b/drivers/hwtracing/coresight/coresight-etm3x.c > index 7137f06..b101464 100644 > --- a/drivers/hwtracing/coresight/coresight-etm3x.c > +++ b/drivers/hwtracing/coresight/coresight-etm3x.c > @@ -788,20 +788,16 @@ static int etm_probe(struct amba_device *adev, const struct amba_id *id) > struct etm_drvdata *drvdata; > struct resource *res = &adev->res; > struct coresight_desc desc = { 0 }; > - struct device_node *np = adev->dev.of_node; > > drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); > if (!drvdata) > return -ENOMEM; > > - if (np) { > - pdata = of_get_coresight_platform_data(dev, np); > - if (IS_ERR(pdata)) > - return PTR_ERR(pdata); > - > - adev->dev.platform_data = pdata; > - } > + pdata = coresight_get_platform_data(dev); > + if (IS_ERR(pdata)) > + return PTR_ERR(pdata); > > + adev->dev.platform_data = pdata; > drvdata->use_cp14 = fwnode_property_read_bool(dev->fwnode, "arm,cp14"); > dev_set_drvdata(dev, drvdata); > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c > index 8d5ee3b..bfc23ab 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x.c > +++ b/drivers/hwtracing/coresight/coresight-etm4x.c > @@ -974,18 +974,15 @@ static int etm4_probe(struct amba_device *adev, const struct amba_id *id) > struct etmv4_drvdata *drvdata; > struct resource *res = &adev->res; > struct coresight_desc desc = { 0 }; > - struct device_node *np = adev->dev.of_node; > > drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); > if (!drvdata) > return -ENOMEM; > > - if (np) { > - pdata = of_get_coresight_platform_data(dev, np); > - if (IS_ERR(pdata)) > - return PTR_ERR(pdata); > - adev->dev.platform_data = pdata; > - } > + pdata = coresight_get_platform_data(dev); > + if (IS_ERR(pdata)) > + return PTR_ERR(pdata); > + adev->dev.platform_data = pdata; > > dev_set_drvdata(dev, drvdata); > > diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c > index 1085f31..2590744 100644 > --- a/drivers/hwtracing/coresight/coresight-funnel.c > +++ b/drivers/hwtracing/coresight/coresight-funnel.c > @@ -185,14 +185,11 @@ static int funnel_probe(struct amba_device *adev, const struct amba_id *id) > struct funnel_drvdata *drvdata; > struct resource *res = &adev->res; > struct coresight_desc desc = { 0 }; > - struct device_node *np = adev->dev.of_node; > > - if (np) { > - pdata = of_get_coresight_platform_data(dev, np); > - if (IS_ERR(pdata)) > - return PTR_ERR(pdata); > - adev->dev.platform_data = pdata; > - } > + pdata = coresight_get_platform_data(dev); > + if (IS_ERR(pdata)) > + return PTR_ERR(pdata); > + adev->dev.platform_data = pdata; > > drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); > if (!drvdata) > diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c > index 514cc2b..693e3f5 100644 > --- a/drivers/hwtracing/coresight/coresight-platform.c > +++ b/drivers/hwtracing/coresight/coresight-platform.c > @@ -17,6 +17,20 @@ > #include > #include > > +static int coresight_alloc_conns(struct device *dev, > + struct coresight_platform_data *pdata) > +{ > + if (pdata->nr_outport) { > + pdata->conns = devm_kzalloc(dev, pdata->nr_outport * > + sizeof(*pdata->conns), > + GFP_KERNEL); > + if (!pdata->conns) > + return -ENOMEM; > + } > + > + return 0; > +} > + > #ifdef CONFIG_OF > static int of_dev_node_match(struct device *dev, void *data) > { > @@ -133,20 +147,6 @@ static void of_coresight_get_ports(const struct device_node *node, > } > } > > -static int of_coresight_alloc_memory(struct device *dev, > - struct coresight_platform_data *pdata) > -{ > - if (pdata->nr_outport) { > - pdata->conns = devm_kzalloc(dev, pdata->nr_outport * > - sizeof(*pdata->conns), > - GFP_KERNEL); > - if (!pdata->conns) > - return -ENOMEM; > - } > - > - return 0; > -} > - > int of_coresight_get_cpu(const struct device_node *node) > { > int cpu; > @@ -226,23 +226,17 @@ static int of_coresight_parse_endpoint(struct device *dev, > return ret; > } > > -struct coresight_platform_data * > +static struct coresight_platform_data * > of_get_coresight_platform_data(struct device *dev, > - const struct device_node *node) > + struct coresight_platform_data *pdata) > { > int ret = 0; > - struct coresight_platform_data *pdata; > struct coresight_connection *conn; > struct device_node *ep = NULL; > const struct device_node *parent = NULL; > bool legacy_binding = false; > + struct device_node *node = dev->of_node; > > - pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); > - if (!pdata) > - return ERR_PTR(-ENOMEM); > - > - /* Use device name as sysfs handle */ > - pdata->name = dev_name(dev); > pdata->cpu = of_coresight_get_cpu(node); > > /* Get the number of input and output port for this component */ > @@ -252,7 +246,7 @@ of_get_coresight_platform_data(struct device *dev, > if (!pdata->nr_outport) > return pdata; > > - ret = of_coresight_alloc_memory(dev, pdata); > + ret = coresight_alloc_conns(dev, pdata); I'm pretty sure you're doing this because you want to use coresight_alloc_conns() for ACPI as well, and I'm fine with that. But it is quite orthogonal to the rest of the work done in this patch and as such I think it needs a patch of its own. > if (ret) > return ERR_PTR(ret); > > @@ -294,5 +288,26 @@ of_get_coresight_platform_data(struct device *dev, > > return pdata; > } > -EXPORT_SYMBOL_GPL(of_get_coresight_platform_data); > #endif > + > +struct coresight_platform_data * > +coresight_get_platform_data(struct device *dev) > +{ > + struct coresight_platform_data *pdata; > + > + if (IS_ERR_OR_NULL(dev->fwnode)) > + return NULL; > + > + pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); > + if (!pdata) > + return ERR_PTR(-ENOMEM); > + > + /* Use device name as sysfs handle */ > + pdata->name = dev_name(dev); > + > + if (is_of_node(dev->fwnode)) > + return of_get_coresight_platform_data(dev, pdata); > + > + return ERR_PTR(-ENOENT); > +} > +EXPORT_SYMBOL_GPL(coresight_get_platform_data); > diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c > index 8bbb008..7eb3bf7 100644 > --- a/drivers/hwtracing/coresight/coresight-replicator.c > +++ b/drivers/hwtracing/coresight/coresight-replicator.c > @@ -177,15 +177,12 @@ static int replicator_probe(struct device *dev, struct resource *res) > struct coresight_platform_data *pdata = NULL; > struct replicator_drvdata *drvdata; > struct coresight_desc desc = { 0 }; > - struct device_node *np = dev->of_node; > void __iomem *base; > > - if (np) { > - pdata = of_get_coresight_platform_data(dev, np); > - if (IS_ERR(pdata)) > - return PTR_ERR(pdata); > - dev->platform_data = pdata; > - } > + pdata = coresight_get_platform_data(dev); > + if (IS_ERR(pdata)) > + return PTR_ERR(pdata); > + dev->platform_data = pdata; > > drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); > if (!drvdata) > @@ -213,7 +210,6 @@ static int replicator_probe(struct device *dev, struct resource *res) > } > > dev_set_drvdata(dev, drvdata); > - > desc.type = CORESIGHT_DEV_TYPE_LINK; > desc.subtype.link_subtype = CORESIGHT_DEV_SUBTYPE_LINK_SPLIT; > desc.ops = &replicator_cs_ops; > diff --git a/drivers/hwtracing/coresight/coresight-stm.c b/drivers/hwtracing/coresight/coresight-stm.c > index eb96bba..6514586 100644 > --- a/drivers/hwtracing/coresight/coresight-stm.c > +++ b/drivers/hwtracing/coresight/coresight-stm.c > @@ -809,14 +809,11 @@ static int stm_probe(struct amba_device *adev, const struct amba_id *id) > size_t bitmap_size; > struct coresight_desc desc = { 0 }; > struct coresight_device *csdev; > - struct device_node *np = adev->dev.of_node; > > - if (np) { > - pdata = of_get_coresight_platform_data(dev, np); > - if (IS_ERR(pdata)) > - return PTR_ERR(pdata); > - adev->dev.platform_data = pdata; > - } > + pdata = coresight_get_platform_data(dev); > + if (IS_ERR(pdata)) > + return PTR_ERR(pdata); > + adev->dev.platform_data = pdata; > drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); > if (!drvdata) > return -ENOMEM; > diff --git a/drivers/hwtracing/coresight/coresight-tmc.c b/drivers/hwtracing/coresight/coresight-tmc.c > index 7ce3427..147ab17 100644 > --- a/drivers/hwtracing/coresight/coresight-tmc.c > +++ b/drivers/hwtracing/coresight/coresight-tmc.c > @@ -394,16 +394,13 @@ static int tmc_probe(struct amba_device *adev, const struct amba_id *id) > struct tmc_drvdata *drvdata; > struct resource *res = &adev->res; > struct coresight_desc desc = { 0 }; > - struct device_node *np = adev->dev.of_node; > > - if (np) { > - pdata = of_get_coresight_platform_data(dev, np); > - if (IS_ERR(pdata)) { > - ret = PTR_ERR(pdata); > - goto out; > - } > - adev->dev.platform_data = pdata; > + pdata = coresight_get_platform_data(dev); > + if (IS_ERR(pdata)) { > + ret = PTR_ERR(pdata); > + goto out; > } > + adev->dev.platform_data = pdata; > > ret = -ENOMEM; > drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); > diff --git a/drivers/hwtracing/coresight/coresight-tpiu.c b/drivers/hwtracing/coresight/coresight-tpiu.c > index 9763721..18a749a 100644 > --- a/drivers/hwtracing/coresight/coresight-tpiu.c > +++ b/drivers/hwtracing/coresight/coresight-tpiu.c > @@ -120,14 +120,11 @@ static int tpiu_probe(struct amba_device *adev, const struct amba_id *id) > struct resource *res = &adev->res; > struct coresight_desc desc = { 0 }; > struct coresight_device *csdev; > - struct device_node *np = adev->dev.of_node; > > - if (np) { > - pdata = of_get_coresight_platform_data(dev, np); > - if (IS_ERR(pdata)) > - return PTR_ERR(pdata); > - adev->dev.platform_data = pdata; > - } > + pdata = coresight_get_platform_data(dev); > + if (IS_ERR(pdata)) > + return PTR_ERR(pdata); > + adev->dev.platform_data = pdata; > > drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); > if (!drvdata) > diff --git a/include/linux/coresight.h b/include/linux/coresight.h > index 7b87965..5b29255 100644 > --- a/include/linux/coresight.h > +++ b/include/linux/coresight.h > @@ -293,14 +293,11 @@ static inline void coresight_disclaim_device_unlocked(void __iomem *base) {} > > #ifdef CONFIG_OF > extern int of_coresight_get_cpu(const struct device_node *node); > -extern struct coresight_platform_data * > -of_get_coresight_platform_data(struct device *dev, > - const struct device_node *node); > #else > static inline int of_coresight_get_cpu(const struct device_node *node) > { return 0; } > -static inline struct coresight_platform_data *of_get_coresight_platform_data( > - struct device *dev, const struct device_node *node) { return NULL; } > #endif > > +struct coresight_platform_data *coresight_get_platform_data(struct device *dev); > + > #endif > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel