From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB87FC43381 for ; Thu, 28 Mar 2019 04:29:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 52A4B206B6 for ; Thu, 28 Mar 2019 04:29:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="g3Pa6gZg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KhH1uQ0b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52A4B206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ljmxrl9qF048XVut5Fce5vi57BjhuVXNKbjNRub4jYg=; b=g3Pa6gZgLtKRG/ UsEAwb9EJUNU0g2BPxIjk0qnHujTehAmEWmUjsRc/uQYsRtjmoqiMppb+TsTEqWsYC7SP5bVN4dru 4i6FiWGlXTGkIeLe0kEdRDtSU/1EB4PCVppXWqTLg1xSaLw60ZAYyBtQrBqQZuQ1ROGg/tRkaerLu 5/6L+ukVw/MhXEI1qH3PMHuSVQejFFQWKGGEUMSGXsdUeGYcnKpHSXDfzBlBBZVTpOx1kXqkxFL60 S/8SeD71PNU1l/CtDK7dhmyVTO4j/nWdLZ3aTUK+oXp9SuEGZt3LGDOZVH/i1gNI+kJV/qnIH4tJu 2v/p4WBmbGrz2nQk99mg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9MfW-0007MJ-Se; Thu, 28 Mar 2019 04:29:34 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9MfT-0007LU-3l for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2019 04:29:32 +0000 Received: by mail-pf1-x441.google.com with SMTP id b3so9379313pfd.1 for ; Wed, 27 Mar 2019 21:29:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ra5qmltG1yR3IdkeijZjpsAfDYs4Hq4slA9oLR568/4=; b=KhH1uQ0bV+hRHzZ8P11Mhg/zCj6P2VBRf5TAnF0uvC3WoHy/i1cCkO5V5ld9tnt71c okHXFlf8k6mjbqX1zL4qUKX6DbKdbpH77hNBuTbXZIbsdPhT64sXJCWuwCK8xOahlJUM bJUWtpf/TZ/TQCnsYoa7WqAxJuzQxX7dwyT+ZqF9F8+wDOPLB5q5S2RJVh5VC5kJcM2T S6Y56NL2x7Fd4Sw9pZJjWR2UwdsxtOqwNXTmsFggt8Usm5CGip3XsJ9V+JfXTI8U3qjH 1VmtJiBWhhK8A8ItZmDDrgkajrJ2+QjqqwYW5wIttBdJn50na42eA7FrHwXCGSbTdqT7 7/nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ra5qmltG1yR3IdkeijZjpsAfDYs4Hq4slA9oLR568/4=; b=qL82dYTKS1gD7HPzDFYcXoFlzPDtkmUxt9QE3TeBNXl7CAdHs4MkuPIfS4YPhZohWf b5ZkcExq8skKfe2fCE6Y5HBg/ePRhrOJ5HnQDfDwG6aHSQL4DLDVB8+H6UD6IqNTwofF NqVq4na56GcW/3/JAuVH25Ea/a8XN2BqpHMRGLu+KMR8fAzAgAqmugEGF/twad5LBBnM Aw50Bw55cbRbatMoGqhYhSDZCGNvT/ViJLvtWdTwfvIe/lXfzf6TV1y6jjOyOeOFAftd XPQ4gPbW/IeokTTq+gtndH2zU6Btxt6tJBZaolYh7p3lCRLzYvr8AeWdbaf35AhE6Vmd 9biw== X-Gm-Message-State: APjAAAXcjRtMq582vHxQ4YUgYpCpfpCSzTzRqCMtrx6aqtKp3gaMg1iZ fDJ0P2yFioGjE9fvj/NT5f8= X-Google-Smtp-Source: APXvYqzo3Z15BMuwUzNMNG5EvcqXYjfaHuaLiOGQkwFx1doRSjsCPVtA4pk5V4BuZETA0dgqr8pZEg== X-Received: by 2002:aa7:83ca:: with SMTP id j10mr38775736pfn.50.1553747367375; Wed, 27 Mar 2019 21:29:27 -0700 (PDT) Received: from icarus ([2001:268:c0a2:ad41:c70:4af9:86e2:2]) by smtp.gmail.com with ESMTPSA id j20sm28222283pff.22.2019.03.27.21.29.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Mar 2019 21:29:26 -0700 (PDT) Date: Thu, 28 Mar 2019 13:30:13 +0900 From: William Breathitt Gray To: Lukas Wunner Subject: Re: [PATCH v13 01/11] bitops: Introduce the for_each_set_clump8 macro Message-ID: <20190328043013.GA3251@icarus> References: <497dc4b5b1f668b54e008e10a43d4108f4a41213.1553661964.git.vilhelm.gray@gmail.com> <20190327064254.lwj7ew37mxphieco@wunner.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190327064254.lwj7ew37mxphieco@wunner.de> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190327_212931_179180_0352B833 X-CRM114-Status: GOOD ( 15.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, preid@electromag.com.au, Arnd Bergmann , linux-gpio@vger.kernel.org, yamada.masahiro@socionext.com, linus.walleij@linaro.org, linux-pm@vger.kernel.org, linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org, bgolaszewski@baylibre.com, Andy Shevchenko , geert@linux-m68k.org, akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 27, 2019 at 07:42:54AM +0100, Lukas Wunner wrote: > On Wed, Mar 27, 2019 at 01:58:45PM +0900, William Breathitt Gray wrote: > > This macro iterates for each 8-bit group of bits (clump) with set bits, > > within a bitmap memory region. For each iteration, "start" is set to the > > bit offset of the found clump, while the respective clump value is > > stored to the location pointed by "clump". Additionally, the > > bitmap_get_value8 and bitmap_set_value8 functions are introduced to > > respectively get and set an 8-bit value in a bitmap memory region. > > I would have preferred static inlines for bitmap_get_value8(), > bitmap_set_value8() and find_next_clump8() to make this as fast > as possible in the callers because I've personally worked with > an industrial application where the GPIO pins of a 74x164 are > written every 250 usec. > > But apart from that I like this series a lot, thanks for working on it. > > Lukas I'm not sure these can be static inline since the symbols are exported for use outside this file. However, in theory I have no objection from a performance standpoint. Since my devices don't have such strict realtime requirements as your 74x164 application, I'll defer this decision to someone more knowledgeable in this area; perhaps someone else can comment in this thread with their advice and suggestions. William Breathitt Gray _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel