From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C66AAC43381 for ; Thu, 28 Mar 2019 04:39:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95F2B206DF for ; Thu, 28 Mar 2019 04:39:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lLKLWm37"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RAN5zy/f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95F2B206DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+dmAYBBml0vlEqE+Hly5gPyMyZ3I5NDzJMaZglxN8+U=; b=lLKLWm37m5URsT rYd3k5yN6ZJz5PDlcwkSf9GubDPKb+cjM/sY0gXH59KyYt9q//XeBZ8Vwa35/Qw2dPvqUTJ5kzLfu V3czXBqkoq/kA/c7cvux6DgO2bMuw4A05TAohWUi3Iv7zx5djKjleuxB931J6IzvYF6NDC5iWeSBe B70Nv0fDfu5OB6GQ9/EDJwt/25K6eF1RYOxXAy8MzAWws37ivMlIGMdMpjBdnDxgZZGTR4BECuPkz KyFj/HeDw8VsjWOAJP/RwmDV/l517pQ/THFAXtg2327zIPJct26wlIE6w7QM97gSvbu0mu93X9QBW XooluQQqFvvlACZmlOTw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9Mot-0001lH-L9; Thu, 28 Mar 2019 04:39:15 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9Mon-0001kP-9y for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2019 04:39:13 +0000 Received: by mail-pl1-x644.google.com with SMTP id bf11so4371606plb.12 for ; Wed, 27 Mar 2019 21:39:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=H8r/rPDIdp1bYLW9wSNX+D8mlHRpDf4FGN+0AbSvEfE=; b=RAN5zy/f+G552WpqxoPnHecVTkvPuGC+b15Dnkn2RfGy+vGXdf/vxJrgCf1Xpu5d+1 o5yzxCkTOk2C/dyvyioPdb72xfzNkOBwT2o+oLpNCElU4+Be+CZNOyvZrQ2xwa4NHXzF BTcwsyRRz1OJ7OabkOhVsxARsrNgijsy83/7hP9UQjR8ClNLp04RtfKUepxmBuu7neyC ecIfLSjnVPmmwy7oo6EBskUhReSiu95d5wRZDNeYgOggBxp7P99TXh41Yc9+vu0iZ2pg svrIGDxBGGWrZvaYSIt+0wevscM5R5iGrdLKD+XHLNff8LBe6asbG1AMGmViSWlslk59 Aexw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=H8r/rPDIdp1bYLW9wSNX+D8mlHRpDf4FGN+0AbSvEfE=; b=Fkx4Cv2AAuHQZ46SDYwzT7D+hSGJwVzs13x610cy2hcL+Km9JqCzoHloLy9JjckVBN TpycTAnhKODJTJSZSRhOCfbd+utzxh6Kv0NIQeNo7WXrhX8DqKlUQhJpjiKBRLvWMpjQ DTfjTVlsFb1W7cANo8FkZBz7F844GEq8HNZSTQFVemz0w4aDGdVnb5zElapjK28+IOxE vr22FUgil7qpj38LALa7zN8juGDqK5tOzOrD+v7an5pQ+BZxlkzrCYUieTD/0MK1supE Mj4ZbN+WP+sShugJszR5qTL9HQxZ3yjvwUCDkkvOxXd9IT1SWAFkY330OF8ThvhcbD1x jRJA== X-Gm-Message-State: APjAAAVLw5nSgKo0kYyCKoNWMI4hQbrSRZ4TvV+Sq9ERCxl1DhKCXlN8 1VRk69bFEgmKQb8MlvhPFApisSaR X-Google-Smtp-Source: APXvYqw4+w4/HVQXdw9bX68V9rDSUG5OrUi5kuPGYvGmmtQmQyp4oqkB4ZR9X8HLZ9xgRfOJtlw8Mg== X-Received: by 2002:a17:902:b58f:: with SMTP id a15mr26648596pls.36.1553747946345; Wed, 27 Mar 2019 21:39:06 -0700 (PDT) Received: from icarus ([2001:268:c0a2:ad41:c70:4af9:86e2:2]) by smtp.gmail.com with ESMTPSA id e21sm20915179pfd.177.2019.03.27.21.38.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Mar 2019 21:39:05 -0700 (PDT) Date: Thu, 28 Mar 2019 13:40:04 +0900 From: William Breathitt Gray To: Andy Shevchenko Subject: Re: [PATCH v13 10/11] gpio: 74x164: Utilize the for_each_set_clump8 macro Message-ID: <20190328044004.GB3251@icarus> References: <645f16f1d1ad3f215e34a82f457e06725fcf8f56.1553661964.git.vilhelm.gray@gmail.com> <20190327123314.GJ9224@smile.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190327123314.GJ9224@smile.fi.intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190327_213909_395971_39680C44 X-CRM114-Status: GOOD ( 12.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Geert Uytterhoeven , linux-gpio@vger.kernel.org, yamada.masahiro@socionext.com, linus.walleij@linaro.org, linux-pm@vger.kernel.org, linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org, bgolaszewski@baylibre.com, geert@linux-m68k.org, akpm@linux-foundation.org, preid@electromag.com.au, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 27, 2019 at 02:33:14PM +0200, Andy Shevchenko wrote: > On Wed, Mar 27, 2019 at 02:02:39PM +0900, William Breathitt Gray wrote: > > Replace verbose implementation in set_multiple callback with > > for_each_set_clump8 macro to simplify code and improve clarity. > > > + for_each_set_clump8(offset, bankmask, mask, chip->registers * 8) { > > > + bank = (chip->registers - 1) - (offset / 8); > > Excessive parens, but it's minor. Fair point, this could do without parens around (chip->registers - 1). Since this and renaming 'idx' to 'index' in find_bit.c are such a minor changes, I'll wait first to see if something else comes up to be fixed in this review. If so, I'll add these changes to the next version of this patchset. William Breathitt Gray > > > + bitmask = bitmap_get_value8(bits, offset) & bankmask; > > > > chip->buffer[bank] &= ~bankmask; > > + chip->buffer[bank] |= bitmask; > > } > > -- > With Best Regards, > Andy Shevchenko > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel