From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5177C43381 for ; Thu, 28 Mar 2019 09:12:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B532A2173C for ; Thu, 28 Mar 2019 09:12:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fnTV/S0T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B532A2173C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j+GlQ2uASOSfLoiW4moX5yE8lUfZUBDrSnZcq9KlTeM=; b=fnTV/S0TsXMSne +J5dJPGaMMsSeO26xZOUn8uo46GV5ufe84wvGgd/HeBghmW7xDXV0GLlPEiVrOYxHU1c+lZYgper3 akioHI9rmtIwZBRoZ1H6Pb+nYSe+w4E+sQtpU1ba0oc1prxUVollkhzuEMW828QsFPBcMWqa4ngbJ qKiwBByzmdzsHjMUMXH8LvGUIrHFTVjnNtz2/BFDJLw1Pw1RuXOyuiddFD/1nvN35QKOsXLYK8iP8 JVpM5/laKlVueSQK6aa4FsefdBU8efqnPgqsBF9oD5oYimd4amXP7dIeGiwo92+I2kucnD5SmXkui R9QAnJdvKHdwNa1X38bw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9R4s-0000h8-J7; Thu, 28 Mar 2019 09:12:02 +0000 Received: from mga06.intel.com ([134.134.136.31]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9R4p-0000gI-8V for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2019 09:12:01 +0000 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2019 02:11:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,280,1549958400"; d="scan'208";a="155974846" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by fmsmga002.fm.intel.com with ESMTP; 28 Mar 2019 02:11:53 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1h9R4h-0000Qc-U8; Thu, 28 Mar 2019 11:11:51 +0200 Date: Thu, 28 Mar 2019 11:11:51 +0200 From: Andy Shevchenko To: William Breathitt Gray Subject: Re: [PATCH v13 10/11] gpio: 74x164: Utilize the for_each_set_clump8 macro Message-ID: <20190328091151.GU9224@smile.fi.intel.com> References: <645f16f1d1ad3f215e34a82f457e06725fcf8f56.1553661964.git.vilhelm.gray@gmail.com> <20190327123314.GJ9224@smile.fi.intel.com> <20190328044004.GB3251@icarus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190328044004.GB3251@icarus> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_021159_354779_3A74C94E X-CRM114-Status: GOOD ( 14.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Geert Uytterhoeven , linux-gpio@vger.kernel.org, yamada.masahiro@socionext.com, linus.walleij@linaro.org, linux-pm@vger.kernel.org, linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org, bgolaszewski@baylibre.com, geert@linux-m68k.org, akpm@linux-foundation.org, preid@electromag.com.au, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 28, 2019 at 01:40:04PM +0900, William Breathitt Gray wrote: > On Wed, Mar 27, 2019 at 02:33:14PM +0200, Andy Shevchenko wrote: > > On Wed, Mar 27, 2019 at 02:02:39PM +0900, William Breathitt Gray wrote: > > > Replace verbose implementation in set_multiple callback with > > > for_each_set_clump8 macro to simplify code and improve clarity. > > > > > + for_each_set_clump8(offset, bankmask, mask, chip->registers * 8) { > > > > > + bank = (chip->registers - 1) - (offset / 8); > > > > Excessive parens, but it's minor. > > Fair point, this could do without parens around (chip->registers - 1). And around division too. > Since this and renaming 'idx' to 'index' in find_bit.c are such a minor > changes, I'll wait first to see if something else comes up to be fixed > in this review. If so, I'll add these changes to the next version of > this patchset. It seems inline proposal would going to be implemented. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel