From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ACBFC43381 for ; Thu, 28 Mar 2019 08:19:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F3712075E for ; Thu, 28 Mar 2019 08:19:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LVTZATAi"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=Synaptics.onmicrosoft.com header.i=@Synaptics.onmicrosoft.com header.b="Y8KDeN0d" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F3712075E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=synaptics.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R3aHnEqzhM6nlAB8eWjkF/CFMEHUTia0r/g2ScMo5VU=; b=LVTZATAieoezTj dbiokwYaETDPDRO4xCjyWs4W/R9GRVyRSMI70Y968P9ujA8wiM7W8PJpqUVNogCLW95M2MsbVmrsN nKOoVMpHKGm4bNDDQTQqopyt1yNNWwufdLRksAI/6N6NfH+vqG8atd5k+4iL1LNHokhg87XZCyrME 6pwnTYMSEdpUK39ED9ZOUrShCv+CXpFq76K6I3PLewdG17qoVb9LP9RWYFM5oQ1V3KlVoBvzvhxvi z6M1EpYklvu+Kxhi8hOelJwTcves6VnYCDKZJLOp9DupkCbUgkZMJthTXv9e6wbAw4a+9OXx2pAae FlYn2X60AfqJiHhrDTEQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9QGA-0005Sl-20; Thu, 28 Mar 2019 08:19:38 +0000 Received: from mail-sn1nam01on060d.outbound.protection.outlook.com ([2a01:111:f400:fe40::60d] helo=NAM01-SN1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9QG6-0005SN-Oy for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2019 08:19:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Synaptics.onmicrosoft.com; s=selector1-synaptics-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Enu7mOy1HEo6goXa25iQN7TJyfW+ftKIvzvI2LIXjcM=; b=Y8KDeN0dhn8wtmSA6qQCjL7LeoHBHUvvYZm6+8VEhsCCwDJ1MQCe6yTCCzBK3/Z+5JxWfA6Omc0xsFRhkK/s5aVPlGEtUhdyshSbhDT6UAFQSPJHp/D/RINNwKgKsned7pcRnDx8V5eVZgzM73SIOmh9vgPTU0yehf/00QlM7bQ= Received: from BYAPR03MB4773.namprd03.prod.outlook.com (20.179.92.152) by BYAPR03MB4856.namprd03.prod.outlook.com (20.179.93.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.15; Thu, 28 Mar 2019 08:19:23 +0000 Received: from BYAPR03MB4773.namprd03.prod.outlook.com ([fe80::1a8:1bc4:174b:472b]) by BYAPR03MB4773.namprd03.prod.outlook.com ([fe80::1a8:1bc4:174b:472b%2]) with mapi id 15.20.1750.017; Thu, 28 Mar 2019 08:19:23 +0000 From: Jisheng Zhang To: Jon Hunter Subject: Re: [PATCH 10/10] arm64: Add Tegra194 PCIe driver to defconfig Thread-Topic: [PATCH 10/10] arm64: Add Tegra194 PCIe driver to defconfig Thread-Index: AQHU4+b3PucYz59KkkehxhOgOKi32aYfQluAgAABDwCAACV7gIABSwgA Date: Thu, 28 Mar 2019 08:19:23 +0000 Message-ID: <20190328161138.1b37d232@xhacker.debian> References: <1553613207-3988-1-git-send-email-vidyas@nvidia.com> <1553613207-3988-11-git-send-email-vidyas@nvidia.com> <44d7ff1d-c317-6ba2-86c0-981a6356ee9e@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [124.74.246.114] x-clientproxiedby: TY2PR02CA0006.apcprd02.prod.outlook.com (2603:1096:404:56::18) To BYAPR03MB4773.namprd03.prod.outlook.com (2603:10b6:a03:134::24) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jisheng.Zhang@synaptics.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 377a1a94-d24a-450a-c680-08d6b3561589 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:BYAPR03MB4856; x-ms-traffictypediagnostic: BYAPR03MB4856: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-forefront-prvs: 0990C54589 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(366004)(376002)(346002)(39860400002)(199004)(189003)(6306002)(9686003)(6512007)(71190400001)(5660300002)(7736002)(53936002)(86362001)(105586002)(71200400001)(99286004)(53546011)(93886005)(386003)(68736007)(6436002)(229853002)(3846002)(6246003)(256004)(102836004)(4326008)(6506007)(66066001)(305945005)(7406005)(7416002)(966005)(81166006)(6116002)(316002)(26005)(8676002)(1076003)(54906003)(81156014)(25786009)(106356001)(50226002)(8936002)(11346002)(97736004)(76176011)(72206003)(478600001)(6916009)(486006)(52116002)(14454004)(2906002)(186003)(446003)(6486002)(476003)(39210200001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR03MB4856; H:BYAPR03MB4773.namprd03.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:0; MX:1; received-spf: None (protection.outlook.com: synaptics.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: sExreMZJiyXdnHBZqihWEIH1w+2hzuBcE5dh/pRLuTgwPDDeMC7ZUyUgnA3Bb1NcBeS8MqAaN7bgJcMbJCv8Ib3tC3pKqgldGDJ3qwum+VNERnuwE7pJ3cEs1b15Xiico2uRJjwQ3qezcVr/5ucBQDwIfiB1aL7xWUbZ1CpuArbeY4+NXOCELMU3NyY1FSMiMcC4M5AwbymiJXzCK0gKKcJ/Z/TMI/nWDZUFR8Vic7p97bhXsBHC1LDCjUfmEO7Dt15JQ9kEtmvW8h7ANzRlNDELsTz/pX3d48LFOUUcf52XTsU6tPgFX3Uujhgc4V7VNtwd5Nc2qPPVC8mOTHJIEKa6trHDXvtTMzgn+eb/gql8kioWMyPzBPzzNUFhIL8lC3jIGhoRRELu8R1t20LYaY8st/1R8t1xDOUgcs660jU= Content-ID: <2C9ADE63A27E1441B853A77492AD4DF5@namprd03.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: synaptics.com X-MS-Exchange-CrossTenant-Network-Message-Id: 377a1a94-d24a-450a-c680-08d6b3561589 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2019 08:19:23.5227 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335d1fbc-2124-4173-9863-17e7051a2a0e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4856 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_011934_863595_E97B8B12 X-CRM114-Status: GOOD ( 18.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "heiko@sntech.de" , "hayashi.kunihiko@socionext.com" , "tiwai@suse.de" , "catalin.marinas@arm.com" , "spujar@nvidia.com" , "will.deacon@arm.com" , "kthota@nvidia.com" , "mperttunen@nvidia.com" , "linux-tegra@vger.kernel.org" , "thierry.reding@gmail.com" , "stefan.wahren@i2se.com" , "lorenzo.pieralisi@arm.com" , "krzk@kernel.org" , "kishon@ti.com" , "maxime.ripard@bootlin.com" , "jagan@amarulasolutions.com" , "linux-pci@vger.kernel.org" , "andy.gross@linaro.org" , "shawn.lin@rock-chips.com" , "devicetree@vger.kernel.org" , "mmaddireddy@nvidia.com" , "marc.w.gonzalez@free.fr" , "liviu.dudau@arm.com" , "yue.wang@amlogic.com" , "enric.balletbo@collabora.com" , "robh+dt@kernel.org" , Bjorn Helgaas , "horms+renesas@verge.net.au" , "bjorn.andersson@linaro.org" , "ezequiel@collabora.com" , "linux-arm-kernel@lists.infradead.org" , "xiaowei.bao@nxp.com" , "gustavo.pimentel@synopsys.com" , "linux-kernel@vger.kernel.org" , Vidya Sagar , "skomatineni@nvidia.com" , "jingoohan1@gmail.com" , "olof@lixom.net" , "tpiepho@impinj.com" , "l.stach@pengutronix.de" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 27 Mar 2019 12:26:49 +0000 Jon Hunter wrote: > > > On 27/03/2019 10:12, Vidya Sagar wrote: > > On 3/27/2019 3:38 PM, Jon Hunter wrote: > >> > >> On 26/03/2019 15:13, Vidya Sagar wrote: > >>> Add PCIe host controller driver for DesignWare core based > >>> PCIe controller IP present in Tegra194. > >>> > >>> Signed-off-by: Vidya Sagar > >>> --- > >>> arch/arm64/configs/defconfig | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > >>> index 2d9c39033c1a..2ddea5c4e87d 100644 > >>> --- a/arch/arm64/configs/defconfig > >>> +++ b/arch/arm64/configs/defconfig > >>> @@ -87,6 +87,7 @@ CONFIG_PCIE_QCOM=y > >>> CONFIG_PCIE_ARMADA_8K=y > >>> CONFIG_PCIE_KIRIN=y > >>> CONFIG_PCIE_HISI_STB=y > >>> +CONFIG_PCIE_TEGRA194=y > >>> CONFIG_ARM64_VA_BITS_48=y > >>> CONFIG_SCHED_MC=y > >>> CONFIG_NUMA=y > >> > >> Maybe building as a module is more appropriate here as I am not sure > >> that anyone else will want this built-in and it is not critical to > >> booting AFAIK. > > Since the DesignWare core framework doesn't yet have support for making > > this > > as a module, I added it as a built-in driver. I'll switch it to a module > > once support is available. > > Ah I see. We often get reports/patches if a driver has a removal > function but is defined in the Kconfig to only support being built-in. > > Does the designware core just need to export some symbols to support it > being a module? If so it maybe worth adding these as part of the series > to see if it is acceptable, otherwise it might not get done and there is > no point us supporting it as a module. After https://lkml.org/lkml/2019/3/18/363 we could implement the "remove" Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel