From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EA89C43381 for ; Thu, 28 Mar 2019 17:43:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0428F20823 for ; Thu, 28 Mar 2019 17:43:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pzKFa5Sg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0428F20823 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i5ot7AuI75/iKk72cjHp5Ef2aC9vSgSDMmzEUAZhZ04=; b=pzKFa5SgZRM9hm pPGwGBajOVekNqk3NSpFFdTR3N/QzZg/3Nuhe09qoEZan8BtF6zJtzlbrkwOBByAvEHmCBfoIL/dF 1beGnJuQzBr0TYotnNuiPWJRAbbKanebcMPqWp91pnVUz8XxV6LQhYet+xm56r6dv2p8UumsETS5e sE6/jui6X0+zHSVriIvQKLKPaR9kWlbx9KPD9Sm0S/UCX08Hd91sAZ8vyQ8igJRx6gJcofAeUQoS+ 9M0LtJlf674GnzuEUEgU/lPN/YO/zeHsZzx7P6ZK5F+gRiV1H50Y0PP75bMuRDyfUCPMk8JK8rmTK CgOPcL2/B4mguD/jqaNA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9Z3G-0008MO-AE; Thu, 28 Mar 2019 17:42:54 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9Z3C-0008LZ-VB for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2019 17:42:52 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B00B380D; Thu, 28 Mar 2019 10:42:48 -0700 (PDT) Received: from queper01-lin (queper01-lin.cambridge.arm.com [10.1.195.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4AD313F557; Thu, 28 Mar 2019 10:42:46 -0700 (PDT) Date: Thu, 28 Mar 2019 17:42:36 +0000 From: Quentin Perret To: Daniel Lezcano Subject: Re: [PATCH 1/3] arm64: defconfig: Enable CONFIG_ENERGY_MODEL Message-ID: <20190328174233.jthsdzxrzmzpjnqd@queper01-lin> References: <20190328101352.25657-1-quentin.perret@arm.com> <20190328101352.25657-2-quentin.perret@arm.com> <20190328102206.doqj5fykqlld7jkd@queper01-lin> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_104251_005529_1A82279F X-CRM114-Status: GOOD ( 17.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, viresh.kumar@linaro.org, amit.kachhap@gmail.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, will.deacon@arm.com, edubezval@gmail.com, catalin.marinas@arm.com, rui.zhang@intel.com, javi.merino@kernel.org, ionela.voinescu@arm.com, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Daniel, On Thursday 28 Mar 2019 at 18:27:49 (+0100), Daniel Lezcano wrote: > On 28/03/2019 11:22, Quentin Perret wrote: > >> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > >> index 2d9c39033c1a..3c09bdaaefd3 100644 > >> --- a/arch/arm64/configs/defconfig > >> +++ b/arch/arm64/configs/defconfig > >> @@ -97,6 +97,7 @@ CONFIG_XEN=y > >> CONFIG_COMPAT=y > >> CONFIG_HIBERNATION=y > >> CONFIG_WQ_POWER_EFFICIENT_DEFAULT=y > >> +CONFIG_ENERGY_MODEL=n > > > > Hmm, sorry I turned this to '=n' for testing and forgot to update the > > patch. This obviously should be '=y' ... > > I did a test without the ENERGY_MODEL config option set, dhrystone and > the power_allocator policy on the hikey. The board did not mitigate well > and ended up rebooting. OK ... And is the same thing happening if you just run mainline w/o the dynamic-power-coefficient binding set for example ? The result _should_ be the same. If not, then perhaps I missed something. I'll try to reproduce on my end. Just to be sure, when you say hikey, you mean hikey960 ? Or 620 ? In any case, thanks for testing :-) > May be the cpu cooling Kconfig option should add > a SELECT or a DEPENDS on ENERGY_MODEL ? Right, I've been wondering the same thing. I'm not a big fan of 'select' because enabling ENERGY_MODEL automatically for the thermal stuff will also happen to enable other things (EAS) without the user knowing. So I'd rather keep the ENERGY_MODEL option explicit. But perhaps having THERMAL_GOV_POWER_ALLOCATOR 'depend on ENERGY_MODEL' could work. It's just that there is no _strong_ dependency, the IPA code isn't supposed to crash even if there is no EM ... Thanks, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel