From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1982C43381 for ; Thu, 28 Mar 2019 18:00:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 375B820651 for ; Thu, 28 Mar 2019 18:00:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N1Z1aByW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 375B820651 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YjfKmbyo5Bu3YGxaCNhqwrM2uF5yd1fZi356G6ixsIU=; b=N1Z1aByWOkPpTU 3DTbApbxUvwNGXltHq7JOBjdU5fXcUN5O+rXqs+aa3NsFW8wl2rXjYwS3ncVnhOMhIvm47enLAMHD Y3q97buk42kza5JcvEtB8SKcai/pvCEBbdv6ugi7hbirJd37/ffochOgkZPPovpkdeKBdzWsDS1Oh ZJmLfq81wmQIYa05I7BDX/Hi9aE/eVsWur+6rAgewbWMojUBnSeVS7LK/5/INWEL7iSdY4pU4/d6l kKQVNUPe99lRZrpU4oixzjDxx/G3iIZfb72rfpXScKShLjssTIvbwlwyrJvMLRBvE2D97GmwbqSxd FlS+8fbSjUV5Q0x+U0xQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9ZJm-0006hT-Va; Thu, 28 Mar 2019 17:59:58 +0000 Received: from mail-ot1-f67.google.com ([209.85.210.67]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9ZJj-0006gU-Fj; Thu, 28 Mar 2019 17:59:57 +0000 Received: by mail-ot1-f67.google.com with SMTP id o74so19204996ota.3; Thu, 28 Mar 2019 10:59:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=xQNxxs+ysHE81A+umKaN1DTeFmXockFMUA8sFOkGQXk=; b=rgQ0Ez+Qlz6vMxB6rSdaLWvNpid+KsdIHdlvxkwkIXy63wGdyfuXddTyyXMhXJR0ju wDAHwOSmibg7eOT33cZABmhBEVuJYLEV1pxawkPOWoJsa/O4qyHbvawwjgPqpNYMWVNk xa+Fd8csralZughdOJ25S5O08pvGsOFEhX+eKreOyVYAdTEi5GyC6fyzCMdbkl83fhLR op4P4J20dioat7RT+zCr0phAYWubrnjTrMCrmKM95mNT8i2RnaFor+WVCU6G9vPn5WJ/ GbyQ/9iS2tPvPijSoMkJk+kPFIE665ZNaUmIwtLS3XTwMeIPCvzxMWGJPgV/P5doyozJ PlpQ== X-Gm-Message-State: APjAAAWQGC+ZJxwBPmolLMaVxemRzbb400E2GNNM/xv+7HeO7gwcFH6S +GxYKY/F0sFX72T+lbISPQ== X-Google-Smtp-Source: APXvYqyNENE2uY0GfQsNQEmHQC1ktS+ZgeKveDp6C9wUadQjf1gOsBXctsR4zYau+o+lSa+TPEDvPA== X-Received: by 2002:a9d:6393:: with SMTP id w19mr27941797otk.257.1553795993863; Thu, 28 Mar 2019 10:59:53 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id r67sm10236656oib.18.2019.03.28.10.59.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 10:59:52 -0700 (PDT) Date: Thu, 28 Mar 2019 12:59:52 -0500 From: Rob Herring To: =?iso-8859-1?Q?Ga=EBl?= PORTAY Subject: Re: [PATCH v3 4/5] arm64: dts: rk3399: Add dfi and dmc nodes. Message-ID: <20190328175952.GA21288@bogus> References: <20190321231440.19031-1-gael.portay@collabora.com> <20190321231440.19031-5-gael.portay@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190321231440.19031-5-gael.portay@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_105955_525370_4D3E6D03 X-CRM114-Status: GOOD ( 17.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Derek Basehore , Heiko Stuebner , linux-pm@vger.kernel.org, Brian Norris , Douglas Anderson , linux-kernel@vger.kernel.org, Chanwoo Choi , Kyungmin Park , MyungJoo Ham , Klaus Goger , Enric Balletbo i Serra , linux-rockchip@lists.infradead.org, Randy Li , linux-arm-kernel@lists.infradead.org, Lin Huang Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 21, 2019 at 07:14:39PM -0400, Ga=EBl PORTAY wrote: > From: Lin Huang > = > These are required to support DDR DVFS on rk3399 platform. The patch also > introduces a new file with default DRAM settings. > = > Signed-off-by: Lin Huang > Signed-off-by: Enric Balletbo i Serra > Signed-off-by: Ga=EBl PORTAY > --- > = > Changes in v3: None > = > Changes in v2: > - [PATCH 7/8] Reword the commit message to reflect the removal of > rk3390-dram-default-timing.dts in v1. > = > Changes in v1: > - [RFC 8/10] Move rk3399-dram.h to dt-includes. > - [RFC 8/10] Put sdram default values under the dmc node. > - [RFC 8/10] Removed rk3399-dram-default-timing.dts > = > .../boot/dts/rockchip/rk3399-op1-opp.dtsi | 29 ++++++++ > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 49 +++++++++++++ > include/dt-bindings/power/rk3399-dram.h | 73 +++++++++++++++++++ > 3 files changed, 151 insertions(+) > create mode 100644 include/dt-bindings/power/rk3399-dram.h > = > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-op1-opp.dtsi b/arch/arm6= 4/boot/dts/rockchip/rk3399-op1-opp.dtsi > index 69cc9b05baa5..c9e7032b01a8 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-op1-opp.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-op1-opp.dtsi > @@ -110,6 +110,31 @@ > opp-microvolt =3D <1075000>; > }; > }; > + > + dmc_opp_table: dmc_opp_table { > + compatible =3D "operating-points-v2"; > + > + opp00 { > + opp-hz =3D /bits/ 64 <200000000>; > + opp-microvolt =3D <900000>; > + }; > + opp01 { > + opp-hz =3D /bits/ 64 <400000000>; > + opp-microvolt =3D <900000>; > + }; > + opp02 { > + opp-hz =3D /bits/ 64 <666000000>; > + opp-microvolt =3D <900000>; > + }; > + opp03 { > + opp-hz =3D /bits/ 64 <800000000>; > + opp-microvolt =3D <900000>; > + }; > + opp04 { > + opp-hz =3D /bits/ 64 <928000000>; > + opp-microvolt =3D <900000>; > + }; > + }; > }; > = > &cpu_l0 { > @@ -139,3 +164,7 @@ > &gpu { > operating-points-v2 =3D <&gpu_opp_table>; > }; > + > +&dmc { > + operating-points-v2 =3D <&dmc_opp_table>; > +}; > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/d= ts/rockchip/rk3399.dtsi > index db9d948c0b03..8fe86a3e7658 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -8,6 +8,7 @@ > #include > #include > #include > +#include > #include > #include > = > @@ -1885,6 +1886,54 @@ > status =3D "disabled"; > }; > = > + dfi: dfi@ff630000 { > + reg =3D <0x00 0xff630000 0x00 0x4000>; > + compatible =3D "rockchip,rk3399-dfi"; > + rockchip,pmu =3D <&pmugrf>; > + interrupts =3D ; > + clocks =3D <&cru PCLK_DDR_MON>; > + clock-names =3D "pclk_ddr_mon"; > + status =3D "disabled"; > + }; > + > + dmc: dmc { > + compatible =3D "rockchip,rk3399-dmc"; > + rockchip,pmu =3D <&pmugrf>; > + devfreq-events =3D <&dfi>; > + clocks =3D <&cru SCLK_DDRC>; > + clock-names =3D "dmc_clk"; > + status =3D "disabled"; > + rockchip,ddr3_speed_bin =3D <21>; > + rockchip,pd_idle =3D <0x40>; > + rockchip,sr_idle =3D <0x2>; > + rockchip,sr_mc_gate_idle =3D <0x3>; > + rockchip,srpd_lite_idle =3D <0x4>; > + rockchip,standby_idle =3D <0x2000>; > + rockchip,dram_dll_dis_freq =3D <300000000>; > + rockchip,phy_dll_dis_freq =3D <125000000>; > + rockchip,auto_pd_dis_freq =3D <666000000>; > + rockchip,ddr3_odt_dis_freq =3D <333000000>; > + rockchip,ddr3_drv =3D ; > + rockchip,ddr3_odt =3D ; > + rockchip,phy_ddr3_ca_drv =3D ; > + rockchip,phy_ddr3_dq_drv =3D ; > + rockchip,phy_ddr3_odt =3D ; > + rockchip,lpddr3_odt_dis_freq =3D <333000000>; > + rockchip,lpddr3_drv =3D ; > + rockchip,lpddr3_odt =3D ; > + rockchip,phy_lpddr3_ca_drv =3D ; > + rockchip,phy_lpddr3_dq_drv =3D ; > + rockchip,phy_lpddr3_odt =3D ; > + rockchip,lpddr4_odt_dis_freq =3D <333000000>; > + rockchip,lpddr4_drv =3D ; > + rockchip,lpddr4_dq_odt =3D ; > + rockchip,lpddr4_ca_odt =3D ; > + rockchip,phy_lpddr4_ca_drv =3D ; > + rockchip,phy_lpddr4_ck_cs_drv =3D ; > + rockchip,phy_lpddr4_dq_drv =3D ; > + rockchip,phy_lpddr4_odt =3D ; These settings aren't board specific? Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel