From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABAF8C43381 for ; Fri, 29 Mar 2019 02:45:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7AF252183E for ; Fri, 29 Mar 2019 02:45:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="P0viLSta"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="E9JMz51+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AF252183E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kms2mYGkgdm8vuycRLSM9P74ynresGScRQu6cnAmFR8=; b=P0viLStaXTCDBN G7ur7A/eBxUtt2vo/JncJ2Ojoj6AxICEYw5UsX9oVKRNRKPgyeX6an2gIFrF33RFWdDU43QqyceKR M9aXYUUVrP6C7GPX4XB50mPkCjBR9wSkvmm3pnW1lfodt0mslQ38IDVwuro6vtbNELsZ9lT87Cso8 tRnFgDhqcWYuhQL7VteZihLU3xfcWgxPvNR0AQE9UfKfScVOo6+UXfcV195GFzTgpBjFBQ337pqlD SirkPiTpVD8SWQhRcrSqvOVjmkRwlLqMyhHfUdckzBIguUKxqWsevtBEh99RuOsSuSv/0CZNUttHC 14tinAEGySPEy64STxAw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9hWX-0004uf-0r; Fri, 29 Mar 2019 02:45:41 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9hWU-0004uJ-J9 for linux-arm-kernel@lists.infradead.org; Fri, 29 Mar 2019 02:45:39 +0000 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DF9612183E; Fri, 29 Mar 2019 02:45:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553827536; bh=NhKqb7LAhcn7yuiQfzViWeTdXRAKGRz3BqSXfXWsFB0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E9JMz51+KKBfzBv5xG5mIh8KYNrTttJ/JlDh2v9nm5MqqVccnWNrdYomokIZkr4Bk 2oy8HOetZUbYpnTIkD4oHuw6EOxM+4fns3yddJXev96k/EvJKhZF4wip9BHSMNMJRr KOpc+x5ynJzXk93VS2qIUvVGQu/2Sj+DB6WZ6g2Y= Date: Fri, 29 Mar 2019 10:44:50 +0800 From: Shawn Guo To: Jonathan =?iso-8859-1?Q?Neusch=E4fer?= Subject: Re: [PATCH 2/5] ARM: dts: imx50: Add Kobo Aura DTS Message-ID: <20190329024449.GM12513@dragon> References: <20190319152421.16179-1-j.neuschaefer@gmx.net> <20190319152421.16179-3-j.neuschaefer@gmx.net> <20190322013151.GR12513@dragon> <20190326162653.GD2095@latitude> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190326162653.GD2095@latitude> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_194538_652901_8ECE2115 X-CRM114-Status: GOOD ( 14.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Heiko Stuebner , Martin Blumenstingl , Kevin Hilman , Sascha Hauer , Johan Hovold , linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Manivannan Sadhasivam , Thierry Reding , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Jagan Teki Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 26, 2019 at 05:26:53PM +0100, Jonathan Neusch=E4fer wrote: > Hi, thanks for your comments. I'll address them in v2. > = > On Fri, Mar 22, 2019 at 09:31:53AM +0800, Shawn Guo wrote: > > On Tue, Mar 19, 2019 at 04:24:17PM +0100, Jonathan Neusch=E4fer wrote: > > > The Kobo Aura is an e-book reader released in 2013. > [...] > > > + sd2_pwrseq: pwrseq { > > > + compatible =3D "mmc-pwrseq-simple"; > > > + pinctrl-names =3D "default"; > > > + pinctrl-0 =3D <&pinctrl_sd2_reset>; > > > + > > = > > Please do not have random newlines. > = > Does that apply to all empty lines between properties? Yes, that's what we do for i.MX device trees. > = > > = > > > + reset-gpios =3D <&gpio4 17 GPIO_ACTIVE_LOW>; > > > + }; > > > + > [...] > > > +&iomuxc { > > > + pinctrl_uart2: uart2 { > > > + fsl,pins =3D < > > > + MX50_PAD_UART2_TXD__UART2_TXD_MUX 0x1e4 > > > + MX50_PAD_UART2_RXD__UART2_RXD_MUX 0x1e4 > > > + >; > > > + }; > > > + > > > + pinctrl_i2c1: i2c1 { > > = > > Please sort these pinctrl nodes alphabetically. > = > It doesn't make a difference here, but should I generally sort by name > or by label in cases like this one? Keep using the naming schema below, and it always makes no difference then. pinctrl_xxx: xxx Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel