From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5034C43381 for ; Fri, 29 Mar 2019 12:12:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CF322183E for ; Fri, 29 Mar 2019 12:12:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Zm7d71mi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CF322183E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kCtuylW3hCGKomqvDxybqL3LL/hoLWzrHSa/ExzYigk=; b=Zm7d71miloTd7K RL/F734vncl0tMAiDqo0bJLMuEAG17/LV6WsXQ3gbddCjyuVv1AnTE8k5YYbSpxF8yUxE8+qIZOoZ Vz/nVfuDp8KVMFGj5ArKzSOo+R0GK4ramHE2OoOjeMy3sUCEKURck5oeafnHIVa6o6EYsQ2bGETj7 99WUkSzfeXMUuD7BbVMEm9iYFnzTy3yIWFFqen5LUlBQ5X3cIV+qi+CHjc2sqFazSw26J+gkpfxEZ zr8Trkmz3J5rZxZWJ56BHwbWGkDUHwzzQ5KWpp7VZjSwhV7MCFB0R7K09NAOutBr3+9MKHDVxAyBe gpDWB3LTnNtt9aWHa4qg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9qMx-0005HS-75; Fri, 29 Mar 2019 12:12:23 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9qMt-0005Go-PN for linux-arm-kernel@lists.infradead.org; Fri, 29 Mar 2019 12:12:20 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6ADB780D; Fri, 29 Mar 2019 05:12:18 -0700 (PDT) Received: from mbp (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 303DA3F575; Fri, 29 Mar 2019 05:12:17 -0700 (PDT) Date: Fri, 29 Mar 2019 12:12:14 +0000 From: Catalin Marinas To: Vincenzo Frascino Subject: Re: [PATCH 1/5] arm64: compat: Alloc separate pages for vectors and sigpage Message-ID: <20190329121211.gv7i7fqt74h3rtls@mbp> References: <20190319151542.19557-1-vincenzo.frascino@arm.com> <20190319151542.19557-2-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190319151542.19557-2-vincenzo.frascino@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190329_051219_831064_F4B98F12 X-CRM114-Status: GOOD ( 11.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Mark Rutland , Will Deacon , linux-arm-kernel@lists.infradead.org, Jann Horn Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 19, 2019 at 03:15:38PM +0000, Vincenzo Frascino wrote: > +static int __init aarch32_alloc_vdso_pages(void) > { > extern char __kuser_helper_start[], __kuser_helper_end[]; > extern char __aarch32_sigret_code_start[], __aarch32_sigret_code_end[]; > > int kuser_sz = __kuser_helper_end - __kuser_helper_start; > int sigret_sz = __aarch32_sigret_code_end - __aarch32_sigret_code_start; > - unsigned long vpage; > + unsigned long vdso_pages[2]; > > - vpage = get_zeroed_page(GFP_ATOMIC); > + vdso_pages[0] = get_zeroed_page(GFP_ATOMIC); > + if (!vdso_pages[0]) > + return -ENOMEM; > > - if (!vpage) > + vdso_pages[1] = get_zeroed_page(GFP_ATOMIC); > + if (!vdso_pages[1]) > return -ENOMEM; > > /* kuser helpers */ > - memcpy((void *)vpage + 0x1000 - kuser_sz, __kuser_helper_start, > - kuser_sz); > + memcpy((void *)(vdso_pages[0] + 0x1000 - kuser_sz), > + __kuser_helper_start, > + kuser_sz); > > /* sigreturn code */ > - memcpy((void *)vpage + AARCH32_KERN_SIGRET_CODE_OFFSET, > - __aarch32_sigret_code_start, sigret_sz); > + memcpy((void *)vdso_pages[1], > + __aarch32_sigret_code_start, > + sigret_sz); > > - flush_icache_range(vpage, vpage + PAGE_SIZE); > - vectors_page[0] = virt_to_page(vpage); > + flush_icache_range(vdso_pages[0], vdso_pages[0] + PAGE_SIZE); > + flush_icache_range(vdso_pages[1], vdso_pages[1] + PAGE_SIZE); I wonder whether we still need the flush_icache_range() calls here. Normally set_pte_at() handles cache maintenance automatically if PG_dcache_clean is not set. We could probably just call flush_dcache_page() here. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel