From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E1E9C43381 for ; Mon, 1 Apr 2019 07:39:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 007F42084B for ; Mon, 1 Apr 2019 07:39:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="utHWjtN3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 007F42084B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pHsqY1K+bIfTIPXn1IbiS+OdugQzCoAWG9TQg/skCt0=; b=utHWjtN37wzW3i /7n0OyMEIGnoSvlJdIDkIrMaii7ivMzkjrIXCE4DgmA0qbX+OxnDRTq3YwwvV100FmqqgfIFAgXa9 HZ7npiAuEE81i9akOLXU4ZgOtRdX1WLHViYAB9WXAMwy5YdxeAH6l0hsI15ovivvp+4bwQ5vsggVH 3c/fPxDvzbGy52pGbnyGjgSGGHEnB+snX0xMU0ebyhMY6sjtgNRST+EiCO6l71nDimOH1/oh0qI1z c7LdtCVdF+gWMZpdRwF+0Hfb/9VxPLqLhUlejYdzH5RD/gWuv1gO+DOqz5go8G0A2rieenTSPFWkA sYMU2MHHpMNyt6yD6lmw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hArXM-0001qS-4f; Mon, 01 Apr 2019 07:39:20 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hArXJ-0001p4-C3 for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 07:39:18 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C641B374; Mon, 1 Apr 2019 00:39:14 -0700 (PDT) Received: from blommer (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E1CDC3F690; Mon, 1 Apr 2019 00:39:12 -0700 (PDT) Date: Mon, 1 Apr 2019 08:39:02 +0100 From: Mark Rutland To: Matteo Croce Subject: Re: [PATCH] arm64/vdso: don't leak kernel addresses Message-ID: <20190401073901.wun6lnthvbvq6gd4@blommer> References: <20190330184638.16219-1-mcroce@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190330184638.16219-1-mcroce@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_003917_411880_2D5FB472 X-CRM114-Status: GOOD ( 16.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Mar 30, 2019 at 07:46:38PM +0100, Matteo Croce wrote: > Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"), > two obfuscated kernel pointer are printed at every boot: > > vdso: 2 pages (1 code @ (____ptrval____), 1 data @ (____ptrval____)) > > Remove the addresses from the print, which turns into a more discrete: > > vdso: 2 pages (1 code, 1 data) > > Fixes: ad67b74d2469d9b8 ("printk: hash addresses printed with %p") > Signed-off-by: Matteo Croce > --- > arch/arm64/kernel/vdso.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kernel/vdso.c b/arch/arm64/kernel/vdso.c > index 2d419006ad43..fdfee0ef5bc5 100644 > --- a/arch/arm64/kernel/vdso.c > +++ b/arch/arm64/kernel/vdso.c > @@ -146,8 +146,8 @@ static int __init vdso_init(void) > } > > vdso_pages = (vdso_end - vdso_start) >> PAGE_SHIFT; > - pr_info("vdso: %ld pages (%ld code @ %p, %ld data @ %p)\n", > - vdso_pages + 1, vdso_pages, vdso_start, 1L, vdso_data); > + pr_info("vdso: %ld pages (%ld code, %ld data)\n", > + vdso_pages + 1, vdso_pages, 1L); It's probably better to drop this pr_info() entirely. The number of data and code pages hasn't changed since this was upstreamed, and the pointers were the useful part for debugging. If you respin this to delete the pr_info() entirely, then feel free to add: Acked-by: Mark Rutland Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel